New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622438 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove WaitForIncomingMethodCall and WaitForIncomingResponse

Project Member Reported by jam@chromium.org, Jun 22 2016

Issue description

Callers should be switched to use sync IPC calls.
 

Comment 1 by leon....@intel.com, Jun 23 2016

Hi, John, Ken, Yuzhu, can I take this issue if you have no time to do this? ;-)

Comment 2 by yzshen@chromium.org, Jun 23 2016

Owner: leon....@intel.com
Thanks for helping!


Comment 3 by leon....@intel.com, Jun 27 2016

Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83055f715f72c2394efd11b6bb17656899f4c9d0

commit 83055f715f72c2394efd11b6bb17656899f4c9d0
Author: leon.han <leon.han@intel.com>
Date: Sun Jul 10 05:30:12 2016

Eliminate usage of InterfacePtr::WaitForIncomingResponse.

This CL removes InterfacePtr::WaitForIncomingResponse definition
and replaces usage of them with either [Sync] call or
a nested MessageLoop waiting asynchronously.

BUG=622438

Review-Url: https://codereview.chromium.org/2096293002
Cr-Commit-Position: refs/heads/master@{#404579}

[modify] https://crrev.com/83055f715f72c2394efd11b6bb17656899f4c9d0/components/filesystem/directory_impl_unittest.cc
[modify] https://crrev.com/83055f715f72c2394efd11b6bb17656899f4c9d0/components/filesystem/file_impl_unittest.cc
[modify] https://crrev.com/83055f715f72c2394efd11b6bb17656899f4c9d0/components/filesystem/files_test_base.cc
[modify] https://crrev.com/83055f715f72c2394efd11b6bb17656899f4c9d0/components/filesystem/public/interfaces/directory.mojom
[modify] https://crrev.com/83055f715f72c2394efd11b6bb17656899f4c9d0/components/filesystem/public/interfaces/file.mojom
[modify] https://crrev.com/83055f715f72c2394efd11b6bb17656899f4c9d0/components/filesystem/public/interfaces/file_system.mojom
[modify] https://crrev.com/83055f715f72c2394efd11b6bb17656899f4c9d0/components/leveldb/leveldb_service_unittest.cc
[modify] https://crrev.com/83055f715f72c2394efd11b6bb17656899f4c9d0/components/leveldb/remote_iterator_unittest.cc
[modify] https://crrev.com/83055f715f72c2394efd11b6bb17656899f4c9d0/mash/catalog_viewer/catalog_viewer.cc
[modify] https://crrev.com/83055f715f72c2394efd11b6bb17656899f4c9d0/mojo/public/cpp/bindings/interface_ptr.h
[modify] https://crrev.com/83055f715f72c2394efd11b6bb17656899f4c9d0/mojo/public/cpp/bindings/lib/interface_ptr_state.h
[modify] https://crrev.com/83055f715f72c2394efd11b6bb17656899f4c9d0/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc
[modify] https://crrev.com/83055f715f72c2394efd11b6bb17656899f4c9d0/net/proxy/proxy_resolver_factory_mojo_unittest.cc
[modify] https://crrev.com/83055f715f72c2394efd11b6bb17656899f4c9d0/services/catalog/public/interfaces/catalog.mojom
[modify] https://crrev.com/83055f715f72c2394efd11b6bb17656899f4c9d0/services/ui/public/cpp/lib/command_buffer_client_impl.cc
[modify] https://crrev.com/83055f715f72c2394efd11b6bb17656899f4c9d0/services/ui/public/interfaces/command_buffer.mojom

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d3b0b6a6d105068e79dd14e2d37dea2de2a7500

commit 6d3b0b6a6d105068e79dd14e2d37dea2de2a7500
Author: leon.han <leon.han@intel.com>
Date: Fri Jul 22 03:34:18 2016

Use spin runloop instead of WaitForIncomingMethodCall() for test codes.

This CL replaces usage of Binding::WaitForIncomingMethodCall() with
a spin runloop waiting for incoming call or a connection error.
Affected test codes are within:
  components/arc/
  services/shell/

BUG=622438

Review-Url: https://codereview.chromium.org/2135223002
Cr-Commit-Position: refs/heads/master@{#407029}

[modify] https://crrev.com/6d3b0b6a6d105068e79dd14e2d37dea2de2a7500/components/arc/test/fake_arc_bridge_instance.cc
[modify] https://crrev.com/6d3b0b6a6d105068e79dd14e2d37dea2de2a7500/components/arc/test/fake_arc_bridge_instance.h
[modify] https://crrev.com/6d3b0b6a6d105068e79dd14e2d37dea2de2a7500/services/shell/tests/shutdown/shutdown_client_app.cc

Components: -Internals>Mojo Internals>Mojo>Bindings
Cc: -roc...@chromium.org rockot@google.com

Sign in to add a comment