New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622432 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Not currently working on Chromium
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 3
Type: Bug

Blocking:
issue 580406
issue 586438



Sign in to add a comment

SimulateLowEnergyDevice(5) is unimplemented for bluez

Project Member Reported by ejcaruso@chromium.org, Jun 22 2016

Issue description

BluetoothTestBase defines device_ordinal 5 in SimulateLowEnergyDevice:

  //   5: Device with no name, with no advertised UUIDs and address
  //      kTestDeviceAddress1.

However we return NULL in BluetoothTestBlueZ.
 

Comment 1 by ortuno@chromium.org, Jun 22 2016

Blocking: 580406
Status: Available (was: Untriaged)

Comment 2 by st...@chromium.org, Aug 24 2016

Cc: st...@chromium.org

Comment 3 by st...@chromium.org, Aug 24 2016

Cc: -r...@chromium.org

Comment 4 by scheib@chromium.org, Oct 21 2016

Blocking: 586438
Status: Started (was: Available)
Summary: SimulateLowEnergyDevice(5) is unimplemented for bluez (was: SimulateLowEnergyDvice(5) is unimplemented for bluez)

Comment 5 by scheib@chromium.org, Oct 21 2016

Owner: scheib@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/667ebea934cb8baee8915753c4635bc88d8716ad

commit 667ebea934cb8baee8915753c4635bc88d8716ad
Author: scheib <scheib@chromium.org>
Date: Sat Nov 05 00:05:09 2016

bluetooth: bluez: GetName uses 'name' instead of 'alias'.

BlueZ produces an 'alias' that includes the MAC address of
a remote device when the device name is unknown. Client
code of device/bluetooth must be able to detect an empty
name and also protect private information such as nearby
MAC addresses from being shared.

This patch changes our implementation to use the BlueZ
provided 'name' instead of 'alias'.

SimulateLowEnergyDvice(5) is implemented ( crbug.com/622432 )
to enable testing this change.

BUG= 586438 , 622432 

Review-Url: https://codereview.chromium.org/2440043002
Cr-Commit-Position: refs/heads/master@{#430068}

[modify] https://crrev.com/667ebea934cb8baee8915753c4635bc88d8716ad/chrome/browser/ui/webui/options/chromeos/bluetooth_options_browsertest.js
[modify] https://crrev.com/667ebea934cb8baee8915753c4635bc88d8716ad/device/bluetooth/bluetooth_device_unittest.cc
[modify] https://crrev.com/667ebea934cb8baee8915753c4635bc88d8716ad/device/bluetooth/bluez/bluetooth_adapter_bluez.cc
[modify] https://crrev.com/667ebea934cb8baee8915753c4635bc88d8716ad/device/bluetooth/bluez/bluetooth_bluez_unittest.cc
[modify] https://crrev.com/667ebea934cb8baee8915753c4635bc88d8716ad/device/bluetooth/bluez/bluetooth_device_bluez.cc
[modify] https://crrev.com/667ebea934cb8baee8915753c4635bc88d8716ad/device/bluetooth/dbus/fake_bluetooth_device_client.cc
[modify] https://crrev.com/667ebea934cb8baee8915753c4635bc88d8716ad/device/bluetooth/dbus/fake_bluetooth_device_client.h
[modify] https://crrev.com/667ebea934cb8baee8915753c4635bc88d8716ad/device/bluetooth/test/bluetooth_test_bluez.cc

Status: Fixed (was: Started)

Comment 8 by st...@chromium.org, Mar 3 2017

Cc: r...@chromium.org

Comment 9 by st...@chromium.org, Mar 3 2017

Cc: -st...@chromium.org

Sign in to add a comment