New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622431 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Regression: windows resized on unlock with "Left" shelf position

Project Member Reported by bcmi...@google.com, Jun 22 2016

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 8350.31.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.41 Safari/537.36
Platform: 8350.31.0 (Official Build) beta-channel panther

Steps to reproduce the problem:
1) Right click the shelf and set "Shelf position > Left"
2) Open a new window.
3) Press Alt+] to snap the window to half-screen-maximized.
4) Press Ctrl+Shift+L to lock the screen.
5) Enter password to unlock the screen.

What is the expected behavior?
The window retains the same size and position it was in before the screen was locked.

What went wrong?
There is now a vertical gap below the window, as though it has been displaced by the (nonexistent) bottom shelf.

Did this work before? Yes May 2016

Chrome version: 52.0.2743.41  Channel: beta
OS Version: 8350.31.0
Flash Version: Shockwave Flash 22.0 r0
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 23 2016

Labels: Hotlist-Google
Owner: warx@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/074006e2e9f8c05f624876b54abc07fbb4658215

commit 074006e2e9f8c05f624876b54abc07fbb4658215
Author: warx <warx@chromium.org>
Date: Mon Jun 27 05:54:07 2016

Docked windows resized on unlock with vertical shelf position

It is because there is a new added shelf state: SHELF_ALIGNMENT_BOTTOM_LOCKED for locked state, and it can change the display work area some time from locked state to unlocked state.

BUG= 622431 
TEST=manually test saw bug goes away.

Review-Url: https://codereview.chromium.org/2092863004
Cr-Commit-Position: refs/heads/master@{#402120}

[modify] https://crrev.com/074006e2e9f8c05f624876b54abc07fbb4658215/ash/shelf/shelf_layout_manager.cc

Comment 4 by warx@chromium.org, Jun 27 2016

Status: Fixed (was: Assigned)
Labels: VerifyIn-53

Comment 6 by msw@chromium.org, Jul 6 2016

 Issue 625544  has been merged into this issue.
I have received update Version 52.0.2743.116 (64-bit) Stable and the problem persists. ETA on fix?

Thanks.

Comment 8 by warx@chromium.org, Aug 11 2016

should be available on M53 stable channel.
Thanks for the update. There a timetable for M53?

Comment 10 by warx@chromium.org, Aug 11 2016

Sep 6th
Labels: VerifyIn-54
Labels: VerifyIn-55
Status: Verified (was: Fixed)
Verified on ChromeOS 8872.18.0, 55.0.2883.20

Comment 14 by bcmi...@google.com, Jan 13 2017

This is still an issue for me, but it might only occur on reboot now.  (All of my windows are being resized to the incorrect shelf position on every reboot.)

Version 56.0.2924.58 beta (64-bit)
Platform 9000.58.0 (Official Build) beta-channel stumpy
Firmware Google_Stumpy.2.102.0
I still get this issue all the time... like literally every 20 or 30
minutes i have to move my windows to get them fixed.
Status: Assigned (was: Verified)
Re-opening as per comments #14 and #15.

Comment 17 by warx@chromium.org, Jan 17 2017

Status: Fixed (was: Assigned)
Let us still mark this as fixed based on the reporter's repro steps. #14 and #15 should be  issue 679208 .
I posted comment #15. It isn't  issue 679208 . My issue is that my windows drop "beneath" the shelf. The shelf position isn't the problem. The problem is that windows incorrectly resize to a vertical position beneath the shelf, whereas the lowest they should go is the top of the shelf.

Comment 19 by bcmi...@google.com, Jan 17 2017

My issue is not 679208 either: when I log in the shelves are in the correct positions, it's just that the windows have been shrunk by the height of the (nonexistent) bottom shelf.

Comment 20 by warx@chromium.org, Jan 17 2017

Cc: abodenha@chromium.org msw@chromium.org
Status: Assigned (was: Fixed)
OK. There are some shelf related changes recently. On tot (m57), the behavior is:
(1) shelf left
(2) browser window right snapped by pressing alt+]
(3) sign out
(4) sign in, find that shelf is set to bottom, which is  issue 679208 .

on latest m56 build, it is:
(1) shelf left
(2) browser window right snapped by pressing alt+]
(3) sign out
(5) sign in, shelf is still left, but browser window shrinks by a "shelf height".

Both of them are related to signout and signin, not locking/unlocking. I will file a bug for this.

Per comment 15 and 18, from your description, it seems your snapped window is gradually moving down? I am not sure what it is. If so, this should be a new bug.

cc msw@, abodenha@.

Comment 21 by warx@chromium.org, Feb 9 2017

Status: Fixed (was: Assigned)
Still close this because locking/unlocking works fine. It only happens on signout and signin.
Status: Verified (was: Fixed)
Verified based on the reporter's repro steps.

Sign in to add a comment