New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622424 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 622763



Sign in to add a comment

Last N==1

Project Member Reported by dewittj@chromium.org, Jun 22 2016

Issue description

This bug tracks work done to support Last N==1, the feature where each tab will have a single offline page associated with it.

Work items:
* Modify RecentTabHelper to only save one copy per page.
* Modify OfflinePageTabHelper to only redirect if a page is for the current tab.
* Modify NTP to not show results for last n == 1 pages.
 
Blocking: 622763
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a57193f0add291fb6d5e6c9072a718c49db4c80

commit 1a57193f0add291fb6d5e6c9072a718c49db4c80
Author: dewittj <dewittj@chromium.org>
Date: Thu Jun 23 17:26:16 2016

Temporarily remove "last_n" from availability searches.

This is a part of the Last N==1 feature, which associates a single
offline page with a particular tab.

BUG= 622424 

Review-Url: https://codereview.chromium.org/2083653008
Cr-Commit-Position: refs/heads/master@{#401643}

[modify] https://crrev.com/1a57193f0add291fb6d5e6c9072a718c49db4c80/chrome/browser/android/offline_pages/recent_tab_helper.cc
[modify] https://crrev.com/1a57193f0add291fb6d5e6c9072a718c49db4c80/components/offline_pages/offline_page_model_impl.cc
[modify] https://crrev.com/1a57193f0add291fb6d5e6c9072a718c49db4c80/components/offline_pages/offline_page_model_impl_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db78ec298290c1e8d6aefdee02af036ee3647438

commit db78ec298290c1e8d6aefdee02af036ee3647438
Author: dewittj <dewittj@chromium.org>
Date: Fri Jun 24 01:00:29 2016

RecentTabHelper: Move URL checking logic into DidFinishNavigation.

We need to prevent saving certain types of pages, moving into DidFinishNavigation
prevents the SnapshotController from even starting; this is better than waiting
for the right moment detector to fire before we check that snapshots are OK for
this page.

BUG= 622424 

Review-Url: https://codereview.chromium.org/2083273004
Cr-Commit-Position: refs/heads/master@{#401766}

[modify] https://crrev.com/db78ec298290c1e8d6aefdee02af036ee3647438/chrome/browser/android/offline_pages/recent_tab_helper.cc

Owner: fgor...@chromium.org
Status: Assigned (was: Untriaged)
Assigning to self for final patch.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a82d3168ecc9779d821f17ff69e6697d38ee8da

commit 7a82d3168ecc9779d821f17ff69e6697d38ee8da
Author: fgorski <fgorski@chromium.org>
Date: Tue Jun 28 22:09:34 2016

[Offline pages] Filter out pages cached by different tabs on tab helper

* Updating a tab helper to fetch all offline pages with a given URL and filter out the ones with different Tab IDs
* Adds test for that behavior
* Refactors GetTabId to OfflinePageUtils
* Adds Delegate for getting tab id in OPTabHelper, to fix tests
* Updates Client policy for last_n to allow multiple pages for single URL (to handle multiple tabs opening the same page)

BUG= 622424 
R=dimich@chromium.org

Review-Url: https://codereview.chromium.org/2100043004
Cr-Commit-Position: refs/heads/master@{#402563}

[modify] https://crrev.com/7a82d3168ecc9779d821f17ff69e6697d38ee8da/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
[modify] https://crrev.com/7a82d3168ecc9779d821f17ff69e6697d38ee8da/chrome/browser/android/offline_pages/offline_page_tab_helper.h
[modify] https://crrev.com/7a82d3168ecc9779d821f17ff69e6697d38ee8da/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc
[modify] https://crrev.com/7a82d3168ecc9779d821f17ff69e6697d38ee8da/chrome/browser/android/offline_pages/offline_page_utils.cc
[modify] https://crrev.com/7a82d3168ecc9779d821f17ff69e6697d38ee8da/chrome/browser/android/offline_pages/offline_page_utils.h
[modify] https://crrev.com/7a82d3168ecc9779d821f17ff69e6697d38ee8da/chrome/browser/android/offline_pages/recent_tab_helper.cc
[modify] https://crrev.com/7a82d3168ecc9779d821f17ff69e6697d38ee8da/components/offline_pages/client_policy_controller.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 28 2016

Status: Fixed (was: Assigned)

Sign in to add a comment