New issue
Advanced search Search tips

Issue 622419 link

Starred by 4 users

Issue metadata

Status: Duplicate
Merged: issue 651652
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocked on:
issue 635160
issue 635164

Blocking:
issue 630357



Sign in to add a comment

Bookmark bubbles tweaks

Project Member Reported by sgabr...@chromium.org, Jun 22 2016

Issue description

I've been wanting to get to this for a while and now that we have new buttons it seems like the right time. 

I wanted to tweak the current implementation of the bookmark bubble.
biggest change are the 320 width, the cta button instead of white button and a few padding adjustments, more specifically around the selector and the button row.

It's just a nice to have, nothing critical or blocking, feel free to disregard if you don't have the bandwidth.
I just take an interest in this bubble because it's our most visible one. 

Specs are located here:
https://drive.google.com/a/google.com/file/d/0B6x6iYCtKinEdkJmU3NHZU03UHc/view?usp=sharing
 
comparison.png
206 KB View Download

Comment 1 by est...@chromium.org, Jun 30 2016

Blockedon: 571500
I'm going to mark this as blocked on the secondary UI controls design/implementation.

Comment 2 by est...@chromium.org, Jul 21 2016

Cc: bettes@chromium.org

Comment 3 by est...@chromium.org, Jul 21 2016

Blockedon: 630357
Blockedon: -630357 -571500 635160 635164
Blocking: 630357
Labels: -Pri-3 -M-54 M-55 OS-Chrome OS-Linux OS-Mac OS-Windows Pri-2
Owner: ----
Status: Available (was: Assigned)

Comment 6 by bettes@chromium.org, Aug 10 2016

For the record, Harmony is adding additional updates to this particular dialog. The image in comment #1 is not longer accurate. 

Specs
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(MD)/Secondary%20UI%20Previews%20and%20specs%20(exports)#
comparison_harmony.png
228 KB View Download
Owner: ellyjo...@chromium.org
Status: Assigned (was: Available)

Comment 8 by tapted@chromium.org, Jan 13 2017

Mergedinto: 651652
Status: Duplicate (was: Assigned)
We have two of these.  http://crbug.com/651652  has the more recent mocks so is probably the clearer one to focus on.

Sign in to add a comment