New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622410 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 611883



Sign in to add a comment

Move filters and background filters to effect nodes

Project Member Reported by ajuma@chromium.org, Jun 22 2016

Issue description

Render surfaces currently find out about their filters and background filters through their owning layer. These filters need to be moved to effect nodes as part of removing the assumption that surfaces are owned by layers.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50bce7e9fc4ade15cd23b5b529891e5add278856

commit 50bce7e9fc4ade15cd23b5b529891e5add278856
Author: ajuma <ajuma@chromium.org>
Date: Fri Jun 24 20:56:04 2016

cc: Move background filters to the effect tree

This removes background filters from LayerImpl, and adds them to the
effect tree and to LayerImplTestProperties.

BUG= 622410 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2099743002
Cr-Commit-Position: refs/heads/master@{#401965}

[modify] https://crrev.com/50bce7e9fc4ade15cd23b5b529891e5add278856/cc/layers/layer.cc
[modify] https://crrev.com/50bce7e9fc4ade15cd23b5b529891e5add278856/cc/layers/layer.h
[modify] https://crrev.com/50bce7e9fc4ade15cd23b5b529891e5add278856/cc/layers/layer_impl.cc
[modify] https://crrev.com/50bce7e9fc4ade15cd23b5b529891e5add278856/cc/layers/layer_impl.h
[modify] https://crrev.com/50bce7e9fc4ade15cd23b5b529891e5add278856/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/50bce7e9fc4ade15cd23b5b529891e5add278856/cc/layers/layer_impl_unittest.cc
[modify] https://crrev.com/50bce7e9fc4ade15cd23b5b529891e5add278856/cc/layers/layer_unittest.cc
[modify] https://crrev.com/50bce7e9fc4ade15cd23b5b529891e5add278856/cc/layers/render_surface_impl.cc
[modify] https://crrev.com/50bce7e9fc4ade15cd23b5b529891e5add278856/cc/layers/render_surface_impl.h
[modify] https://crrev.com/50bce7e9fc4ade15cd23b5b529891e5add278856/cc/proto/layer.proto
[modify] https://crrev.com/50bce7e9fc4ade15cd23b5b529891e5add278856/cc/proto/property_tree.proto
[modify] https://crrev.com/50bce7e9fc4ade15cd23b5b529891e5add278856/cc/trees/damage_tracker.cc
[modify] https://crrev.com/50bce7e9fc4ade15cd23b5b529891e5add278856/cc/trees/damage_tracker.h
[modify] https://crrev.com/50bce7e9fc4ade15cd23b5b529891e5add278856/cc/trees/damage_tracker_unittest.cc
[modify] https://crrev.com/50bce7e9fc4ade15cd23b5b529891e5add278856/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/50bce7e9fc4ade15cd23b5b529891e5add278856/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/50bce7e9fc4ade15cd23b5b529891e5add278856/cc/trees/occlusion_tracker.cc
[modify] https://crrev.com/50bce7e9fc4ade15cd23b5b529891e5add278856/cc/trees/occlusion_tracker_unittest.cc
[modify] https://crrev.com/50bce7e9fc4ade15cd23b5b529891e5add278856/cc/trees/property_tree.cc
[modify] https://crrev.com/50bce7e9fc4ade15cd23b5b529891e5add278856/cc/trees/property_tree.h
[modify] https://crrev.com/50bce7e9fc4ade15cd23b5b529891e5add278856/cc/trees/property_tree_builder.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb2b7443459c111f28e8c44050d1137d3ee44719

commit cb2b7443459c111f28e8c44050d1137d3ee44719
Author: ajuma <ajuma@chromium.org>
Date: Thu Jul 21 19:11:15 2016

cc: Move filters to the effect tree

This removes filters from LayerImpl, and adds them to the
effect tree and to LayerImplTestProperties.

BUG= 622410 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2110683004
Cr-Commit-Position: refs/heads/master@{#406927}

[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/animation/element_animations.cc
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/animation/element_animations.h
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/animation/element_animations_unittest.cc
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/layers/layer.cc
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/layers/layer.h
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/layers/layer_impl.cc
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/layers/layer_impl.h
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/layers/layer_impl_unittest.cc
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/layers/render_surface_impl.cc
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/layers/render_surface_impl.h
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/proto/property_tree.proto
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/test/animation_timelines_test_common.cc
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/test/animation_timelines_test_common.h
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/trees/damage_tracker_unittest.cc
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/trees/effect_node.cc
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/trees/effect_node.h
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/trees/layer_tree_host.h
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/trees/layer_tree_host_common.cc
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/trees/mutator_host_client.h
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/trees/occlusion_tracker.cc
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/trees/occlusion_tracker_unittest.cc
[modify] https://crrev.com/cb2b7443459c111f28e8c44050d1137d3ee44719/cc/trees/property_tree_builder.cc

Comment 3 by ajuma@chromium.org, Jul 21 2016

Status: Fixed (was: Assigned)

Sign in to add a comment