New issue
Advanced search Search tips

Issue 622397 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

media_unittests is failing on Linux ChromiumOS ASan LSan Tests (1)

Project Member Reported by dpranke@chromium.org, Jun 22 2016

Issue description

media_unittests is failing on Linux ChromiumOS ASan LSan Tests (1)

See, e.g.:

https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Builder/builds/25648

I suspect we're just missing some configuration. I will disable this temporarily and try to get a fix in ASAP.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca649f2e037e7ceed03cb2f01b5a5af981221c26

commit ca649f2e037e7ceed03cb2f01b5a5af981221c26
Author: dpranke <dpranke@chromium.org>
Date: Wed Jun 22 23:59:33 2016

Disable media_unittests on Linux ChromiumOS ASan LSan Tests (1).

Looks like this broke when flipped to GN. I expect the fix to be
straightforward, but I won't be able to get to it for a couple
hours, so disabling the test in the meantime.

TBR=dgozman@chromium.org, stevenjb@chromium.org
NOTRY=true
BUG= 622397 

Review-Url: https://codereview.chromium.org/2084163003
Cr-Commit-Position: refs/heads/master@{#401471}

[modify] https://crrev.com/ca649f2e037e7ceed03cb2f01b5a5af981221c26/testing/buildbot/chromium.memory.json

Summary: media_unittests is failing on Linux ChromiumOS ASan LSan Tests (1) (was: media_unittests is failing on Linux ChromiumOS ASan LSan Tests ()
Owner: ----
I'm not sure if we really need to fix this before M-53, but it likely isn't hard to do so, so I'm going to leave it on the radar for now.
Labels: -Pri-1 Pri-2
Labels: -M-53
not needed for M-53 ...
Blocking: -621681
Labels: -Proj-GN-Migration Proj-GN-Migration-Ship
I'm going to try tracking ship-blocking things via the label "Proj-GN-Migration-Ship" (instead of Proj-GN-Migration) as suggested w/ a conversation w/ laforge@ and the monorail folks a while ago.

Querying for "Proj=GN-Migration%" should still return bugs for both labels, and this will allow us to filter out rollup things more easily, so that we can use blocking just for things that are truly blocking other bugs.
Labels: -Proj-GN-Migration-Ship
This didn't block things from shipping (or the migration to GN as a whole), so I'm clearing the relevant label.
Project Member

Comment 9 by sheriffbot@chromium.org, Sep 25 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: dpranke@chromium.org
Owner: dalecur...@chromium.org
Status: Assigned (was: Untriaged)
Hmm, still disabled, but other media targets are building. Looks like our bot configuration systems are still the same, so I'll try reverting the CL above and see what falls out.
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0ab7128caedcdea5b1be38522987a64de9008d1

commit c0ab7128caedcdea5b1be38522987a64de9008d1
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Wed Sep 27 21:16:32 2017

Re-enable media_unittests on ChromeOS asan/lsan/msan tester.

There shouldn't be any remaining issues with these tests on ChromeOS
vs any other platforms, so attempt re-enable.

BUG= 622397 
TEST=none

Change-Id: If1fbf56b9da66fb1b2d6290999a868e1b488e73e
Reviewed-on: https://chromium-review.googlesource.com/685820
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504772}
[modify] https://crrev.com/c0ab7128caedcdea5b1be38522987a64de9008d1/testing/buildbot/chromium.memory.json

Status: Fixed (was: Assigned)
Bot is happy, so marking as fixed.

Comment 13 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 14 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment