revisit usage of LoginUIService |
|||||
Issue descriptionTommy recently landed a CL which makes the LoginUIService keep a collection of UIs instead of enforcing only one: https://codereview.chromium.org/1984863002/ It seems this code is no longer tied to sign in though. And for sync, supporting multiple UIs is fine. If this is the case, there are existing calls to this service that no longer make sense: https://cs.chromium.org/chromium/src/chrome/browser/signin/signin_global_error.cc?q=current_login_ui+-file:test&sq=package:chromium&l=93&dr=C https://cs.chromium.org/chromium/src/chrome/browser/signin/signin_error_notifier_ash.cc?q=current_login_ui+-file:test&sq=package:chromium&l=104&dr=C Both of these call site apply only to cros I believe, since desktop uses the profile menu and mobiles does not use this code at all. From looking at the code: - for signin_global_error.cc, I think the call to LoginUIService can simply be removed - for signin_error_notifier_ash.cc, I think the whole #else block can be removed, since this code no longer applies to desktop Also, should probably rename the class if it is no longer a login UI service. Opening this bug to keep track of issues.
,
Dec 19 2016
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 18 2017
+msarda since I no longer work on Identity.
,
Apr 18 2018
--Chrome Identity automated triaging-- This bug is Available and has gone one year without any activity. If another month passes without any activity, this bug will be closed out. Please provide an update with the latest status for this bug. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 11 2018
--Chrome Identity automated triaging-- This available, signin or profiles-related bug has gone at least 30 days since the last automated post without any further update. This bug will be closed out due to inactivity. Please re-open the bug and provide an update if it is still a valid or reproducible bug. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by anthonyvd@chromium.org
, Jun 22 2016