New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622393 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 820456
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

MD Settings: spellcheck dictionary download handling

Project Member Reported by michae...@chromium.org, Jun 22 2016

Issue description

Enabling a language for spell-check should begin downloading the spellcheck dictionary, if it's not already downloaded.

The old Options UI has a button to try again in case of failure, but it would be best to just keep trying automatically and not expose this to the user at all.
 
Labels: Hotlist-MD-Settings-Languages
Status: Available (was: Untriaged)
Blocking: 425627
Cc: dbeam@chromium.org
Labels: -Pri-3 Pri-2
This should block... something. Looks like we might not retry the dictionary download on failure until SpellcheckService spins up again (on restart?) Today, old Options is the only caller of SpellcheckHunspellDictionary::RetryDownloadDictionary.

Comment 3 by groby@google.com, Apr 6 2017

Cc: yyushkina@chromium.org
IIRC we shouldn't auto-retry, because there are bandwidth costs associated with that. 

+yyushinka for spellcheck PM

I wouldn't mark it as blocker unless we have evidence this actually affects a large number of users. 
Re: bandwidth costs. Would we have comparable total bandwidth requirements in the case of no failure as in the case of failure+retry (e.g. if the failure is usually that the download never initiates)? In that case auto-retrying still sounds like the better solution for the user.

Comment 5 by dbeam@chromium.org, May 3 2017

Blocking: -425627

Comment 6 by dbeam@chromium.org, May 3 2017

Cc: -tbuck...@chromium.org groby@chromium.org rouslan@chromium.org tbuck...@hromium.org

Comment 7 by dbeam@chromium.org, May 3 2017

Cc: -tbuck...@hromium.org tbuck...@chromium.org
Cc: rpop@chromium.org

Comment 9 by rpop@chromium.org, May 12 2017

Please confirm: right now when the user enables a new spellcheck language, we attempt to download the dictionary. If we fail, we retry on each chrome restart? There used to be a manual retry button but it's gone with MD.

This is not awesome (presumably the user turned on spellcheck and would like to use is now). Agree not a blocker, though would like to add auto-retry. @groby, does exponential backoff address your concerns? or are you thinking we need resumable downloading for this? (how big are dictionaries, anyway?)
Cc: aee@chromium.org
@aee: Has this been addressed now as part of  issue 820456 ?

Comment 11 by aee@chromium.org, May 9 2018

Mergedinto: 820456
Status: Duplicate (was: Available)
Yes, I'll mark this as a duplicate.

If the dictionary wasn't downloaded, the dictionary download is attempted when chrome starts. If the download fails, the UI shows an error and a retry button in the spellcheck settings to allow the user to retry the download.

Sign in to add a comment