MD Settings: spellcheck dictionary download handling |
||||||||
Issue descriptionEnabling a language for spell-check should begin downloading the spellcheck dictionary, if it's not already downloaded. The old Options UI has a button to try again in case of failure, but it would be best to just keep trying automatically and not expose this to the user at all.
,
Apr 6 2017
This should block... something. Looks like we might not retry the dictionary download on failure until SpellcheckService spins up again (on restart?) Today, old Options is the only caller of SpellcheckHunspellDictionary::RetryDownloadDictionary.
,
Apr 6 2017
IIRC we shouldn't auto-retry, because there are bandwidth costs associated with that. +yyushinka for spellcheck PM I wouldn't mark it as blocker unless we have evidence this actually affects a large number of users.
,
Apr 7 2017
Re: bandwidth costs. Would we have comparable total bandwidth requirements in the case of no failure as in the case of failure+retry (e.g. if the failure is usually that the download never initiates)? In that case auto-retrying still sounds like the better solution for the user.
,
May 3 2017
,
May 3 2017
,
May 3 2017
,
May 4 2017
,
May 12 2017
Please confirm: right now when the user enables a new spellcheck language, we attempt to download the dictionary. If we fail, we retry on each chrome restart? There used to be a manual retry button but it's gone with MD. This is not awesome (presumably the user turned on spellcheck and would like to use is now). Agree not a blocker, though would like to add auto-retry. @groby, does exponential backoff address your concerns? or are you thinking we need resumable downloading for this? (how big are dictionaries, anyway?)
,
May 9 2018
,
May 9 2018
Yes, I'll mark this as a duplicate. If the dictionary wasn't downloaded, the dictionary download is attempted when chrome starts. If the download fails, the UI shows an error and a retry button in the spellcheck settings to allow the user to retry the download. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by tbuck...@chromium.org
, Jun 22 2016Status: Available (was: Untriaged)