New issue
Advanced search Search tips

Issue 622389 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Today
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 580406



Sign in to add a comment

bluetooth: Allow or disallow read/writes from a read/write callback.

Project Member Reported by ortuno@chromium.org, Jun 22 2016

Issue description

We need to decide if we want to allow a read/write request to be issued in the callback of a read/write request:

char->ReadRemoteCharacteristic([](BluetoothRemoteGattCharacteristic char2) {
  char2->ReadRemoteCharacteristic(...);
}

Currently Mac, Android and Chrome OS allow this but Windows doesn't.

I can't see any issues with another read request being issued in the callback so I'm leaning towards allowing this? Any objections?
 

Comment 1 by r...@chromium.org, Jun 22 2016

For my own edification, what prevents us on Windows from doing this?

Comment 2 by ortuno@chromium.org, Jun 22 2016

Nothing. It's just a matter of clarifying which is the expected behavior, documenting it and implementing it across all platforms.
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 23 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by ortuno@chromium.org, Jun 26 2017

Status: Available (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cad402e3b68a9dd8259bf4d8dbe3fb3400e2fbc8

commit cad402e3b68a9dd8259bf4d8dbe3fb3400e2fbc8
Author: jdoerrie <jdoerrie@chromium.org>
Date: Wed Jan 17 13:55:17 2018

[bluetooth] Allow Nested Reads and Writes of Remote Characteristics

This change enables and tests the nesting of reading and writing remote
characteristics on Desktop and Android.

Bug:  622389 
Change-Id: I178d7c565deb1f96bcd9b534b89de456fdf996fe
Reviewed-on: https://chromium-review.googlesource.com/864146
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529728}
[modify] https://crrev.com/cad402e3b68a9dd8259bf4d8dbe3fb3400e2fbc8/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
[modify] https://crrev.com/cad402e3b68a9dd8259bf4d8dbe3fb3400e2fbc8/device/bluetooth/bluetooth_remote_gatt_characteristic_win.cc
[modify] https://crrev.com/cad402e3b68a9dd8259bf4d8dbe3fb3400e2fbc8/device/bluetooth/bluez/bluetooth_gatt_bluez_unittest.cc

Project Member

Comment 6 by sheriffbot@chromium.org, Jan 17 (6 days ago)

Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by reillyg@chromium.org, Today (10 hours ago)

Status: Fixed (was: Untriaged)
Marking Fixed after jdoerrie@'s change.

Sign in to add a comment