New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Uber bug for disabled / flaky accessibility tests

Project Member Reported by dmazz...@chromium.org, Jun 22 2016

Issue description

Combining a bunch of separate bugs for disabled or flaky accessibility tests since many of the bugs are out of date and many of the tests are higher priority than other.

 
Showing comments 8 - 107 of 107 Older
 Issue 224659  has been merged into this issue.
 Issue 542704  has been merged into this issue.
 Issue 402190  has been merged into this issue.
 Issue 473224  has been merged into this issue.
 Issue 521532  has been merged into this issue.
 Issue 594442  has been merged into this issue.
 Issue 614470  has been merged into this issue.
 Issue 609210  has been merged into this issue.
 Issue 601745  has been merged into this issue.
Cc: nyerramilli@chromium.org peconn@chromium.org
 Issue 596514  has been merged into this issue.
Cc: jam@chromium.org dcheng@chromium.org dtseng@chromium.org
 Issue 588271  has been merged into this issue.
Cc: mfomitchev@chromium.org sadrul@chromium.org tdres...@chromium.org lisayin@chromium.org
 Issue 475923  has been merged into this issue.
 Issue 461837  has been merged into this issue.
 Issue 422943  has been merged into this issue.
Project Member

Comment 22 by chromium...@appspot.gserviceaccount.com, Jun 23 2016

Detected 3 new flakes for test/step "chromevox_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxjaHJvbWV2b3hfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 23 by chromium...@appspot.gserviceaccount.com, Jun 25 2016

Detected 20 new flakes for test/step "chromevox_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxjaHJvbWV2b3hfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 24 by chromium...@appspot.gserviceaccount.com, Jun 27 2016

Detected 4 new flakes for test/step "chromevox_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxjaHJvbWV2b3hfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 25 by chromium...@appspot.gserviceaccount.com, Jun 29 2016

Detected 88 new flakes for test/step "chromevox_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxjaHJvbWV2b3hfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 26 by chromium...@appspot.gserviceaccount.com, Jul 1 2016

Detected 77 new flakes for test/step "chromevox_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxjaHJvbWV2b3hfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 27 by chromium...@appspot.gserviceaccount.com, Jul 18 2016

Detected 3 new flakes for test/step "chromevox_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxjaHJvbWV2b3hfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 28 by chromium...@appspot.gserviceaccount.com, Jul 19 2016

Detected 3 new flakes for test/step "chromevox_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxjaHJvbWV2b3hfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 29 by chromium...@appspot.gserviceaccount.com, Jul 20 2016

Detected 3 new flakes for test/step "chromevox_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxjaHJvbWV2b3hfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 30 by chromium...@appspot.gserviceaccount.com, Jul 26 2016

Detected 6 new flakes for test/step "chromevox_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxjaHJvbWV2b3hfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 31 by chromium...@appspot.gserviceaccount.com, Jul 29 2016

Detected 3 new flakes for test/step "chromevox_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxjaHJvbWV2b3hfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 32 by chromium...@appspot.gserviceaccount.com, Jul 30 2016

Detected 5 new flakes for test/step "chromevox_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxjaHJvbWV2b3hfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 33 by chromium...@appspot.gserviceaccount.com, Aug 2 2016

Detected 3 new flakes for test/step "chromevox_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxjaHJvbWV2b3hfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 34 by chromium...@appspot.gserviceaccount.com, Aug 3 2016

Detected 4 new flakes for test/step "chromevox_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxjaHJvbWV2b3hfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 35 by bugdroid1@chromium.org, Aug 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88901f962512dfb1950e5b02722b93536acc94ad

commit 88901f962512dfb1950e5b02722b93536acc94ad
Author: reillyg <reillyg@chromium.org>
Date: Mon Aug 08 20:07:07 2016

Disable flaky tests under Dr. Memory.

DumpAccessibilityTreeTest.AccessibilityIframeTransform is flaky under
Dr. Memory. It looks like we already have an Uber-bug for this issue.

* Line Expected
- ---- --------
1 rootWebArea pageLocation=(0, 0)
2 ++iframe pageLocation=(0, 0)
3 ++++rootWebArea pageLocation=(0, 0)
4 ++++++image pageLocation=(10, 10) pageSize=(200, 200)
5 ++iframe pageLocation=(0, 300)
*    6 ++++rootWebArea pageLocation=(0, 300) transform
7 ++++++image pageLocation=(20, 320) pageSize=(400, 400)
8 <-- End-of-file -->

Actual
------
rootWebArea pageLocation=(0, 0)
++iframe pageLocation=(0, 0)
++++rootWebArea pageLocation=(0, 0)
++++++image pageLocation=(10, 10) pageSize=(200, 200)
++iframe pageLocation=(0, 300)
<-- End-of-file -->

BUG=622387
TBR=thestig@chromium.org
NOTRY=True

Review-Url: https://codereview.chromium.org/2223173002
Cr-Commit-Position: refs/heads/master@{#410412}

[modify] https://crrev.com/88901f962512dfb1950e5b02722b93536acc94ad/tools/valgrind/gtest_exclude/content_browsertests.gtest-drmemory_win32.txt

Project Member

Comment 36 by bugdroid1@chromium.org, Aug 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35a95ad0a466274374555994d2e67685de4dbf95

commit 35a95ad0a466274374555994d2e67685de4dbf95
Author: johnme <johnme@chromium.org>
Date: Fri Aug 26 17:14:54 2016

Mark 4 DumpAccessibilityTreeTest tests flaky

The following tests are flaky on all platforms:
- DumpAccessibilityTreeTest.AccessibilityIframeTransform
- DumpAccessibilityTreeTest.AccessibilityIframeCoordinates
- DumpAccessibilityTreeTest.AccessibilityIframeCoordinatesCrossProcess
- DumpAccessibilityTreeTest.AccessibilityIframeTransformCrossProcess

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=DumpAccessibilityTreeTest.AccessibilityIframe

NOTREECHECKS=true
NOTRY=true
BUG=622387
TBR=dmazzoni@chromium.org

Review-Url: https://codereview.chromium.org/2282903002
Cr-Commit-Position: refs/heads/master@{#414737}

[modify] https://crrev.com/35a95ad0a466274374555994d2e67685de4dbf95/content/browser/accessibility/dump_accessibility_tree_browsertest.cc

dmazzoni wrote on https://codereview.chromium.org/2282903002/#msg6:
> > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=DumpAccessibilityTreeTest.AccessibilityIframe
> I only see two builders that account for almost all of the failures:
> Linux Texts (dbg)(1)
> CrWinAsanCov tester

Perhaps you're only looking for red "FAIL" squares, which mean the test failed despite automatic retries? The blue and light blue squares are flakes, and occur across over 20 bots. Sometimes they flake as many as 2/3 builds! For example:

- AccessibilityIframeCoordinatesCrossProcess UNKNOWN PASS in https://build.chromium.org/p/chromium.android/builders/Lollipop%20Low-end%20Tester/builds/3896/steps/content_browsertests/logs/stdio

- AccessibilityIframeTransform FAIL PASS in https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/3833/steps/content_browsertests%20on%20Windows-10-10586/logs/stdio

- AccessibilityIframeCoordinatesCrossProcess FAIL PASS in https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/45443/steps/content_browsertests%20on%20Ubuntu-12.04/logs/stdio

In each case, only a few tests actually fail, so it's not because of a bad build.

However the 4 I marked flaky in https://codereview.chromium.org/2282903002 are just the tip of the iceberg, limited to tests that are flaky on all platforms. There are many many more tests that are significantly flaky on Android and Linux but not Windows or Mac:

- DumpAccessibilityTreeTest.AccessibilityIframeTransformNested
- DumpAccessibilityTreeTest.AccessibilityIframeCrossProcess
- DumpAccessibilityTreeTest.AccessibilityIframe
- DumpAccessibilityTreeTest.AccessibilityIframeTransformNestedCrossProcess
- DumpAccessibilityTreeTest.AccessibilityIframeTransformScrolled
- DumpAccessibilityTreeTest.AccessibilityTransition
- DumpAccessibilityTreeTest.AccessibilityANoText
- DumpAccessibilityTreeTest.AccessibilityActionVerbs
- DumpAccessibilityTreeTest.AccessibilityAriaScrollbar
- DumpAccessibilityTreeTest.AccessibilityAriaTextbox
- DumpAccessibilityTreeTest.AccessibilityCSSColor
- DumpAccessibilityTreeTest.AccessibilityCSSFontStyle
- DumpAccessibilityTreeTest.AccessibilityCSSLanguage
- DumpAccessibilityTreeTest.AccessibilityFrameset
- DumpAccessibilityTreeTest.AccessibilityImgEmptyAlt
- DumpAccessibilityTreeTest.AccessibilityP
- DumpAccessibilityTreeTest.AccessibilityS
- DumpAccessibilityTreeTest.AccessibilityButtonNameCalc
- DumpAccessibilityTreeTest.AccessibilityInputMonth
- DumpAccessibilityTreeTest.AccessibilityInputRadio
- DumpAccessibilityTreeTest.AccessibilityInputReset
- DumpAccessibilityTreeTest.AccessibilityInputSearch
- DumpAccessibilityTreeTest.AccessibilityInputSubmit
- DumpAccessibilityTreeTest.AccessibilityMeta
- DumpAccessibilityTreeTest.AccessibilityMeter
- DumpAccessibilityTreeTest.AccessibilityModalDialogOpened
- DumpAccessibilityTreeTest.AccessibilityNoscript
- DumpAccessibilityTreeTest.AccessibilityObject
- DumpAccessibilityTreeTest.AccessibilityOl
- DumpAccessibilityTreeTest.AccessibilityOptionindatalist
- DumpAccessibilityTreeTest.AccessibilityParam
- DumpAccessibilityTreeTest.AccessibilitySamp
- DumpAccessibilityTreeTest.AccessibilityScript
- DumpAccessibilityTreeTest.AccessibilitySmall
- DumpAccessibilityTreeTest.AccessibilitySource
- DumpAccessibilityTreeTest.AccessibilitySpan
- DumpAccessibilityTreeTest.AccessibilityStrong
- DumpAccessibilityTreeTest.AccessibilitySub
- DumpAccessibilityTreeTest.AccessibilitySummary
- DumpAccessibilityTreeTest.AccessibilityTableTbodyTfoot
- DumpAccessibilityTreeTest.AccessibilityTableSimple
- DumpAccessibilityTreeTest.AccessibilityTableSpans
- DumpAccessibilityTreeTest.AccessibilityTextareaWithSelection
- DumpAccessibilityTreeTest.AccessibilityTime
- DumpAccessibilityTreeTest.AccessibilityTitle
- DumpAccessibilityTreeTest.AccessibilityDl
- DumpAccessibilityTreeTest.AccessibilityArea
- DumpAccessibilityTreeTest.AccessibilityAriaLabelledByHeading
- DumpAccessibilityTreeTest.AccessibilityAriaLiveWithContent
- DumpAccessibilityTreeTest.AccessibilityA
- DumpAccessibilityTreeTest.AccessibilityAOnclick
- DumpAccessibilityTreeTest.AccessibilityAriaAtomic
- DumpAccessibilityTreeTest.AccessibilityAriaAutocomplete
- DumpAccessibilityTreeTest.AccessibilityAriaCheckBox
- DumpAccessibilityTreeTest.AccessibilityAriaControls
- DumpAccessibilityTreeTest.AccessibilityAriaCurrent
- DumpAccessibilityTreeTest.AccessibilityAriaDescribedBy
- DumpAccessibilityTreeTest.AccessibilityAriaDirectory
- DumpAccessibilityTreeTest.AccessibilityAriaDropEffect
- DumpAccessibilityTreeTest.AccessibilityAriaExpanded
- DumpAccessibilityTreeTest.AccessibilityAriaGroup
- DumpAccessibilityTreeTest.AccessibilityAriaHasPopup
- DumpAccessibilityTreeTest.AccessibilityAriaListBoxActiveDescendant
- DumpAccessibilityTreeTest.AccessibilityAriaListBoxAriaSelected
- DumpAccessibilityTreeTest.AccessibilityAriaMarquee
- DumpAccessibilityTreeTest.AccessibilityAriaMultiline
- DumpAccessibilityTreeTest.AccessibilityAriaNavigation
- DumpAccessibilityTreeTest.AccessibilityAriaOwns
- DumpAccessibilityTreeTest.AccessibilityAriaRequired
- DumpAccessibilityTreeTest.AccessibilityAriaRow
- DumpAccessibilityTreeTest.AccessibilityAriaSearch
- DumpAccessibilityTreeTest.AccessibilityAriaSelected
- DumpAccessibilityTreeTest.AccessibilityAriaSetsize
- DumpAccessibilityTreeTest.AccessibilityAriaStatus
- DumpAccessibilityTreeTest.AccessibilityAriaTooltip
- DumpAccessibilityTreeTest.AccessibilityAriaTree
- DumpAccessibilityTreeTest.AccessibilityAudio
- DumpAccessibilityTreeTest.AccessibilityB
- DumpAccessibilityTreeTest.AccessibilityButton
- DumpAccessibilityTreeTest.AccessibilityCheckboxNameCalc
- DumpAccessibilityTreeTest.AccessibilityCite
- DumpAccessibilityTreeTest.AccessibilityDt
- DumpAccessibilityTreeTest.AccessibilityFigure
- DumpAccessibilityTreeTest.AccessibilityFooter

And that's just from picking out the most flaky from http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=DumpAccessibilityTreeTest
(warning, that page takes a long time to load)

The rest of the tests seem to occasionally flake as well, just not quite so much :-(
There's likely a common root cause to all of this, and I recommend investigating.
Got it, thanks.

When I look at the light blue squares I see real flakes on Linux. It's the same as  crbug.com/559192  and I've seen it before, no idea what's causing it.

I see a different real flake happening on Windows occasionally. Looks like a totally different root cause.

Can you find any real examples of flakes on Android? I clicked on a few that are colored light blue and I'm just seeing "UNKNOWN PASS" and no logs that show that particular test actually failing. Looks like something unrelated.

Project Member

Comment 39 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fadb58864d3a99cd09b89d31994d4286f4cb60d2

commit fadb58864d3a99cd09b89d31994d4286f4cb60d2
Author: dmazzoni <dmazzoni@chromium.org>
Date: Thu Sep 01 22:56:57 2016

Fix flakiness in DumpAccessibilityTree tests with iframes

I found three sources of flakiness in DumpAccessibilityTree tests with iframes:
1. Enabled a check that all frames have loaded before dumping the accessibility
   tree. Previously it was only possible to do that check on out-of-process
   iframes, but now that  bug 532249  is fixed we can do that check on all
   iframes.
2. Removed code to check if each frame's surface is ready. It's no longer
   necessary now that  bug 618120  is fixed, and it was causing flakiness.
3. The scroll max for the main page is sometimes flaky because it changes
   asynchronously after the page loads. Modified the tests to not dump
   scroll mins and maxes.

Re-enables several disabled tests. We may be able to enable a few more in
a follow-up.

BUG=622387

Review-Url: https://codereview.chromium.org/2289293004
Cr-Commit-Position: refs/heads/master@{#416103}

[modify] https://crrev.com/fadb58864d3a99cd09b89d31994d4286f4cb60d2/content/browser/accessibility/dump_accessibility_browsertest_base.cc
[modify] https://crrev.com/fadb58864d3a99cd09b89d31994d4286f4cb60d2/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://crrev.com/fadb58864d3a99cd09b89d31994d4286f4cb60d2/content/test/data/accessibility/html/iframe-coordinates-cross-process-expected-blink.txt
[modify] https://crrev.com/fadb58864d3a99cd09b89d31994d4286f4cb60d2/content/test/data/accessibility/html/iframe-coordinates-cross-process.html
[modify] https://crrev.com/fadb58864d3a99cd09b89d31994d4286f4cb60d2/content/test/data/accessibility/html/iframe-coordinates-expected-blink.txt
[modify] https://crrev.com/fadb58864d3a99cd09b89d31994d4286f4cb60d2/content/test/data/accessibility/html/iframe-coordinates.html
[modify] https://crrev.com/fadb58864d3a99cd09b89d31994d4286f4cb60d2/content/test/data/accessibility/html/iframe-transform-scrolled-expected-blink.txt
[modify] https://crrev.com/fadb58864d3a99cd09b89d31994d4286f4cb60d2/content/test/data/accessibility/html/iframe-transform-scrolled.html

 Issue 643902  has been merged into this issue.
Cc: pdr@chromium.org wjmaclean@chromium.org
 Issue 648825  has been merged into this issue.
Cc: weiliangc@chromium.org glevin@chromium.org jaydasika@chromium.org ajuma@chromium.org enne@chromium.org aboxhall@chromium.org
 Issue 635032  has been merged into this issue.
Labels: NewComponent-Accessibility-Internals NewComponent-Accessibility
Components: Internals>Accessibility
Components: -UI>Accessibility
Labels: -newcomponent-accessibility-internals -newcomponent-accessibility
Blockedon: 719030
 Issue 736840  has been merged into this issue.
 Issue 724923  has been merged into this issue.
 Issue 430622  has been merged into this issue.
Labels: triage-dominic-internals
Labels: -triage-dominic-internals
Cc: lpalmaro@chromium.org
 Issue 370168  has been merged into this issue.
 Issue 346797  has been merged into this issue.
Cc: nek...@chromium.org ellyjo...@chromium.org
 Issue 616768  has been merged into this issue.

Comment 56 by dougt@chromium.org, Aug 11 2017

 Issue 617146  has been merged into this issue.

Comment 57 by dougt@chromium.org, Aug 11 2017

Cc: jonr...@chromium.org hcarmona@chromium.org kathrelk...@chromium.org
 Issue 458567  has been merged into this issue.

Comment 58 by dougt@chromium.org, Aug 11 2017

 Issue 500070  has been merged into this issue.
Cc: shreera...@samsung.com
 Issue 445929  has been merged into this issue.
Cc: jbudorick@chromium.org
 Issue 550562  has been merged into this issue.
Cc: ctguil@chromium.org
 Issue 145537  has been merged into this issue.
 Issue 102868  has been merged into this issue.
 Issue 738497  has been merged into this issue.
Cc: plundblad@chromium.org
 Issue 498881  has been merged into this issue.
 Issue 708759  has been merged into this issue.
Cc: -mfomitchev@chromium.org
 Issue 791268  has been merged into this issue.
Project Member

Comment 68 by Findit, Dec 4 2017

Labels: Test-Findit-Analyzed
Findit identified the culprit r521109 with confidence 93.4% in the config "tryserver.chromium.win / win7_chromium_rel_ng"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKPAWNocm9taXVtLndpbi9XaW43IFRlc3RzICgxKS83NDExNy9jb250ZW50X2Jyb3dzZXJ0ZXN0cy9SSFZ0Y0VGalkyVnpjMmxpYVd4cGRIbEZkbVZ1ZEhOVVpYTjBMa0ZqWTJWemMybGlhV3hwZEhsRmRtVnVkSE5CY21saFEyOXRZbTlDYjNoR2IyTjFjdz09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Flake Analyzer is in alpha version.
Feedback is welcome using component Tools>Test>FindIt>Flakiness !
Project Member

Comment 69 by chromium...@appspot.gserviceaccount.com, Dec 16 2017

Detected 3 new flakes for test/step "chromevox_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxjaHJvbWV2b3hfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 70 by chromium...@appspot.gserviceaccount.com, Dec 18 2017

Detected 3 new flakes for test/step "chromevox_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxjaHJvbWV2b3hfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.
Cc: -robliao@chromium.org
Components: Tests>Disabled
Labels: Test-Disabled
Project Member

Comment 74 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a380ef0f211448bc24e1834bdc86de76bcec38c

commit 0a380ef0f211448bc24e1834bdc86de76bcec38c
Author: Chris Pickel <sfiera@chromium.org>
Date: Tue Feb 06 10:32:36 2018

Regularize automation_apitest.cc flakiness TODOs

Bugs reassigned:
* https://crbug.com/807128: recently filed, dupe to 622387?
*  https://crbug.com/637525 : was duped to 754870
*  https://crbug.com/615908 : was duped to 754870
*  https://crbug.com/724923 : was duped to 622387
* https://crbug.com/808343: recently filed, dupe to 622387?
*  https://crbug.com/435449 : marked as “fixed” but still disabled. Dupe
                            to 754870?
*  https://crbug.com/725420 : was fixed and test re-enabled! \o/ Remove
                            the TODO.

Bug: 622387, 754870
Change-Id: I4fb525e09a5c50aa521697b187baac310eade7a9
Reviewed-on: https://chromium-review.googlesource.com/901265
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Chris Pickel <sfiera@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534673}
[modify] https://crrev.com/0a380ef0f211448bc24e1834bdc86de76bcec38c/chrome/browser/extensions/api/automation/automation_apitest.cc

Cc: gov...@chromium.org
Just to update:

Similar flaky issue observed on mac64 Build #2633 with #65.0.3325.53.

Link to the Builder:
--------------------
https://uberchromegw.corp.google.com/i/official.desktop/builders/mac64/builds/2633

Link to the log file :
--------------------
https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop%2Fmac64%2F2633%2F%2B%2Frecipes%2Fsteps%2FUpload_to_test-results__content_browsertests_%2F0%2Fstdout

Note:
No issue observed on 64.0.3282.155, 65.0.3325.57,66.0.3341.0 & 66.0.3342.0. Updating this issue for tracking purpose.

Thanks..!
Just to update:

Similar flaky issue observed on mac64 Build #2659 with #66.0.3347.0.

Link to the Builder:
--------------------
https://uberchromegw.corp.google.com/i/official.desktop/builders/mac64/builds/2659

Link to the log file :
--------------------
https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop%2Fmac64%2F2659%2F%2B%2Frecipes%2Fsteps%2Fcontent_browsertests%2F0%2Fstdout

Updating this issue for tracking purpose.

Thanks..!
Project Member

Comment 79 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fac11f6b1dfcaeb2e89bf8599f4c3a17bd326a1

commit 6fac11f6b1dfcaeb2e89bf8599f4c3a17bd326a1
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Thu Mar 01 07:23:09 2018

Re-enable DumpAccessibilityTreeTest.AccessibilityAriaValueMin and Max

Bug: 622387
Change-Id: I68252a1dbfa88eae8e5c4c7801dcbf9cf8f507fe
Tbr: aboxhall@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/938159
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540088}
[modify] https://crrev.com/6fac11f6b1dfcaeb2e89bf8599f4c3a17bd326a1/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://crrev.com/6fac11f6b1dfcaeb2e89bf8599f4c3a17bd326a1/content/test/data/accessibility/aria/aria-valuemax-expected-android.txt
[modify] https://crrev.com/6fac11f6b1dfcaeb2e89bf8599f4c3a17bd326a1/content/test/data/accessibility/aria/aria-valuemax-expected-mac.txt
[modify] https://crrev.com/6fac11f6b1dfcaeb2e89bf8599f4c3a17bd326a1/content/test/data/accessibility/aria/aria-valuemax-expected-win.txt
[modify] https://crrev.com/6fac11f6b1dfcaeb2e89bf8599f4c3a17bd326a1/content/test/data/accessibility/aria/aria-valuemin-expected-android.txt
[modify] https://crrev.com/6fac11f6b1dfcaeb2e89bf8599f4c3a17bd326a1/content/test/data/accessibility/aria/aria-valuemin-expected-mac.txt
[modify] https://crrev.com/6fac11f6b1dfcaeb2e89bf8599f4c3a17bd326a1/content/test/data/accessibility/aria/aria-valuemin-expected-win.txt

Project Member

Comment 80 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c1a16509753dfce11564e5c37ffe8a134a2b3dc

commit 2c1a16509753dfce11564e5c37ffe8a134a2b3dc
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Thu Mar 01 07:54:24 2018

Fix flakiness in AutomationApiTest.DesktopHitTestIframe

At least one issue was that the loadComplete event was sometimes being
received on a frame with an empty url.

Bug: 808343,622387
Change-Id: I7040a75c91f409ba07d3b9ad4e4598805e94b6ce
Reviewed-on: https://chromium-review.googlesource.com/938495
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540097}
[modify] https://crrev.com/2c1a16509753dfce11564e5c37ffe8a134a2b3dc/chrome/browser/extensions/api/automation/automation_apitest.cc
[modify] https://crrev.com/2c1a16509753dfce11564e5c37ffe8a134a2b3dc/chrome/test/data/extensions/api_test/automation/tests/desktop/focus_iframe.js
[modify] https://crrev.com/2c1a16509753dfce11564e5c37ffe8a134a2b3dc/chrome/test/data/extensions/api_test/automation/tests/desktop/hit_test_iframe.js

Project Member

Comment 81 by chromium...@appspot.gserviceaccount.com, Mar 1 2018

Labels: Sheriff-Chromium
Detected 8 new flakes for test/step "AutomationApiTest.DesktopFocusIframe". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLwsSBUZsYWtlIiRBdXRvbWF0aW9uQXBpVGVzdC5EZXNrdG9wRm9jdXNJZnJhbWUM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 82 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45d0a37bf6cc9b4944aa4710e241c0a81189f2b2

commit 45d0a37bf6cc9b4944aa4710e241c0a81189f2b2
Author: Karan Bhatia <karandeepb@chromium.org>
Date: Fri Mar 02 00:03:47 2018

Revert "Fix flakiness in AutomationApiTest.DesktopHitTestIframe"

This reverts commit 2c1a16509753dfce11564e5c37ffe8a134a2b3dc.

Reason for revert: This is still flaking.

Original change's description:
> Fix flakiness in AutomationApiTest.DesktopHitTestIframe
> 
> At least one issue was that the loadComplete event was sometimes being
> received on a frame with an empty url.
> 
> Bug: 808343,622387
> Change-Id: I7040a75c91f409ba07d3b9ad4e4598805e94b6ce
> Reviewed-on: https://chromium-review.googlesource.com/938495
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540097}

TBR=dmazzoni@chromium.org,dtseng@chromium.org

Change-Id: If3a4f36c64d2a2d2be04d7d520082344edcc1290
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 808343, 622387
Reviewed-on: https://chromium-review.googlesource.com/944768
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540356}
[modify] https://crrev.com/45d0a37bf6cc9b4944aa4710e241c0a81189f2b2/chrome/browser/extensions/api/automation/automation_apitest.cc
[modify] https://crrev.com/45d0a37bf6cc9b4944aa4710e241c0a81189f2b2/chrome/test/data/extensions/api_test/automation/tests/desktop/focus_iframe.js
[modify] https://crrev.com/45d0a37bf6cc9b4944aa4710e241c0a81189f2b2/chrome/test/data/extensions/api_test/automation/tests/desktop/hit_test_iframe.js

Project Member

Comment 83 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f49fd700572b4cbe73b76cdb85b2700b34bf782

commit 7f49fd700572b4cbe73b76cdb85b2700b34bf782
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Mon Mar 05 20:36:41 2018

Make DumpAccessibilityEvent tests more robust.

1. Sort the event dump alphabetically, since there are some
   nondeterministic, arbitrary things that can affect the
   event order.
2. Explicitly filter out events that don't come from the web,
   using the window class and supported QueryService interfaces
   as the clue.
3. Filter out focus events on the document by default.
   We don't have any tests that need this anyway,

Make other tiny cleanups at the same time.

Bug: 622387
Change-Id: Ic5c3ea30bf2a78df43d924249949344d93acc320
Reviewed-on: https://chromium-review.googlesource.com/947039
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540920}
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/browser/accessibility/accessibility_event_recorder.h
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/browser/accessibility/accessibility_event_recorder_win.cc
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/browser/accessibility/browser_accessibility_com_win.h
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/browser/accessibility/dump_accessibility_browsertest_base.cc
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/browser/accessibility/dump_accessibility_browsertest_base.h
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/browser/accessibility/dump_accessibility_events_browsertest.cc
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/add-alert-expected-mac.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/add-alert-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/add-child-of-body-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/add-hidden-attribute-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/add-hidden-attribute-subtree-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/add-subtree-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/aria-combo-box-collapse-expected-mac.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/aria-combo-box-collapse-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/aria-combo-box-expand-expected-mac.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/aria-combo-box-expand-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/aria-combo-box-next-expected-mac.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/aria-combo-box-next-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/aria-slider-value-both-change-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/aria-slider-value-change-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/aria-slider-valuetext-change-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/aria-spinbutton-value-both-change-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/aria-spinbutton-value-change-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/aria-spinbutton-valuetext-change-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/aria-tree-collapse-expected-mac.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/checked-state-changed-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/css-display-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/css-visibility-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/description-change-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/description-change-indirect-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/expanded-change-expected-mac.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/inner-html-change-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/input-type-text-value-changed-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/listbox-focus-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/listbox-next-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/live-region-add-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/live-region-change-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/live-region-create-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/live-region-ignores-click-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/menulist-collapse-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/name-change-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/name-change-indirect-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/remove-child-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/remove-hidden-attribute-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/remove-hidden-attribute-subtree-expected-win.txt
[modify] https://crrev.com/7f49fd700572b4cbe73b76cdb85b2700b34bf782/content/test/data/accessibility/event/text-changed-expected-win.txt

Labels: -Sheriff-Chromium
Labels: OS-Mac
Just to update:

DumpAccessibilityTreeTest.AccessibilityAriaValueMin

Seeing flaky issue on Mac 64 trunk build on official desktop continuous.

Link to the builder:
-------------------
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac64%20trunk/builds/11736

Link to error log:
----------------
https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop.continuous%2Fmac64_trunk%2F11736%2F%2B%2Frecipes%2Fsteps%2FUpload_to_test-results__browser_tests_%2F0%2Fstdout

Thanks..!
Cc: shend@chromium.org patricia...@chromium.org
 Issue 825429  has been merged into this issue.
Cc: linds...@chromium.org
 Issue 805998  has been merged into this issue.

Just to update:

Seeing flaky issue on Mac 64 trunk build on official desktop.

DumpAccessibilityTreeTest.AccessibilityAriaCombobox
DumpAccessibilityTreeTest.AccessibilityCheckboxNameCalc

Link to the builder:
------------------
https://uberchromegw.corp.google.com/i/official.desktop/builders/mac64

Error log:
---------
https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop%2Fmac64%2F2929%2F%2B%2Frecipes%2Fsteps%2Fcontent_browsertests%2F0%2Fstdout

Thanks..!


Just to update:

Seeing flaky issue on Mac 64-67.0.3396.41 build on official desktop builder.

DumpAccessibilityTreeTest.AccessibilityAriaCombobox
DumpAccessibilityTreeTest.AccessibilityCheckboxNameCalc

Link to the builder:
------------------
https://uberchromegw.corp.google.com/i/official.desktop/builders/mac64

Error log:
----------
https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop%2Fmac64%2F2936%2F%2B%2Frecipes%2Fsteps%2Fcontent_browsertests%2F0%2Fstdout

dmazzoni@, Please take a look into this issue.
Thanks..!
 Issue 693928  has been merged into this issue.
Cc: michaschwab@google.com
 Issue 872131  has been merged into this issue.
Project Member

Comment 93 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e34c4d59cabc333defc0e25775faf43261ba6a53

commit e34c4d59cabc333defc0e25775faf43261ba6a53
Author: Jennifer Apacible <apacible@chromium.org>
Date: Fri Aug 17 18:28:09 2018

Disable flaky test.

NOTRY=true (disabling tests)

Bug:  875137 , 622387
TBR: dtseng@chromium.org
Change-Id: I625e4bcf454fb7dcdf67e83cfbe2ac643d9d8c7e
Reviewed-on: https://chromium-review.googlesource.com/1179974
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584132}
[modify] https://crrev.com/e34c4d59cabc333defc0e25775faf43261ba6a53/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs

Blockedon: 901725
Cc: danakj@chromium.org
 Issue 910997  has been merged into this issue.
 Issue 910921  has been merged into this issue.
Project Member

Comment 97 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ae291d41792e0084797999bb4aba2817b080f85

commit 4ae291d41792e0084797999bb4aba2817b080f85
Author: danakj <danakj@chromium.org>
Date: Tue Dec 04 19:55:13 2018

Disable flaky ChromeVox tests.

These started flaking due to changing timing in the renderer process
during navigation/startup/shutdown.

TBR=dmazzoni@chromium.org

Change-Id: Ic61c7058666612d68b49b8a7f311a957e5bbd647
Bug: 622387
Reviewed-on: https://chromium-review.googlesource.com/c/1361585
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613661}
[modify] https://crrev.com/4ae291d41792e0084797999bb4aba2817b080f85/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher_test.unitjs

Blockedon: 912390
 Issue 912772  has been merged into this issue.
Project Member

Comment 102 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f326f2b3fdb13584493bb594ad07da5f85c02c23

commit f326f2b3fdb13584493bb594ad07da5f85c02c23
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Tue Dec 11 11:53:42 2018

[ChromeOS][Flaky] Disable three flaky ChromeVox tests

This CL disabled these flaky tests:
TextFocusFeedback
DoubleFocusAlertDialogFeedback
ToggleOnKeyUp

They have caused failures recently and show a history of flakiness:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ChromeVoxEventWatcherUnitTest

TBR=dmazzoni@chromium.org

Bug: 912390, 622387
Change-Id: If7647be13420ff98df3a51d0fa156635f181c074
Reviewed-on: https://chromium-review.googlesource.com/c/1371476
Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org>
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615495}
[modify] https://crrev.com/f326f2b3fdb13584493bb594ad07da5f85c02c23/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher_test.unitjs

Project Member

Comment 103 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a164e645314a667c915ec6daefc7de162a6a6a08

commit a164e645314a667c915ec6daefc7de162a6a6a08
Author: David Tseng <dtseng@chromium.org>
Date: Wed Dec 12 18:13:53 2018

Speculative fixes for flakey ChromeVox tests using waitForCalm

Bug: 622387
Change-Id: Idddd32bf271f28fb5d22cbef54b4250e636e2f6f
Reviewed-on: https://chromium-review.googlesource.com/c/1372312
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615963}
[modify] https://crrev.com/a164e645314a667c915ec6daefc7de162a6a6a08/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js
[modify] https://crrev.com/a164e645314a667c915ec6daefc7de162a6a6a08/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher_test.unitjs

Project Member

Comment 104 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecdbbab7908cd7ca9ae565eaae172527721c51d6

commit ecdbbab7908cd7ca9ae565eaae172527721c51d6
Author: David Tseng <dtseng@chromium.org>
Date: Thu Dec 13 17:53:30 2018

Revert "Speculative fixes for flakey ChromeVox tests using waitForCalm"

This reverts commit a164e645314a667c915ec6daefc7de162a6a6a08.

Reason for revert: <INSERT REASONING HERE>
Still flakes.
Original change's description:
> Speculative fixes for flakey ChromeVox tests using waitForCalm
> 
> Bug: 622387
> Change-Id: Idddd32bf271f28fb5d22cbef54b4250e636e2f6f
> Reviewed-on: https://chromium-review.googlesource.com/c/1372312
> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615963}

TBR=dmazzoni@chromium.org,dtseng@chromium.org

Change-Id: I676dbeca80230947b717b2713413dfb7800c4401
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 622387
Reviewed-on: https://chromium-review.googlesource.com/c/1376106
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616359}
[modify] https://crrev.com/ecdbbab7908cd7ca9ae565eaae172527721c51d6/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js
[modify] https://crrev.com/ecdbbab7908cd7ca9ae565eaae172527721c51d6/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher_test.unitjs

Project Member

Comment 105 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfd9b97d2bdde621e3dd023f0f1d2eadbedbd820

commit bfd9b97d2bdde621e3dd023f0f1d2eadbedbd820
Author: danakj <danakj@chromium.org>
Date: Fri Dec 14 20:46:28 2018

Disable flaky ChromeVoxEventWatcherUnitTest.AlertDialogFeedback

TBR=dmazzoni@chromium.org

Change-Id: Ie500171f0d0ff5af315e8c9bd36c82da8c58c503
Bug: 622387,  914455 
Reviewed-on: https://chromium-review.googlesource.com/c/1378667
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616813}
[modify] https://crrev.com/bfd9b97d2bdde621e3dd023f0f1d2eadbedbd820/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher_test.unitjs

 Issue 914455  has been merged into this issue.
Project Member

Comment 107 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/389dba4bfaecb556a214d127f9917b2c15fbec22

commit 389dba4bfaecb556a214d127f9917b2c15fbec22
Author: Max Morin <maxmorin@chromium.org>
Date: Fri Jan 04 12:15:56 2019

Disable flaky ChromeVoxEventWatcherUnitTest.AriaHiddenFeedback

Bug: 622387, 919033
Tbr: dtseng
Change-Id: I03834f051d3368d2a6f497e918d20bb3e630301e
Reviewed-on: https://chromium-review.googlesource.com/c/1396141
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619919}
[modify] https://crrev.com/389dba4bfaecb556a214d127f9917b2c15fbec22/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher_test.unitjs

Showing comments 8 - 107 of 107 Older

Sign in to add a comment