New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622386 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Create build configs with GE template

Project Member Reported by nxia@chromium.org, Jun 22 2016

Issue description

Change the build configuration system: users should be able to define build configs through GE; Chromeos/Chromite pulls the changes/templates from GE buckets and reflects build configs changes.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 30 2016

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f5b64fd0770bbe8353860d33530238d8bb8a42f3

commit f5b64fd0770bbe8353860d33530238d8bb8a42f3
Author: Ningning Xia <nxia@chromium.org>
Date: Wed Jun 22 17:25:50 2016

Build overwritten_configs and overwrite release builders.

Introduce overwrite config logic and apply overwriting on release
builders.

BUG= chromium:622386 
TEST=run_tests; manually dump configs

Change-Id: I856b54621fe51dea3b76ad7c173526a24310afc8
Reviewed-on: https://chromium-review.googlesource.com/354766
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/f5b64fd0770bbe8353860d33530238d8bb8a42f3/cbuildbot/config_dump.json
[modify] https://crrev.com/f5b64fd0770bbe8353860d33530238d8bb8a42f3/cbuildbot/chromeos_config.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f0ee8e56e94fae8ec6a43d7afb6442cd94ffb9a2

commit f0ee8e56e94fae8ec6a43d7afb6442cd94ffb9a2
Author: Ningning Xia <nxia@chromium.org>
Date: Fri Jul 01 23:39:54 2016

Generate configs based on ge_build_config.json

Adjusted and added ge_build_config.json.
Generated and dumped build configs based on ge_build_config.json.

BUG= chromium:622386 
TEST=Manually dump configs.

Change-Id: Ie4b43f3f55aca9138f086a66f169423fa99db6aa
Reviewed-on: https://chromium-review.googlesource.com/358356
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[add] https://crrev.com/f0ee8e56e94fae8ec6a43d7afb6442cd94ffb9a2/cbuildbot/ge_build_config.json
[modify] https://crrev.com/f0ee8e56e94fae8ec6a43d7afb6442cd94ffb9a2/cbuildbot/constants.py
[modify] https://crrev.com/f0ee8e56e94fae8ec6a43d7afb6442cd94ffb9a2/cbuildbot/config_lib.py
[modify] https://crrev.com/f0ee8e56e94fae8ec6a43d7afb6442cd94ffb9a2/cbuildbot/chromeos_config.py

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/cacd9860d68f376a3072f93b7853b0ace7aaeab6

commit cacd9860d68f376a3072f93b7853b0ace7aaeab6
Author: Ningning Xia <nxia@chromium.org>
Date: Thu Jun 30 01:36:30 2016

Add config-updater builder.

Add config_stages (CheckTemplateStage and UpdateConfigStage) for
config-updater builder. Implement the logic to check, verify and submit
GE config changes to corresponding branches. Submit/push logic is
disabled for now, will enable the submit/push logic in the following CLs.

BUG= chromium:622386 
TEST=unit_test;cbuildbot_run
CQ-DEPEND=358356

Change-Id: I702372d513d4c82c8a999a121151b19f551e3933
Reviewed-on: https://chromium-review.googlesource.com/357740
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/cacd9860d68f376a3072f93b7853b0ace7aaeab6/cbuildbot/chromeos_config.py
[add] https://crrev.com/cacd9860d68f376a3072f93b7853b0ace7aaeab6/cbuildbot/stages/config_stages_unittest.py
[add] https://crrev.com/cacd9860d68f376a3072f93b7853b0ace7aaeab6/cbuildbot/builders/config_builders.py
[modify] https://crrev.com/cacd9860d68f376a3072f93b7853b0ace7aaeab6/cbuildbot/config_dump.json
[modify] https://crrev.com/cacd9860d68f376a3072f93b7853b0ace7aaeab6/cbuildbot/repository.py
[add] https://crrev.com/cacd9860d68f376a3072f93b7853b0ace7aaeab6/cbuildbot/stages/config_stages.py
[add] https://crrev.com/cacd9860d68f376a3072f93b7853b0ace7aaeab6/cbuildbot/stages/config_stages_unittest
[modify] https://crrev.com/cacd9860d68f376a3072f93b7853b0ace7aaeab6/lib/git.py

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/33440b1fc74c2438a26367e8b9d3b484b7c0082f

commit 33440b1fc74c2438a26367e8b9d3b484b7c0082f
Author: Ningning Xia <nxia@chromium.org>
Date: Mon Jul 18 06:11:16 2016

Enable config-updater PushCommits method.

Enable config-updater for master branch and release branches with
milestone_num > 53.

BUG= chromium:622386 
TEST=unit_test

Change-Id: Ic5272c52d20e92d6589e466010481272322850b1
Reviewed-on: https://chromium-review.googlesource.com/361223
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Chris Sosa <sosa@chromium.org>

[modify] https://crrev.com/33440b1fc74c2438a26367e8b9d3b484b7c0082f/cbuildbot/stages/config_stages_unittest.py
[modify] https://crrev.com/33440b1fc74c2438a26367e8b9d3b484b7c0082f/cbuildbot/stages/config_stages.py

Comment 6 by nxia@chromium.org, Dec 14 2016

Status: Fixed (was: Untriaged)

Sign in to add a comment