New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622378 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

Navigation from omnibox doesn't carry user gesture false.

Project Member Reported by qin...@chromium.org, Jun 22 2016

Issue description

When user type some url from the omnibox, the navigation is not associated with a user gesture.

For example, copy/pasting a pdf url into the omnibox will not launch the pdfviewer after the pdf is downloaded, since the usergesture flag is false.
But clicking a link to a pdf will launch pdfviewer
 
I think the concept of user gesture is content-specific and just piped to the UI from the renderer. We should probably just use an additional trigger for whether to open pdfviewer by looking at whether the URL transition is TYPED (which means it came from the omnibox).
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a06924c6c0170d0007966d0d86a3070a6ca0e717

commit a06924c6c0170d0007966d0d86a3070a6ca0e717
Author: qinmin <qinmin@chromium.org>
Date: Thu Jun 23 19:08:32 2016

Fix an issue that pdf is not auto-opened after typing url in omnibox

If a pdf download is triggered from omnibox, we don't auto-open the
file.
This is because the download item doesn't carry the user gesture flag.
However, in most cases the url is typed or the navigation is triggerd by
user.
This CL fixes the issue by identifying these downloads that are initiated
by user.

BUG= 622378 

Review-Url: https://codereview.chromium.org/2090853002
Cr-Commit-Position: refs/heads/master@{#401672}

[modify] https://crrev.com/a06924c6c0170d0007966d0d86a3070a6ca0e717/chrome/browser/android/download/download_controller.cc

Comment 3 by qin...@chromium.org, Jun 23 2016

Status: Fixed (was: Unconfirmed)

Sign in to add a comment