The first time I think we saw this was actually here, on Monday:

https://build.chromium.org/p/chromiumos.chromium/builders/x86-generic-tot-asan-informational/builds/10980

+sky@ for visitedlink

+xhwang@ for "Move permission.mojom from WebKit/public/platform/ to components/"

The dependency chain for this is a bit tangled, but I suspect that visitedlink_common needs to depend on blink.gyp:blink (or at least blink.gyp:mojo_bindings).

It looks like for the permission_status.mojom.h, at a minimum, we need to declare dependency on WebKit/public:mojo_bindings.

re:#2 I believe we're already using the GN workflow now

sky@ please comment if we should add "//third_party/WebKit/public:mojo_bindings" to the deps[] in components/visitedlink/common/BUILD.gn

We are not using GN inside the chroot yet. We're working on it... but for
now we need to make sure both still work.

Re:#5 then I'm confused how it works for components/visitedlink because there is not a single .GYP file there.

https://cs.chromium.org/chromium/src/components/visitedlink.gypi?sq=package:chromium&l=1

CC thakis@, jamesr@ who may have some context on the dependency of blink mojo bindings.

Apparently visitedlink.gypi does have dependency on public/blink.gyp:blink, however this is not sufficient.

You probably need a hard_dependency somewhere.

I have so far still not yet reproduced this problem with my local tricky official build.

I'm using the gyp workflow:
(1) first build chromeos-chrome from a clean build
(2) remove gen/third_party/WebKit/public/platform/modules/permissions/permission_status.mojom.h and obj/components/visitedlink/common/visitedlink_common.visitedlink_message_generator.o from the output directory
(3) run an incremental build

If there's a dependency problem I'd expect to see this to fail with "permission_status.mojom.h not found" error, but it always succeeds.

If there is a dependency issue that might not fail if the failing target isn't also removed. I suspect there is a subtle build order / timing issue.

The incremental builders have all cycled green and the PFQ builders appear to have all successfully completed the BuildPackages stage, so maybe we are OK now? That said we should double check the dependencies and add one if it is missing.

Lowering to P1.

Happened again here, definitely seems like a missing dependency:

https://build.chromium.org/p/chromiumos.chromium/builders/x86-generic-telemetry/builds/9767/steps/BuildPackages/logs/stdio

Since this is probably a GYP specific failure and since we are planning to switch to GN on Chrome OS in the chroot after we branch on Friday, we can probably live with this for a week, assuming we don't have a similar issue in GN.

Update: The error is seemed again today at build_package stage: https://uberchromegw.corp.google.com/i/chromeos/builders/veyron_minnie-cheets-chrome-pfq/builds/356/steps/BuildPackages/logs/stdio

I'm going to assume this is a static library build, if I'm wrong, please let me know.

The missing file is third_party/WebKit/public/platform/modules/permissions/permission_status.mojom.h
Which is generated by third_party/WebKit/public/blink.gyp:mojo_bindings_blink_mojom

The file being compiled is components/visitedlink/common/visitedlink_message_generator.cc . This file comes from components/visitedlink.gypi:visitedlink_common
which depends on
content/content.gyp:content_common
content_common has a dependency on ../third_party/WebKit/public/blink.gyp:mojo_bindings

The issue is that content.gyp doesn't export blink.gyp:mojo_bindings, so that visitedlink can start compiling before the generated files have been generated.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f535f591cfafe8887d6a718eef1ef6124376637

commit 5f535f591cfafe8887d6a718eef1ef6124376637
Author: sky <sky@chromium.org>
Date: Tue Jun 28 20:39:54 2016

Fix dependency issue in content_common (gyp)

content/public/common/common_param_traits_macros.h includes a
generated header from blink.gyp:mojo_bindings. This means anyone that
depends upon content_common must also depend upon
blink.gyp:mojo_bindings, otherwise the header may not have been
generated and you get a compile error.

The gn build deals with this already by using public_deps.

BUG= 622365 
TEST=build only change
R=jam@chromium.org, japhet@chromium.org

Review-Url: https://codereview.chromium.org/2102183002
Cr-Commit-Position: refs/heads/master@{#402538}

[modify] https://crrev.com/5f535f591cfafe8887d6a718eef1ef6124376637/content/content_common.gypi
[modify] https://crrev.com/5f535f591cfafe8887d6a718eef1ef6124376637/third_party/WebKit/public/blink.gyp

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b56c3456420169cb81c1b08c44372fa4e1c29325

commit b56c3456420169cb81c1b08c44372fa4e1c29325
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Jun 28 20:53:05 2016

Fix dependency issue in content_common (gyp)

content/public/common/common_param_traits_macros.h includes a
generated header from blink.gyp:mojo_bindings. This means anyone that
depends upon content_common must also depend upon
blink.gyp:mojo_bindings, otherwise the header may not have been
generated and you get a compile error.

The gn build deals with this already by using public_deps.

BUG= 622365 
TEST=build only change
R=jam@chromium.org, japhet@chromium.org

Review-Url: https://codereview.chromium.org/2102183002
Cr-Commit-Position: refs/heads/master@{#402538}
(cherry picked from commit 5f535f591cfafe8887d6a718eef1ef6124376637)

Review URL: https://codereview.chromium.org/2107933002 .

Cr-Commit-Position: refs/branch-heads/2782@{#5}
Cr-Branched-From: 4f1d832918c5966df3cc8ac1d23c8c1544262cee-refs/heads/master@{#402386}

[modify] https://crrev.com/b56c3456420169cb81c1b08c44372fa4e1c29325/content/content_common.gypi
[modify] https://crrev.com/b56c3456420169cb81c1b08c44372fa4e1c29325/third_party/WebKit/public/blink.gyp

Bulk verified