Those are showing up as active, hence not being removed by the 'clear all' action.

I agree that dangerous downloads should be removed as a result of calling 'clear all'.

it also leaves in progress downloads (you just didn't have any)

asanka@: I assume we should disallow revival of (i.e. not remember) dangerous downloads?

Yeah. Clear all was historically supposed to remove only "finished" downloads. In-progress downloads should still remain on the page, otherwise they wouldn't have any UI.

Some time ago, we made a change to how some dangerous file types are handled where the download shelf only shows a 'dismiss' action. If the user wants to revive the download, then they need to go to the downloads page to do so. Since these downloads never left the danger state, they also never reached a "finished" state. Hence the bug we have now where 'clear all' doesn't affect them.

Ideally we should treat dangerous but not accepted/recovered downloads as 'finished' downloads, even if they are in-progress. So hitting 'clear all' should get rid of them as well.

And yes, we should remove those downloads entirely. I.e. call DownloadItem::Remove().

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a15d393a0a1760de4f8c78be9225260a9b5979c0

commit a15d393a0a1760de4f8c78be9225260a9b5979c0
Author: dbeam <dbeam@chromium.org>
Date: Thu Jun 23 16:58:02 2016

MD Downloads: "Clear All" should remove dangerous downloads for good

R=asanka@chromium.org
BUG= 622362 

Review-Url: https://codereview.chromium.org/2087043004
Cr-Commit-Position: refs/heads/master@{#401633}

[modify] https://crrev.com/a15d393a0a1760de4f8c78be9225260a9b5979c0/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc
[modify] https://crrev.com/a15d393a0a1760de4f8c78be9225260a9b5979c0/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.h
[modify] https://crrev.com/a15d393a0a1760de4f8c78be9225260a9b5979c0/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler_unittest.cc

Your change meets the bar and is auto-approved for M52 (branch: 2743)

just verified on canary, merging

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c8c10bd3a1b4aebb5759dc37ff5d808e51b95ec

commit 8c8c10bd3a1b4aebb5759dc37ff5d808e51b95ec
Author: Dan Beam <dbeam@chromium.org>
Date: Fri Jun 24 23:57:06 2016

MD Downloads: "Clear All" should remove dangerous downloads for good

R=asanka@chromium.org
BUG= 622362 

Review-Url: https://codereview.chromium.org/2087043004
Cr-Commit-Position: refs/heads/master@{#401633}
(cherry picked from commit a15d393a0a1760de4f8c78be9225260a9b5979c0)

Review URL: https://codereview.chromium.org/2100443003 .

Cr-Commit-Position: refs/branch-heads/2743@{#474}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/8c8c10bd3a1b4aebb5759dc37ff5d808e51b95ec/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc
[modify] https://crrev.com/8c8c10bd3a1b4aebb5759dc37ff5d808e51b95ec/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.h
[modify] https://crrev.com/8c8c10bd3a1b4aebb5759dc37ff5d808e51b95ec/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler_unittest.cc

Verified the merge on the latest M-52(52.0.2743.60/ 2743@{#538}) on Windows-7, Mac OS 10.11.5 and Linux Ubuntu 14.04. On downloading the .exe file from testsafebrowsing.appspot.com/s/content.exe and 'Clear All' clears everything from the Downloads.


Adding the verified label therefore.