New issue
Advanced search Search tips

Issue 622326 link

Starred by 0 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update masters templates/announce.html files regarding tree closers

Project Member Reported by kjellander@chromium.org, Jun 22 2016

Issue description

In the view at build.chromium.org there are many bots grouped as "tree closers" that are no longer tree closers. The view should be updated to reflect reality. It's probably best to remove the wording entirely from this page, as it depends on what step fails if the tree is closed (mostly just compile).

The file to edit is https://chromium.googlesource.com/chromium/tools/build/+/master/masters/master.chromium/templates/announce.html
 
Components: -Infra Infra>Platform>Buildbot
Looks like bug 372576 filtered down the gpu section to only builders that actually close the tree. We could potentially do the same for win, mac, linux, etc but I'm a little concerned that sheriffs might use that display to keep an eye on all bots on those masters, even those that don't close the tree.

Changing the name of that title might be best, but I'm not sure what one would change it to. "Very Important Masters"? "Tree closers, and also not tree closers"...?
Status: Available (was: Untriaged)
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 4 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: -Infra>Platform>Buildbot Infra>Client>Chrome
Not sure if is still valid though.
Owner: estaab@chromium.org
Status: Assigned (was: Untriaged)
Erik, has this changed since we changed to LUCI UI? 

Comment 6 by estaab@chromium.org, Jan 23 2018

Owner: martiniss@chromium.org
We copied everything over to avoid changing too many things at once.

The config defines the header here:
https://chromium.googlesource.com/chromium/src/+/infra/config/luci-milo.cfg

I have no objections to changing things around to make more sense. I think this should be up to CCI to decide how they want everything to be displayed so please feel free to do what's best.

Assigning back to martiniss, please reassign or make available as needed.
Cc: estaab@chromium.org
We'd need some feature work in LUCI UI to truly fix this bug.

The problem here is that the LUCI UI specifies that all builders on chromium.gpu should show up: https://chromium.googlesource.com/chromium/src/+/infra/config/luci-milo.cfg#229

The chromium gatekeeper tree does this as well, but in the chromium.gpu master config in gatekeeper (https://cs.chromium.org/chromium/build/scripts/slave/gatekeeper.json?l=228) it says to exclude several builders. This is the information that milo needs to know about.

There are two solutions I can think of:

1. Teach LUCI UI to read the gatekeeper files, and understand the excluded builders thing. 

2. Duplicate the list of excluded builders into the luci-milo.cfg file. Need to teach LUCI UI how to exclude builders from a console.

Both require some coding as far as I can tell. Doesn't seem like a really trivial change.

Comment 8 by estaab@chromium.org, Jan 24 2018

Instead of (2) we could define a new console (builder group) without the excluded builders and reference that from the header.
Components: Infra>Platform>Milo
Owner: ----
Status: Available (was: Assigned)
I don't think I'll have time to do this. I'm going to mark this as available.

Comment 10 by efoo@chromium.org, Mar 12 2018

Labels: LUCI-Afterglow

Sign in to add a comment