Issue metadata
Sign in to add a comment
|
[perf-dashboard] "View job" link doesn't work |
||||||||||||||||||||||
Issue descriptionSteps to reproduce: 1. Open an arbitrary chart on the Perf Dashboard (e.g. https://chromeperf.appspot.com/report?sid=98d035be5d213897c78ede87f4f23e4d2d5c478d3679cd5d72da21718efbf817). 2. Start a bisect. 3. When the "Job submitted!" toast appears, click on "View job". Expected output: The bisect build should be opened (e.g. https://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus6_perf_bisect/builds/2245). Actual output: The perf dashboard is re-opened (it navigates to https://chromeperf.appspot.com/report?sid=98d035be5d213897c78ede87f4f23e4d2d5c478d3679cd5d72da21718efbf817 again). This happened to me every single time I kicked off a bisect yesterday and today. Not sure if it's relevant, but I was doing "return code" bisects exclusively (perf bot sheriffing). I was always able to find the bisect build via https://build.chromium.org/p/tryserver.chromium.perf/waterfall, i.e. the bisect job runs correctly. However, the vast majority of people have no idea how to manually look up a bisect (e.g. https://groups.google.com/a/chromium.org/forum/#!topic/perf-sheriffs/B8PPsrfSK04), so I'd say this needs to be fixed ASAP.
,
Jun 22 2016
,
Jun 22 2016
This is really strange. I could reproduce this, then I opened devtools to investigate and now I can no longer repro. Petr, did the issue go away for you too?
,
Jun 23 2016
I tried it once again and found the following:
1. I submitted a (return code) bisect WITH a bug ID.
2. A toast with a "View job" (NO job ID shown) was displayed and the
link navigated to the same page (which I opened in a separate tab).
3. I submitted another (return code) bisect WITHOUT a bug ID.
4. A toast with a "View job 123456789..." was displayed and the link
navigated to a buildbucket_job_status page. However, when I
investigated the page, it CONTAINED the bug ID of my first request!
(even though I didn't provide one this time).
5. I submitted yet another (return code) bisect WITH a bug ID.
4. A toast with a "View job 987654321..." was displayed and the link
navigated to a buildbucket_job_status page. However, it contained
NO bug ID! (even though I did provide one this time).
So I guess this is some sort of an ordering problem within the UI.
,
Jun 29 2016
,
Jun 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbd6c910168b53f0e8da94a399aa451a38e436e6 commit bbd6c910168b53f0e8da94a399aa451a38e436e6 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Wed Jun 29 22:29:04 2016 Roll src/third_party/catapult/ a45087135..b8081c5e8 (5 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a4508713566b..b8081c5e8c38 $ git log a45087135..b8081c5e8 --date=short --no-merges --format='%ad %ae %s' BUG=624164, 622290 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2107113003 Cr-Commit-Position: refs/heads/master@{#402959} [modify] https://crrev.com/bbd6c910168b53f0e8da94a399aa451a38e436e6/DEPS
,
Jun 30 2016
Fix is pushed to production. Thanks for the detailed report, Petr!
,
Jun 30 2016
I can still see this happening on the dashboard (I kicked off a bisect ~1 minute ago). Has the fix made it into production yet?
,
Jul 1 2016
Sami has just run into this as well, so I'm re-opening.
,
Jul 1 2016
Could we post a link to the bisect job to the bug so you can still get to it easily even if you miss the popup?
,
Jul 4 2016
,
Jul 12 2016
Re #10: I made the change to the dashboard to post the link to the bug when the bisect is submitted. Sorry for the UI fail here; we're in the middle of upgrading to polymer 1.0 and that plus 0.5 being deprecated for quite some time makes fixing the 0.5 UI difficult.
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f04d86267fdbb9b0a9b7cda9841f7f7126ef0ef commit 6f04d86267fdbb9b0a9b7cda9841f7f7126ef0ef Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Wed Jul 13 02:19:51 2016 Roll src/third_party/catapult/ 4160831d2..72fb0b506 (24 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4160831d2082..72fb0b5062af $ git log 4160831d2..72fb0b506 --date=short --no-merges --format='%ad %ae %s' BUG= 605842 ,531641, 605842 ,450171,589726, 627221 , 625852 ,589726, 622290 ,589726 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2147823002 Cr-Commit-Position: refs/heads/master@{#404903} [modify] https://crrev.com/6f04d86267fdbb9b0a9b7cda9841f7f7126ef0ef/DEPS
,
Jul 18 2016
,
Aug 22 2016
Closing. We've migrated over to 1.0, and the link works in the current version.
,
Oct 19 2016
,
Feb 2 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sullivan@chromium.org
, Jun 22 2016Components: -Tests>Telemetry
Labels: Performance-Dashboard