Capture new password fields for change password forms on iOS |
|||||
Issue descriptionIn order to support updating passwords in Password Manager, new password fields need to be captured and stored in PasswordForm. On iOS, form submissions are observed by PasswordController via JavaScript messaging. If a form contains a password field, PasswordController injects password_controller.js to extract the submitted password form. Password form data is extracted in __gCrWeb.getPasswordFormData, and parsed from JSON to thePasswordForm data structure in -[PasswordController getPasswordForm:fromPasswordFormJSON:pageURL:]. In order to support change passwords, getPasswordForm:fromPasswordFormJSON:pageURL: should populate the new_password* members inPasswordForm. Specifically, the logic in LocateSpecificPasswords should be replicated to determine which fields are the old password and new password, and assign the appropriate members in PasswordForm.
,
Jun 22 2016
,
Jun 23 2016
This has already been implemented. Check verify that it matches other platforms implementation
,
Jul 6 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/198c11e303abe27cb7e926932b314cb628f1193d commit 198c11e303abe27cb7e926932b314cb628f1193d Author: jyquinn <jyquinn@google.com> Date: Wed Jul 06 11:56:17 2016
,
Jul 6 2016
,
Jul 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b27161f6225ea23fc5e3c4d1b94f85cecca9d23e commit b27161f6225ea23fc5e3c4d1b94f85cecca9d23e Author: jyquinn <jyquinn@chromium.org> Date: Wed Jul 06 12:41:46 2016 Fix current/new password assignment in iOS PasswordController Fixes assignment of current versus new password elements in getPasswordForm to match LocateSpecificPasswords in password_form_conversion_utils.cc. Previously, the password elements had been added to the form in reverse order. BUG= 622253 Review-Url: https://codereview.chromium.org/2125653002 Cr-Commit-Position: refs/heads/master@{#403889} [modify] https://crrev.com/b27161f6225ea23fc5e3c4d1b94f85cecca9d23e/ios/chrome/browser/passwords/password_controller.mm
,
Jul 6 2016
,
Jul 7 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/cc26a03f6bf4f6c1c0d0d8767e2948c8eb252a42 commit cc26a03f6bf4f6c1c0d0d8767e2948c8eb252a42 Author: jyquinn <jyquinn@google.com> Date: Thu Jul 07 05:49:17 2016
,
Jul 19 2016
Verified 'Update Password UI' with the below scenarios on iPhone 6+(10.0), iPad Air 2(9.3.1) in 54.0.2800.0 canary Enabled 'Enable Update Password UI' in Experimental Settings. 1. When password is changed for the saved passwords, Change password info bar is displayed with username when there is only one credential for that particular site - Screenshot 1 2. When multiple credentials are saved for the webpage, the infobar is displayed with a link for the username and the password is updated for that credential on tapping 'Update' button in the infobar. - Screenshot 2 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jyqu...@chromium.org
, Jun 22 2016