New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 622241 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
█ aelias@chromium.org
changwan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Replace the usage of onKeyUp() with onKey() in ContentView

Project Member Reported by ajit...@samsung.com, Jun 22 2016 
Version: Chrome 51.2704
OS: Android L OS 5.1.1

Currently in ContentViewCore, we are using onKeyUp() to track the use of BACK_KEY. But it's better to use onKey(), because it gives chance to listeners to respond before the target view. So it can be a graceful exit, than that of onKeyUp()

Comment 1 by ajit...@samsung.com, Jun 22 2016

Components: UI>Input>Text>IME
Labels: OS-Android

Comment 2 by ajit...@samsung.com, Jun 23 2016 

@changwan - Could you please share your thoughts on this ?

Comment 3 by aelias@chromium.org, Jun 23 2016 

What's the user facing bug that comes out of this?  I don't understand.  What kind of listeners and what kind of exit are you referring to?

Comment 4 by ajit...@samsung.com, Jun 23 2016 

There is no user bug as of now. Recently I made a change in https://codereview.chromium.org/1947603002/ which takes care of giving BACK KEY to keyboard early and the android documentation also suggests onKey() is better approach. So thought of applying it here.
►

Sign in to add a comment