Non-Regression : Unnecessarily "Show device frame" option is enabled for selected Devices |
|||||
Issue descriptionVersion: 52.0.2743.49 OS: Ubuntu 14.04, Windows What steps will reproduce the problem? (1)Launch chrome -> Go to any page(Ex: chrome://settings) (2)Now Press F12 to open Dev tools->Click on "Toggle device toolbar" -> Click on Devices drop down and select "Edit" option (3)Now check Devices(Ex: Nexus 7, Nexus 6, LG Optimus) -> Now in Emulation Mode select device (Ex:"Nexus 7") -> click on "More Options" and observe "Show device frame" option is enabled Expected: If Device Frame is not enabled for custom devices then option "Show device frame" should be disabled Actual: Instead "Show device frame" option is enabled for selected Devices Note: We can observe "Show device frame" option is disabled for "Responsive" This is Non-Regression Issue as "Device Frame" option is introduced from 52.0.2735.0 Build Below is the MANUAL CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/52.0.2734.0..52.0.2735.0?pretty=fuller&n=10000 Suspecting https://codereview.chromium.org/1969913002 from Manual Changelog @dgozman : Please feel free to re-assign if its not related to your change
,
Jun 22 2016
I'm not sure what's the best thing here. Disabling it would lead to "Hide device frame" being shown but disabled for devices without frame. Chris, any idea? Should we merge this with portrait/landscape/keyboard view somehow?
,
Jul 3 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 20 2016
Here's the logic I'd apply in the short-term: * If the selected device doesn't have a frame, then * Display the "Show device frame" menu item and disable it * Otherwise, if showing the device frame is enabled, then * Display the "Hide device frame" menu item and enable it * Otherwise, * Display the "Show device frame" menu item and enable it This will make it clear that a) you can show the frame if the device supports it; b) you cannot show the frame it the device doesn't support it; and c) you can hide the frame if it's shown. The only use case this doesn't support is hiding frames when viewing a device that doesn't support frames, which I'd consider rare (you'd typically want to remove the frame when it's present) and with an easy workaround (switch to a device with a frame and then disable it).
,
Jul 20 2016
,
Jul 29 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kavvaru@chromium.org
, Jun 22 2016