New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 622236 link

Starred by 1 user
Status: Fixed
Owner:
█ nyquist@chromium.org
Traveling - Back 2/6
Closed: Aug 2016
Cc:
█ nyquist@chromium.org
dtrainor@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

blimp_test_apk failing on Android Tests (dbg)

Project Member Reported by perezju@chromium.org, Jun 22 2016 
Error:

detected failure in org.chromium.blimp.core.BlimpContentsTest#testBasic. raw output:
  INSTRUMENTATION_STATUS: numtests=1
  INSTRUMENTATION_STATUS: stream=
  org.chromium.blimp.core.BlimpContentsTest:
  INSTRUMENTATION_STATUS: id=InstrumentationTestRunner
  INSTRUMENTATION_STATUS: test=testBasic
  INSTRUMENTATION_STATUS: class=org.chromium.blimp.core.BlimpContentsTest
  INSTRUMENTATION_STATUS: current=1
  INSTRUMENTATION_STATUS_CODE: 1
  INSTRUMENTATION_STATUS: numtests=1
  INSTRUMENTATION_STATUS: stream=
  Error in testBasic:
  java.lang.AssertionError
     at org.chromium.base.ThreadUtils.assertOnUiThread(ThreadUtils.java:192)
     at org.chromium.blimp.BlimpLibraryLoader.startAsync(BlimpLibraryLoader.java:68)
     at org.chromium.blimp.BlimpNativeInstrumentationTestCase.setUp(BlimpNativeInstrumentationTestCase.java:23)
     at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:129)
     at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
     at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
     at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
     at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
  
  INSTRUMENTATION_STATUS: id=InstrumentationTestRunner
  INSTRUMENTATION_STATUS: test=testBasic
  INSTRUMENTATION_STATUS: class=org.chromium.blimp.core.BlimpContentsTest
  INSTRUMENTATION_STATUS: stack=java.lang.AssertionError
     at org.chromium.base.ThreadUtils.assertOnUiThread(ThreadUtils.java:192)
     at org.chromium.blimp.BlimpLibraryLoader.startAsync(BlimpLibraryLoader.java:68)
     at org.chromium.blimp.BlimpNativeInstrumentationTestCase.setUp(BlimpNativeInstrumentationTestCase.java:23)
     at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:129)
     at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
     at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
     at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
     at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
  
  INSTRUMENTATION_STATUS: current=1
  INSTRUMENTATION_STATUS_CODE: -1
  INSTRUMENTATION_RESULT: stream=
  Test results for BaseChromiumInstrumentationTestRunner=.E
  Time: 0.013
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/34980/steps/Instrumentation%20test%20blimp_test_apk/logs/stdio

Sadly, before that the bot was failing due to other reasons (issue 612151), and we have a long blame list. Trying to figure that out now.

Comment 1 by perezju@chromium.org, Jun 22 2016

Cc: nyquist@chromium.org rsleevi@chromium.org ccameron@chromium.org
The possible blamelist is:
https://chromium.googlesource.com/chromium/src/+log/3dec65ce8a52354cf041ac572ba5f50681f1b575%5E..a524a1c6a6065bcfc162def48a93b1a2de1cf5cc?pretty=fuller

CLs that appear to touch blimp related code:

a69c79a742baf63c5a1a43edd6984c430b47c07b Move net/base/test_data_directory.[cc,h] to net/test
399d94a026f104afe16d129cb587431351b0419d Remove CreateGpuMemoryBufferFromClientId and plumbing
986f860c8fc6361d727a9ccd3c8cd44727b6f5ca Add BlimpContents[,Observer] and BlimpNavigationController

cc'ing authors of those in case you could have some clue.

Trying to repro locally now.

Comment 2 by perezju@chromium.org, Jun 22 2016 

Interesting thing, this fails on:

- Android Tests (dbg) (N5 on K)
- KitKat Tablet Tester
- Jelly Bean Tester

But *not* on:

- Lollipop Phone Tester
- Lollipop Tablet Tester
- Lollipop Low-end Tester
- Marshmallow Tablet Tester

So the breakage is only pre-L?

Comment 3 by perezju@chromium.org, Jun 22 2016 

Ah, the failing test was just introduced by org.chromium.blimp.core.BlimpContentsTest, so strongly suspecting 986f860c8fc6361d727a9ccd3c8cd44727b6f5ca

Sorry Tommy.

Will do a quick test to see if I can repro.

Comment 4 by perezju@chromium.org, Jun 22 2016

Cc: -rsleevi@chromium.org -ccameron@chromium.org dtrainor@chromium.org
Still unable to repro, but will try disabling the test. Hopefully this will bring the bots back to green.

Disabling here: https://codereview.chromium.org/2088203002/
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fce9b790fd74aad8fffc86468b85dbba9d8ff34a

commit fce9b790fd74aad8fffc86468b85dbba9d8ff34a
Author: perezju <perezju@chromium.org>
Date: Wed Jun 22 11:07:06 2016

Disable org.chromium.blimp.core.BlimpContentsTest#testBasic

Test is failing on pre-L devices.

BUG= 622236 
TBR=nyquist@chromium.org,dtrainor@chromium.org

Review-Url: https://codereview.chromium.org/2088203002
Cr-Commit-Position: refs/heads/master@{#401251}

[modify] https://crrev.com/fce9b790fd74aad8fffc86468b85dbba9d8ff34a/blimp/client/app/android/javatests/src/org/chromium/blimp/core/BlimpContentsTest.java

Comment 6 by perezju@chromium.org, Jun 22 2016

Labels: -Pri-0 Pri-2
Owner: nyquist@chromium.org
Lowering priority as this is not blocking bots anymore
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58701445475f240357b16f4fd2bb46a489247f7d

commit 58701445475f240357b16f4fd2bb46a489247f7d
Author: nyquist <nyquist@chromium.org>
Date: Wed Jul 06 23:06:58 2016

Fix blimp native Java tests on platforms with assert.

The BlimpNativeInstrumentationTestCase wrapper for blimp tests that need
to load native code to run was not using the UI thread for loading the
library. There was an assert checking for this, but this doesn't execute
on newer platforms, so was not caught during development or in the CQ.

This CL fixes the issue by ensuring that the library is loaded on the
correct thread.

BUG= 622236 

Review-Url: https://codereview.chromium.org/2124143002
Cr-Commit-Position: refs/heads/master@{#403965}

[modify] https://crrev.com/58701445475f240357b16f4fd2bb46a489247f7d/blimp/client/app/android/javatests/src/org/chromium/blimp/BlimpNativeInstrumentationTestCase.java
[modify] https://crrev.com/58701445475f240357b16f4fd2bb46a489247f7d/blimp/client/app/android/javatests/src/org/chromium/blimp/core/BlimpContentsTest.java

Comment 8 by nyquist@chromium.org, Aug 16 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment