SERIOUS: Lines left behind on page when moving scaled divs
Reported by
vpberr...@gmail.com,
Jun 22 2016
|
|||||||||||||||
Issue descriptionChrome Version : 51.0.2704.103 m URLs (if applicable) : https://jsfiddle.net/x92p1jts/ Other browsers tested: Add OK or FAIL, along with the version, after other browsers where you have tested this issue: Safari: Firefox: OK 44.0.2 IE: OK 11.0.9600.18314 What steps will reproduce the problem? (1) Go to the JSFiddle URL provided (2) Drag the box around slowly with the mouse (3) If no artifacts left behind, adjust the scale with the mousewheel and scroll again What is the expected result? The box moves around cleanly What happens instead? When the box is moved around it leaves behind lines on the page which look terrible. Please provide any additional information below. Attach a screenshot if possible.
,
Jun 22 2016
,
Jun 23 2016
Able to reproduce the issue on Win 7 using stable 51.0.2704.103 and issue persists on canary 53.0.2774.3 too. Bisect info: ============ Good:51.0.2695.0 Bad :51.0.2696.0 CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/8694d7b928ba2b7bfe73fbcb74d052faa5eb309c..4c9fd0d3128c87e1289e9ac1d47fec18d7107077 possible suspect : https://codereview.chromium.org/1848653006 sky@ : Could you please take a look into this if its related to your change, else help us assigning to an appropriate owner for the same. Thanks in advance..! Marking it as ReleaseBlock-Beta for M53 due to recent regression, please modify if not appropriate. Note: This issue is not seen on Mac 10.11.5 and Ubuntu 14.04.
,
Jun 23 2016
https://codereview.chromium.org/1848653006 doesn't effect the windows build at all. I suspect something blink or gpu related broke this. I don't see anything relevant in the changelog. Are you sure the bisect/changelog is correct?
,
Jun 23 2016
Might be a partial raster bug (https://codereview.chromium.org/1836283006 is in the regression range).
,
Jun 23 2016
M53 is branching soon and will be promoted to Beta in July.Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix ASAP. Thank you.
,
Jun 23 2016
I'll look.
,
Jun 23 2016
Confirmed: this paint invalidation bug was indeed exposed by partial raster.
,
Jun 24 2016
The bug seems to be that in LayoutBox::mapToVisualRectInAncestorSpace, we pixel-snap before applying a transform. Maybe we need enclosingIntRect.
,
Jun 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05953c442a6d3a9dd96bc4bb36c27f0dec5ef008 commit 05953c442a6d3a9dd96bc4bb36c27f0dec5ef008 Author: chrishtr <chrishtr@chromium.org> Date: Sat Jun 25 00:10:26 2016 Use enclosingIntRect when computing paint invalidations across transforms. Pixel-snapping cannot be computed correctly across the transform if the transform includes a scale component. BUG= 622232 Review-Url: https://codereview.chromium.org/2098683003 Cr-Commit-Position: refs/heads/master@{#402023} [add] https://crrev.com/05953c442a6d3a9dd96bc4bb36c27f0dec5ef008/third_party/WebKit/LayoutTests/paint/invalidation/invalidation-with-scale-transform-expected.png [add] https://crrev.com/05953c442a6d3a9dd96bc4bb36c27f0dec5ef008/third_party/WebKit/LayoutTests/paint/invalidation/invalidation-with-scale-transform-expected.txt [add] https://crrev.com/05953c442a6d3a9dd96bc4bb36c27f0dec5ef008/third_party/WebKit/LayoutTests/paint/invalidation/invalidation-with-scale-transform.html [modify] https://crrev.com/05953c442a6d3a9dd96bc4bb36c27f0dec5ef008/third_party/WebKit/Source/core/layout/LayoutBox.cpp
,
Jun 27 2016
This is also a bug in 52. It's very safe, will try to merge into that branch.
,
Jun 27 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 27 2016
This is working fine on Win7/64 bit - Version 53.0.2780.0 canary (64-bit). Hence adding TE-Verified labels. chrishtr@, can you please merge the CL in to M52 branch by EOD so that it gets picked up for Beta promotion scheduled this wednesday.
,
Jun 27 2016
,
Jun 28 2016
Merged CL: https://codereview.chromium.org/2106463002
,
Jun 28 2016
this bug is also not updated with the merged CL by bugdroid, + sheyang@ to take a look and fix. Thanks.
,
Jun 28 2016
The openssl problem just occurred again. I need to look further into it.
,
Jun 30 2016
Verified the issue on Win 7 using 52.0.2743.60 and its working fine now. Added respective TE-Verified labels for the same.
,
Jul 1 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 1 2016
I merged it.
,
Jul 1 2016
chrishtr@, can you please remove the Merge-Approved-52 label if nothing is pending on this bug ?
,
Jul 1 2016
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by vpberr...@gmail.com
, Jun 22 2016