New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 622225 link

Starred by 1 user
Status: Fixed
Owner:
anthonyvd@chromium.org
Closed: Jun 2016
Cc:
nyerramilli@chromium.org
█ tkonch...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: unnecessary context menu appears for 'Settings' button on "You're now signed in to Chrome" overlay.

Reported by dchau...@etouch.net, Jun 22 2016 
Chrome Version: 52.0.2743.49 (Official Build) 01329c89b0a4e83f6481fd5f600b520719a25c9f-refs/branch-heads/2743@{#441} 32/64-bit.
OS: Windows(7,8,10), Mac(10.10.5,10.11.4), Linux (ubuntu 14.04 LTS)

Precondition: Enable 'new gaia password-separated sign in flow' flag from 'chrome://flags'.

What steps will reproduce the problem?
1. Launch chrome and sign in to chrome such that "You're now signed in to Chrome" overlay appears.
2. Now right click on 'Settings' button and observe.
3. Click on 'Open link in new tab/Open link in new window/Open link in incognito window' and observe.

Actual:
1. After step 2: Unnecessary context menu appears for 'Settings' button.
2. After step 3: Nothing happens after clicking on 'Open link in new tab/Open link in new window/Open link in incognito window' options.

Expected:
1. After Step 2: Context menu should not appear for 'Settings' button.
2. After step 3: If context menu appears then 'Open link in new tab/Open link in new window/Open link in incognito window' options should work properly.

This is a regression issue, broken in M-50 series, below is bisect info.

Good build: 50.0.2632.0 
Bad build: 50.0.2633.3

Unable to Sign in to chromium builds hence won't be able to provide bisect info.
Change Log URL:
https://chromium.googlesource.com/chromium/src/+log/50.0.2632.0..50.0.2633.0?pretty=fuller&n=10000

Suspecting: r371907 ?

@anthonyvd: Kindly help to reassign, if your changes are not related to this issue.

Note: This issue is directly reproducible on Canary build as 'new gaia password-separated sign in flow' flag is by default enabled form M-53 series.

Kindly review the attached screen-cast for reference.
Actual Screenshot.png
56.6 KB View Download
Actual_behavior.mp4
1.4 MB View Download
Expected behavior.mp4
1.3 MB View Download
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 22 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc9e2a6739335b0ad0ed16b8ffd08a68a96e6b2e

commit dc9e2a6739335b0ad0ed16b8ffd08a68a96e6b2e
Author: anthonyvd <anthonyvd@chromium.org>
Date: Mon Jun 27 18:41:01 2016

Disable the Context Menu in the tab-modal signin dialog.

This prevents weird behaviors such as opening links in different profiles and unusable "view source" and "print" buttons.

BUG= 622225 , 614680 , 602594 
TEST=
1. Open the User Menu and click "sign in to Chrome"
2. In the sign in flow and the sync confirmation dialog, right-clicking to display the context menu shouldn't work.

Review-Url: https://codereview.chromium.org/2093563003
Cr-Commit-Position: refs/heads/master@{#402235}

[modify] https://crrev.com/dc9e2a6739335b0ad0ed16b8ffd08a68a96e6b2e/chrome/browser/ui/signin_view_controller_delegate.cc
[modify] https://crrev.com/dc9e2a6739335b0ad0ed16b8ffd08a68a96e6b2e/chrome/browser/ui/signin_view_controller_delegate.h

Comment 3 by anthonyvd@chromium.org, Jun 27 2016

Status: Fixed (was: Assigned)

Comment 4 by nyerramilli@chromium.org, Jun 28 2016

Labels: TE-Verified-M53 TE-Verified-53.0.2782.0
Tested this issue on Win7, Mac OS X 10.11.5, Ubuntu 14.04 using Chrome Canary/Dev # 53.0.2782.0 and the context menu was disabled.

adding TE-verified labels and attached screencast for reference.
context menu.mov
9.2 MB Download
►

Sign in to add a comment