New issue
Advanced search Search tips

Issue 622222 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 621198
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

4.1% regression in power.trivial_scroll at 400873:400882

Project Member Reported by toyoshim@chromium.org, Jun 22 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=622222

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgwvKspAoM


Bot(s) for this bug's original alert(s):

chromium-rel-mac11
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jun 22 2016

Cc: sunn...@chromium.org
Owner: sunn...@chromium.org

=== Auto-CCing suspected CL author sunnyps@chromium.org ===

Hi sunnyps@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of cc: Add mailbox support to ResourceProvider write locks. (patchset #24 id:460001 of https://codereview.chromium.org/1951193002/ )
Author  : sunnyps
Commit description:
  
Reason for revert:
 Bug 621422 , 621130

Some tasks can be completed twice which leads to crashes.

Original issue's description:
> cc: Add mailbox support to ResourceProvider write locks.
>
> This adds support for mailboxes to ScopedWriteLockGL. Using the mailbox
> requires using ScopedTextureProvider/ScopedSkSurfaceProvider which
> ensures that the texture id for the mailbox is destroyed after use on
> the worker context.
>
> This CL also includes the following cleanup:
> 1. ResourceProvider locks don't keep resource pointers around.
> 2. ScopedSamplerGL does not inherit from ScopedReadLockGL.
> 3. GpuRasterizer is folded back into GpuRasterBufferProvider.
> 4. TileTaskManager does not own RasterBufferProvider.
>
> BUG= 525259 
> R=piman@chromium.org
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/5fa5dbdf25bbec21b84f752d3f0642cd184467e2
> Committed: https://crrev.com/3b0f0b8d3db0a9f66864d5b7da87c82f49e74a29
> Cr-Original-Commit-Position: refs/heads/master@{#398204}
> Cr-Commit-Position: refs/heads/master@{#399983}

TBR=piman@chromium.org,reveman@chromium.org,vmiura@chromium.org,ericrk@chromium.org,vmpstr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 525259 , 621422 ,621130
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2081863002
Cr-Commit-Position: refs/heads/master@{#400873}
Commit  : 12074d3d1ac750fb170355f503d160f48cfefed0
Date    : Tue Jun 21 01:59:59 2016


===== TESTED REVISIONS =====
Revision         Mean    Std Dev  N  Good?
chromium@400872  4131.4  241.151  5  good
chromium@400873  3635.8  11.7346  5  bad    <--
chromium@400874  3631.0  1.87083  5  bad
chromium@400875  3509.4  287.834  5  bad
chromium@400877  3640.0  7.4162   5  bad
chromium@400882  3633.2  7.91833  5  bad

Bisect job ran on: mac_10_11_perf_bisect
Bug ID: 622222

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests power.trivial_scroll
Test Metric: idle_wakeups_total/idle_wakeups_total
Relative Change: 12.06%
Score: 99.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/682
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9009167303412481440


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5512690521341952

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Labels: -Pri-2 Pri-1
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 3 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Mergedinto: 621198
Status: Duplicate (was: Assigned)
The revert shouldn't have caused the regression but the original CL did. That's being tracked in  issue 621198 .

Sign in to add a comment