New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622215 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression : Synced Tabs are not opening in Separate Window in chrome://history

Project Member Reported by mm00333...@techmahindra.com, Jun 22 2016

Issue description

Version: 52.0.2743.49
OS: Ubuntu 14.04,Windows

Pre condition: Enable  'Material Design history' flag from 'chrome://flags'

What steps will reproduce the problem?
(1)Launch chrome -> Sign in to chrome so that history of other devices is synced 
(2)Now Go to chrome://history page ->click on "Synced Tabs"
(3) Click on "Open all" link from synced history and observe (Please refer Video)

Expected: On clicking  "Open all" link Synced Tabs should get opened in Separate Window 
Actual: Instead Synced Tabs opened in one Window


This is Non-Regression Issue Seen from M-51 as "Synced TAbs" Feature is introduced from 51.0.2678.0 Build

Below is the MANUAL CHANGELOG URL:

https://chromium.googlesource.com/chromium/src/+log/51.0.2677.0..51.0.2678.0?pretty=fuller&n=10000

Suspecting https://codereview.chromium.org/1729263005 from Manual Changelog

@ calamity : Please feel free to re-assign if its not related to your change

 
Actual_History.ogv
2.0 MB View Download
Expected_History.ogv
1.6 MB View Download
Labels: OS-Mac
Able to reproduce the issue on Mac 10.11.5 using chrome version 52.0.2743.49
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 3 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Proj-MaterialDesign-WebUI
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63780b934269e5524d7ac0d93792001b3f69ff4b

commit 63780b934269e5524d7ac0d93792001b3f69ff4b
Author: calamity <calamity@chromium.org>
Date: Wed Jul 27 06:36:40 2016

[MD History] Use openForeignSession message to open foreign session tabs.

This CL makes the synced tabs page use the same message as the old
history page to open synced tabs. This also fixes an issue with the way
the Open All Tabs button behaves which now opens all new tabs in
separate windows.

BUG= 622215 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2172563002
Cr-Commit-Position: refs/heads/master@{#408061}

[modify] https://crrev.com/63780b934269e5524d7ac0d93792001b3f69ff4b/chrome/browser/resources/history/externs.js
[modify] https://crrev.com/63780b934269e5524d7ac0d93792001b3f69ff4b/chrome/browser/resources/md_history/browser_service.html
[modify] https://crrev.com/63780b934269e5524d7ac0d93792001b3f69ff4b/chrome/browser/resources/md_history/browser_service.js
[modify] https://crrev.com/63780b934269e5524d7ac0d93792001b3f69ff4b/chrome/browser/resources/md_history/compiled_resources2.gyp
[modify] https://crrev.com/63780b934269e5524d7ac0d93792001b3f69ff4b/chrome/browser/resources/md_history/constants.js
[modify] https://crrev.com/63780b934269e5524d7ac0d93792001b3f69ff4b/chrome/browser/resources/md_history/synced_device_card.html
[modify] https://crrev.com/63780b934269e5524d7ac0d93792001b3f69ff4b/chrome/browser/resources/md_history/synced_device_card.js
[modify] https://crrev.com/63780b934269e5524d7ac0d93792001b3f69ff4b/chrome/browser/resources/md_history/synced_device_manager.html
[modify] https://crrev.com/63780b934269e5524d7ac0d93792001b3f69ff4b/chrome/browser/resources/md_history/synced_device_manager.js

Status: Fixed (was: Assigned)
Cc: calamity@chromium.org odean@chromium.org
 Issue 630254  has been merged into this issue.
Labels: TE-Verified-54.0.2823.0 TE-Verified-M54 TE-Verified-54.0.2824.0
Verified the issue on Windows-10, Mac OS 10.11.6 using chrome latest Dev M54-54.0.2824.0 and Ubuntu 14.04 using chrome latest Dev M54-54.0.2823.0. Observed On clicking "Open all" link from Synced Tabs all the pages are opening in different window as expected. Hence adding TE-Verified label.
622215.mp4
663 KB View Download

Sign in to add a comment