New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 622133 link

Starred by 10 users
Status: Fixed
Owner:
ccameron@chromium.org
Closed: May 2017
Cc:
█ hubbe@chromium.org
ccameron@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 635042
issue 676054


Sign in to add a comment

Add color correction to the compositor for video elements

Project Member Reported by ccameron@chromium.org, Jun 22 2016 
This bug covers all work to plumb color profile information through to the compositor, so that video elements can have color correction applied by the GLRenderer.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29736bc1123b16d24716cd8d8f62bc2174a0746e

commit 29736bc1123b16d24716cd8d8f62bc2174a0746e
Author: ccameron <ccameron@chromium.org>
Date: Fri Jun 24 01:23:38 2016

Color: Remove ViewMsg_ColorProfile

This is not used yet. When it is ready to be used, it will be rolled
into the same IPC that updates the other screen properties.

BUG= 622133 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2085973004
Cr-Commit-Position: refs/heads/master@{#401770}

[modify] https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e/blimp/engine/feature/engine_render_widget_feature_unittest.cc
[modify] https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e/content/browser/frame_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e/content/browser/frame_host/render_widget_host_view_guest.h
[modify] https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e/content/browser/renderer_host/render_widget_host_view_base.h
[modify] https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e/content/browser/renderer_host/render_widget_host_view_mus.cc
[modify] https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e/content/browser/renderer_host/render_widget_host_view_mus.h
[modify] https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e/content/common/view_messages.h
[modify] https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e/content/public/browser/render_widget_host.h
[modify] https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e/content/renderer/render_widget.cc
[modify] https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e/content/renderer/render_widget.h
[modify] https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e/content/test/test_render_view_host.cc
[modify] https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e/content/test/test_render_view_host.h
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f0de31ea0e8651a39ffe77d214d28a565d9ca1c

commit 3f0de31ea0e8651a39ffe77d214d28a565d9ca1c
Author: ccameron <ccameron@chromium.org>
Date: Sat Jun 25 08:11:02 2016

Clean up gfx::ColorProfile

Remove unused methods for querying the color profile of a particular
display. Something similar to these will be added in the future.

Add an explicit "update the cache read from disk" method on Windows.

BUG= 622133 

Review-Url: https://codereview.chromium.org/2092533002
Cr-Commit-Position: refs/heads/master@{#402058}

[modify] https://crrev.com/3f0de31ea0e8651a39ffe77d214d28a565d9ca1c/content/browser/renderer_host/render_message_filter.cc
[modify] https://crrev.com/3f0de31ea0e8651a39ffe77d214d28a565d9ca1c/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/3f0de31ea0e8651a39ffe77d214d28a565d9ca1c/ui/gfx/BUILD.gn
[modify] https://crrev.com/3f0de31ea0e8651a39ffe77d214d28a565d9ca1c/ui/gfx/color_profile.cc
[modify] https://crrev.com/3f0de31ea0e8651a39ffe77d214d28a565d9ca1c/ui/gfx/color_profile.h
[modify] https://crrev.com/3f0de31ea0e8651a39ffe77d214d28a565d9ca1c/ui/gfx/color_profile_mac.mm
[delete] https://crrev.com/4d3588cbec47fcd629c038a0ca6aad9af58e4192/ui/gfx/color_profile_mac_unittest.mm
[modify] https://crrev.com/3f0de31ea0e8651a39ffe77d214d28a565d9ca1c/ui/gfx/color_profile_win.cc
[delete] https://crrev.com/4d3588cbec47fcd629c038a0ca6aad9af58e4192/ui/gfx/color_profile_win_unittest.cc
[modify] https://crrev.com/3f0de31ea0e8651a39ffe77d214d28a565d9ca1c/ui/gfx/gfx_tests.gyp
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ea67932168cc5b1f5685a655c667b4a083f6f29

commit 1ea67932168cc5b1f5685a655c667b4a083f6f29
Author: ccameron <ccameron@chromium.org>
Date: Thu Jun 30 20:44:35 2016

Color: Rename gfx::ColorProfile to gfx::ColorSpace

This is more accurate terminology. A color space can be represented
by ICC profile. There isn't really such a thing as a "color profile".

BUG= 622133 

Review-Url: https://codereview.chromium.org/2106303002
Cr-Commit-Position: refs/heads/master@{#403275}

[modify] https://crrev.com/1ea67932168cc5b1f5685a655c667b4a083f6f29/content/browser/renderer_host/render_message_filter.cc
[modify] https://crrev.com/1ea67932168cc5b1f5685a655c667b4a083f6f29/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/1ea67932168cc5b1f5685a655c667b4a083f6f29/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/1ea67932168cc5b1f5685a655c667b4a083f6f29/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/1ea67932168cc5b1f5685a655c667b4a083f6f29/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/1ea67932168cc5b1f5685a655c667b4a083f6f29/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/1ea67932168cc5b1f5685a655c667b4a083f6f29/ui/gfx/BUILD.gn
[delete] https://crrev.com/513a888b2e3fb9b99fb623d32d22b6059c93951f/ui/gfx/color_profile.cc
[delete] https://crrev.com/513a888b2e3fb9b99fb623d32d22b6059c93951f/ui/gfx/color_profile.h
[delete] https://crrev.com/513a888b2e3fb9b99fb623d32d22b6059c93951f/ui/gfx/color_profile_win.cc
[add] https://crrev.com/1ea67932168cc5b1f5685a655c667b4a083f6f29/ui/gfx/color_space.cc
[add] https://crrev.com/1ea67932168cc5b1f5685a655c667b4a083f6f29/ui/gfx/color_space.h
[rename] https://crrev.com/1ea67932168cc5b1f5685a655c667b4a083f6f29/ui/gfx/color_space_mac.mm
[add] https://crrev.com/1ea67932168cc5b1f5685a655c667b4a083f6f29/ui/gfx/color_space_win.cc
[modify] https://crrev.com/1ea67932168cc5b1f5685a655c667b4a083f6f29/ui/gfx/gfx.gyp
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76

commit 3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76
Author: ccameron <ccameron@chromium.org>
Date: Thu Jun 30 21:35:46 2016

Color: Plumb color profile from ui::Compositor to cc::DirectRenderer

The color profile will originate in content::RenderWidgetHostViewMac
on Mac and aura::WindowTreeHost on Aura, and will need to be consumed
in the cc::GLRenderer in a shader and in the
content::GpuSurfacelessBrowserCompositorOutputSurface. Both of
these originating structures have a ui::Compositor.

This follows the same plumbing paths as device scale factor and surface
size.

BUG= 622133 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2102203003
Cr-Commit-Position: refs/heads/master@{#403296}

[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/android_webview/browser/parent_output_surface.cc
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/android_webview/browser/parent_output_surface.h
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/ash/sysui/stub_context_factory.cc
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/ash/sysui/stub_context_factory.h
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/cc/output/delegating_renderer.cc
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/cc/output/delegating_renderer.h
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/cc/output/direct_renderer.cc
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/cc/output/direct_renderer.h
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/cc/output/gl_renderer_unittest.cc
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/cc/output/output_surface.cc
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/cc/output/output_surface.h
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/cc/output/overlay_unittest.cc
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/cc/output/renderer.h
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/cc/output/renderer_pixeltest.cc
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/cc/output/software_renderer_unittest.cc
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/cc/surfaces/display.cc
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/cc/surfaces/display.h
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/cc/test/pixel_test.cc
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/cc/test/pixel_test_output_surface.cc
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/cc/test/pixel_test_output_surface.h
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/components/mus/surfaces/direct_output_surface_ozone.cc
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/components/mus/surfaces/direct_output_surface_ozone.h
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/content/browser/compositor/gpu_process_transport_factory.h
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/content/browser/compositor/offscreen_browser_compositor_output_surface.cc
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/content/browser/compositor/offscreen_browser_compositor_output_surface.h
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/content/renderer/android/synchronous_compositor_output_surface.cc
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/content/renderer/android/synchronous_compositor_output_surface.h
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/ui/compositor/compositor.cc
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/ui/compositor/compositor.h
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/ui/compositor/test/in_process_context_factory.h
[modify] https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76/ui/views/mus/surface_context_factory.h
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a14007087ef20839871a5284ee3974ada1b208c

commit 9a14007087ef20839871a5284ee3974ada1b208c
Author: ccameron <ccameron@chromium.org>
Date: Sat Jul 02 00:11:20 2016

Color: Add SetColorSpace member to gfx::GpuMemoryBuffer

Add implementation on Mac (where the ICC profile is sent to the
IOSurface).

Add plumbing to call this for the backbuffer. Add plumbing to
get this from the RenderWidgetHostViewMac.

BUG= 622133 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2119723002
Cr-Commit-Position: refs/heads/master@{#403572}

[modify] https://crrev.com/9a14007087ef20839871a5284ee3974ada1b208c/components/display_compositor/buffer_queue.cc
[modify] https://crrev.com/9a14007087ef20839871a5284ee3974ada1b208c/components/display_compositor/buffer_queue.h
[modify] https://crrev.com/9a14007087ef20839871a5284ee3974ada1b208c/components/display_compositor/buffer_queue_unittest.cc
[modify] https://crrev.com/9a14007087ef20839871a5284ee3974ada1b208c/components/mus/surfaces/direct_output_surface_ozone.cc
[modify] https://crrev.com/9a14007087ef20839871a5284ee3974ada1b208c/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/9a14007087ef20839871a5284ee3974ada1b208c/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc
[modify] https://crrev.com/9a14007087ef20839871a5284ee3974ada1b208c/content/browser/renderer_host/browser_compositor_view_mac.h
[modify] https://crrev.com/9a14007087ef20839871a5284ee3974ada1b208c/content/browser/renderer_host/browser_compositor_view_mac.mm
[modify] https://crrev.com/9a14007087ef20839871a5284ee3974ada1b208c/content/browser/renderer_host/render_widget_host_view_mac.mm
[add] https://crrev.com/9a14007087ef20839871a5284ee3974ada1b208c/gpu/ipc/client/OWNERS
[modify] https://crrev.com/9a14007087ef20839871a5284ee3974ada1b208c/gpu/ipc/client/gpu_memory_buffer_impl_io_surface.cc
[modify] https://crrev.com/9a14007087ef20839871a5284ee3974ada1b208c/gpu/ipc/client/gpu_memory_buffer_impl_io_surface.h
[modify] https://crrev.com/9a14007087ef20839871a5284ee3974ada1b208c/ui/gfx/color_space.h
[modify] https://crrev.com/9a14007087ef20839871a5284ee3974ada1b208c/ui/gfx/color_space_mac.mm
[modify] https://crrev.com/9a14007087ef20839871a5284ee3974ada1b208c/ui/gfx/gpu_memory_buffer.cc
[modify] https://crrev.com/9a14007087ef20839871a5284ee3974ada1b208c/ui/gfx/gpu_memory_buffer.h

Comment 7 by jzern@chromium.org, Jul 11 2016 

The change in #6 seems to break local runs of the blink layout tests for me. Has anyone else reported this / is there a bug tracking it? Or am I invoking the layout tests incorrectly?

$ git bisect start 687cf9f 9d47fa1
$ third_party/WebKit/Tools/Scripts/run-webkit-tests \
  --release --nocheck-sys-deps --no-retry-failures \
  http/tests/images/\*webp\* fast/canvas/\*webp\* fast/images/\*webp\* \
  virtual/deferred/fast/images/webp-color-profile-lossy-alpha.html \
  virtual/deferred/fast/images/webp-color-profile-lossy.html \
  virtual/display_list_2d_canvas/fast/canvas/canvas-toBlob-webp-maximum-quality.html \
  virtual/display_list_2d_canvas/fast/canvas/canvas-toDataURL-webp.html \
  virtual/gpu/fast/canvas/canvas-toBlob-webp-maximum-quality.html \
  virtual/gpu/fast/canvas/canvas-toDataURL-webp.html
...
Regressions: Unexpected image-only failures (10)
  fast/canvas/canvas-toBlob-webp-maximum-quality.html [ Failure ]
  fast/canvas/canvas-toDataURL-webp-maximum-quality.html [ Failure ]
  fast/canvas/canvas-toDataURL-webp.html [ Failure ]
  fast/images/webp-color-profile-lossless.html [ Failure ]
  fast/images/webp-color-profile-lossy-alpha.html [ Failure ]
  fast/images/webp-color-profile-lossy.html [ Failure ]
  virtual/display_list_2d_canvas/fast/canvas/canvas-toBlob-webp-maximum-quality.html [ Failure ]
  virtual/display_list_2d_canvas/fast/canvas/canvas-toDataURL-webp.html [ Failure ]
  virtual/gpu/fast/canvas/canvas-toBlob-webp-maximum-quality.html [ Failure ]
  virtual/gpu/fast/canvas/canvas-toDataURL-webp.html [ Failure ]
...
b0df9e3fcbca19d2a625fa274172bd3be4116261 is the first bad commit
commit b0df9e3fcbca19d2a625fa274172bd3be4116261
Author: hubbe <hubbe@chromium.org>
Date:   Wed Jul 6 14:49:18 2016 -0700

    Support for retreiving the monitor color space on X11.

    BUG= 622133 

    Review-Url: https://codereview.chromium.org/2115103002
    Cr-Commit-Position: refs/heads/master@{#403958}

:040000 040000 e572631dc793835613bd11f51860f0f86dae3ec3 f25550b547b2e3ae1132a1a20fc30712df83c1a9 M      ui

Comment 8 by hubbe@chromium.org, Jul 12 2016 

I'm pretty sure the same thing would happen if you ran those tests on windows or mac with a color profile configured. Not sure what the best past forward is, but choices include:

1) Don't set a color profile on your display.
2) run the tests in a virtual X11 instance, with no color profile set
3) Fix the tests.
4) Fix webkit.

Comment 9 by jzern@chromium.org, Jul 12 2016 

> 1) Don't set a color profile on your display.

Sounds like this is overridden on Mac [1].

> 2) run the tests in a virtual X11 instance, with no color profile set

That should work and is touched on for other reasons [2].

> 3) Fix the tests.
> 4) Fix webkit.

These are related, though the fix might be what's done on the Mac.

[1] http://www.chromium.org/developers/testing/webkit-layout-tests
[2] https://chromium.googlesource.com/chromium/src/+/master/docs/layout_tests_linux.md

Comment 10 by hubbe@chromium.org, Jul 12 2016 

I guess we need to add the same kind of unset-and-set-it-back hack to linux as we have on mac. Although, a flag override or ignore the displays ICC profile would be better I think.
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92294e78c762e993e8dcf538860abf65629f3320

commit 92294e78c762e993e8dcf538860abf65629f3320
Author: ccameron <ccameron@chromium.org>
Date: Wed Jul 13 17:36:30 2016

Color: Don't duplicate ICC profile data

Make gfx::ColorSpace have an internal pointer to a globally-unique
structure for the color space, where its ICC profile can be stored.

BUG= 622133 

Review-Url: https://codereview.chromium.org/2140803002
Cr-Commit-Position: refs/heads/master@{#405211}

[modify] https://crrev.com/92294e78c762e993e8dcf538860abf65629f3320/ui/gfx/color_space.cc
[modify] https://crrev.com/92294e78c762e993e8dcf538860abf65629f3320/ui/gfx/color_space.h
[modify] https://crrev.com/92294e78c762e993e8dcf538860abf65629f3320/ui/gfx/color_space_win.cc
[modify] https://crrev.com/92294e78c762e993e8dcf538860abf65629f3320/ui/gfx/color_space_x11.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/075682d2247db4715899446dfcebd22ba952882a

commit 075682d2247db4715899446dfcebd22ba952882a
Author: dbeam <dbeam@chromium.org>
Date: Wed Jul 13 19:22:12 2016

Revert of Color: Don't duplicate ICC profile data (patchset #3 id:40001 of https://codereview.chromium.org/2140803002/ )

Reason for revert:
Broke static initializers step of sizes on Linux:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/22278

Maybe making map_ a base::LazyInstance would solve your problem?

Original issue's description:
> Color: Don't duplicate ICC profile data
>
> Make gfx::ColorSpace have an internal pointer to a globally-unique
> structure for the color space, where its ICC profile can be stored.
>
> BUG= 622133 
>
> Committed: https://crrev.com/92294e78c762e993e8dcf538860abf65629f3320
> Cr-Commit-Position: refs/heads/master@{#405211}

TBR=hubbe@chromium.org,ccameron@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 622133 

Review-Url: https://codereview.chromium.org/2148013002
Cr-Commit-Position: refs/heads/master@{#405221}

[modify] https://crrev.com/075682d2247db4715899446dfcebd22ba952882a/ui/gfx/color_space.cc
[modify] https://crrev.com/075682d2247db4715899446dfcebd22ba952882a/ui/gfx/color_space.h
[modify] https://crrev.com/075682d2247db4715899446dfcebd22ba952882a/ui/gfx/color_space_win.cc
[modify] https://crrev.com/075682d2247db4715899446dfcebd22ba952882a/ui/gfx/color_space_x11.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c3ad3287b3fae9b6329f8e7c34c0117b5c8da65

commit 0c3ad3287b3fae9b6329f8e7c34c0117b5c8da65
Author: ccameron <ccameron@chromium.org>
Date: Thu Jul 14 03:03:41 2016

Color: Don't duplicate ICC profile data

Make gfx::ColorSpace have an internal pointer to a globally-unique
structure for the color space, where its ICC profile can be stored.

BUG= 622133 

Committed: https://crrev.com/92294e78c762e993e8dcf538860abf65629f3320
Review-Url: https://codereview.chromium.org/2140803002
Cr-Original-Commit-Position: refs/heads/master@{#405211}
Cr-Commit-Position: refs/heads/master@{#405424}

[modify] https://crrev.com/0c3ad3287b3fae9b6329f8e7c34c0117b5c8da65/ui/gfx/color_space.cc
[modify] https://crrev.com/0c3ad3287b3fae9b6329f8e7c34c0117b5c8da65/ui/gfx/color_space.h
[modify] https://crrev.com/0c3ad3287b3fae9b6329f8e7c34c0117b5c8da65/ui/gfx/color_space_win.cc
[modify] https://crrev.com/0c3ad3287b3fae9b6329f8e7c34c0117b5c8da65/ui/gfx/color_space_x11.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/653c72f34282bcb1f6b118eec477d394b1dbcf1d

commit 653c72f34282bcb1f6b118eec477d394b1dbcf1d
Author: magjed <magjed@chromium.org>
Date: Thu Jul 14 10:18:27 2016

Revert of Color: Don't duplicate ICC profile data (patchset #4 id:60001 of https://codereview.chromium.org/2140803002/ )

Reason for revert:
Breaks bot https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win7%20Tester/builds/4992

It's not allowed to add new callbacks to AtExitManager while the callbacks are already being processed. So that lazy global data is causing trouble.

[3972:940:0713/225822:FATAL:at_exit.cc(60)] Check failed: !g_top_manager->processing_callbacks_.
Backtrace:
	base::debug::StackTrace::StackTrace [0x02F60BB7+23]
	logging::LogMessage::~LogMessage [0x02F1D2E1+49]
	base::AtExitManager::RegisterTask [0x02F61AAA+186]
	base::AtExitManager::RegisterCallback [0x02F619D9+137]
	base::internal::CompleteLazyInstance [0x02F3F2EB+27]
	base::LazyInstance<base::Lock,base::DefaultLazyInstanceTraits<base::Lock> >::Pointer [0x01483E7A+47]
	base::RefCountedThreadSafe<gfx::ColorSpace::GlobalData,base::DefaultRefCountedThreadSafeTraits<gfx::ColorSpace::GlobalData> >::DeleteInternal [0x038E9685+17]
	gfx::ColorSpace::~ColorSpace [0x038E9505+14]
	base::internal::Invoker<base::internal::BindState<void (__cdecl*)(void const *),void const *>,void __cdecl(void)>::Run [0x02F61AFE+14]
	base::AtExitManager::ProcessCallbacksNow [0x02F61894+388]
	base::AtExitManager::~AtExitManager [0x02F616D3+163]
	std::default_delete<base::AtExitManager>::operator() [0x0169C6FD+17]
	base::TestSuite::~TestSuite [0x02FB1D0D+44]
	content::LaunchTests [0x049A02D7+592]
	LaunchChromeTests [0x02F13585+49]
	main [0x00D0B49E+94]
	__scrt_common_main_seh [0x04A0EC12+255] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:255)
	BaseThreadInitThunk [0x766E338A+18]
	RtlInitializeExceptionChain [0x77D49902+99]
	RtlInitializeExceptionChain [0x77D498D5+54]

Original issue's description:
> Color: Don't duplicate ICC profile data
>
> Make gfx::ColorSpace have an internal pointer to a globally-unique
> structure for the color space, where its ICC profile can be stored.
>
> BUG= 622133 
>
> Committed: https://crrev.com/92294e78c762e993e8dcf538860abf65629f3320
> Committed: https://crrev.com/0c3ad3287b3fae9b6329f8e7c34c0117b5c8da65
> Cr-Original-Commit-Position: refs/heads/master@{#405211}
> Cr-Commit-Position: refs/heads/master@{#405424}

TBR=hubbe@chromium.org,dbeam@chromium.org,ccameron@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 622133 

Review-Url: https://codereview.chromium.org/2150883002
Cr-Commit-Position: refs/heads/master@{#405463}

[modify] https://crrev.com/653c72f34282bcb1f6b118eec477d394b1dbcf1d/ui/gfx/color_space.cc
[modify] https://crrev.com/653c72f34282bcb1f6b118eec477d394b1dbcf1d/ui/gfx/color_space.h
[modify] https://crrev.com/653c72f34282bcb1f6b118eec477d394b1dbcf1d/ui/gfx/color_space_win.cc
[modify] https://crrev.com/653c72f34282bcb1f6b118eec477d394b1dbcf1d/ui/gfx/color_space_x11.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1689c8b1c5d6411b8a14912227590345c3c3a94

commit f1689c8b1c5d6411b8a14912227590345c3c3a94
Author: ccameron <ccameron@chromium.org>
Date: Thu Jul 14 20:11:59 2016

Color: Don't duplicate ICC profile data

Make gfx::ColorSpace have an internal pointer to a globally-unique
structure for the color space, where its ICC profile can be stored.

BUG= 622133 

Committed: https://crrev.com/92294e78c762e993e8dcf538860abf65629f3320
Committed: https://crrev.com/0c3ad3287b3fae9b6329f8e7c34c0117b5c8da65
Review-Url: https://codereview.chromium.org/2140803002
Cr-Original-Original-Commit-Position: refs/heads/master@{#405211}
Cr-Original-Commit-Position: refs/heads/master@{#405424}
Cr-Commit-Position: refs/heads/master@{#405552}

[modify] https://crrev.com/f1689c8b1c5d6411b8a14912227590345c3c3a94/ui/gfx/color_space.cc
[modify] https://crrev.com/f1689c8b1c5d6411b8a14912227590345c3c3a94/ui/gfx/color_space.h
[modify] https://crrev.com/f1689c8b1c5d6411b8a14912227590345c3c3a94/ui/gfx/color_space_win.cc
[modify] https://crrev.com/f1689c8b1c5d6411b8a14912227590345c3c3a94/ui/gfx/color_space_x11.cc

Comment 16 by ccameron@chromium.org, Jul 14 2016 

WRT layout tests, we should change tests to use a specific test color profile, rather than query the system's behavior.
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e94e1ca3c70ac232c26b77b6a8cc17ba54307b6

commit 6e94e1ca3c70ac232c26b77b6a8cc17ba54307b6
Author: hubbe <hubbe@chromium.org>
Date: Tue Jul 19 01:59:57 2016

Revert of Support for retreiving the monitor color space on X11. (patchset #2 id:20001 of https://codereview.chromium.org/2115103002/ )

Reason for revert:
Temporary revert as it breaks layout tests for many people.

Original issue's description:
> Support for retreiving the monitor color space on X11.
>
> BUG= 622133 
>
> Committed: https://crrev.com/b0df9e3fcbca19d2a625fa274172bd3be4116261
> Cr-Commit-Position: refs/heads/master@{#403958}

TBR=ccameron@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 622133 

Review-Url: https://codereview.chromium.org/2160133002
Cr-Commit-Position: refs/heads/master@{#406181}

[modify] https://crrev.com/6e94e1ca3c70ac232c26b77b6a8cc17ba54307b6/ui/gfx/BUILD.gn
[modify] https://crrev.com/6e94e1ca3c70ac232c26b77b6a8cc17ba54307b6/ui/gfx/color_space.cc
[delete] https://crrev.com/79f2ae2daa44af38d313e3526587296037d6bade/ui/gfx/color_space_x11.cc
[modify] https://crrev.com/6e94e1ca3c70ac232c26b77b6a8cc17ba54307b6/ui/gfx/gfx.gyp

Comment 18 by pdk...@gmail.com, Jul 19 2016 

Thank you hubbe for implementing monitor color profiles for Linux (X11).

I notice a comment about multi-monitors in the CL. You probably know this already, but the atom name for additional monitors is _ICC_PROFILE_1 and so forth.

Comment 19 by hubbe@chromium.org, Jul 19 2016 

Yeah, I know about _ICC_PROFILE_1, the problem is that the framework around ICC profiles is pretty primitive and is polled. Hopefully we can eventually pull the ICC profile from the monitor the window is actually on, but not yet.
Project Member

Comment 20 by bugdroid1@chromium.org, Jul 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0d9f3857bedccbd50584c260d071b4ad8ee2202

commit e0d9f3857bedccbd50584c260d071b4ad8ee2202
Author: ccameron <ccameron@chromium.org>
Date: Tue Jul 19 20:12:15 2016

Add IPC support for gfx::ColorSpace

This structure, passed browser->renderer, is not necessarily an
ICC profile, so we shouldn't be passing it around as a raw ICC
profile.

This also adds the build targets that we'll be using for other color
related structures in the near future. In particular, we will be adding a
color space structure that cannot be a full ICC profile (because they
are heavy, and sending them renderer->browser would be unsafe).

BUG= 622133 

Review-Url: https://codereview.chromium.org/2150013003
Cr-Commit-Position: refs/heads/master@{#406363}

[modify] https://crrev.com/e0d9f3857bedccbd50584c260d071b4ad8ee2202/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/e0d9f3857bedccbd50584c260d071b4ad8ee2202/content/common/BUILD.gn
[modify] https://crrev.com/e0d9f3857bedccbd50584c260d071b4ad8ee2202/content/common/view_messages.h
[modify] https://crrev.com/e0d9f3857bedccbd50584c260d071b4ad8ee2202/content/content_common.gypi
[modify] https://crrev.com/e0d9f3857bedccbd50584c260d071b4ad8ee2202/content/public/common/BUILD.gn
[modify] https://crrev.com/e0d9f3857bedccbd50584c260d071b4ad8ee2202/content/renderer/render_view_impl.cc
[modify] https://crrev.com/e0d9f3857bedccbd50584c260d071b4ad8ee2202/ui/gfx/color_space.h
[add] https://crrev.com/e0d9f3857bedccbd50584c260d071b4ad8ee2202/ui/gfx/ipc/color/BUILD.gn
[add] https://crrev.com/e0d9f3857bedccbd50584c260d071b4ad8ee2202/ui/gfx/ipc/color/OWNERS
[add] https://crrev.com/e0d9f3857bedccbd50584c260d071b4ad8ee2202/ui/gfx/ipc/color/gfx_ipc_color.gyp
[add] https://crrev.com/e0d9f3857bedccbd50584c260d071b4ad8ee2202/ui/gfx/ipc/color/gfx_ipc_color.gypi
[add] https://crrev.com/e0d9f3857bedccbd50584c260d071b4ad8ee2202/ui/gfx/ipc/color/gfx_ipc_color_export.h
[add] https://crrev.com/e0d9f3857bedccbd50584c260d071b4ad8ee2202/ui/gfx/ipc/color/gfx_param_traits.cc
[add] https://crrev.com/e0d9f3857bedccbd50584c260d071b4ad8ee2202/ui/gfx/ipc/color/gfx_param_traits.h
[add] https://crrev.com/e0d9f3857bedccbd50584c260d071b4ad8ee2202/ui/gfx/ipc/color/gfx_param_traits_macros.h
[modify] https://crrev.com/e0d9f3857bedccbd50584c260d071b4ad8ee2202/ui/gfx/ipc/geometry/gfx_param_traits.cc
[modify] https://crrev.com/e0d9f3857bedccbd50584c260d071b4ad8ee2202/ui/gfx/ipc/gfx_ipc.gyp
Project Member

Comment 21 by bugdroid1@chromium.org, Jul 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5

commit efdab1600b787e4e1f82fb05ae6a397d90a0d7b5
Author: ccameron <ccameron@chromium.org>
Date: Mon Jul 25 23:00:02 2016

Color: Separate ICCProfile and ColorSpace structures

Remove the extra effort being made to avoid replication of ICC profile
data across object instances. With the two separate structures, we will
always know when we have the "heavy" version.

Add plumbing to pass ColorSpace as part of cc::TransferableResource.

Note that the functionality to convert between ICCProfile and
ColorSpace is not present in this patch.

BUG= 622133 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2161293002
Cr-Commit-Position: refs/heads/master@{#407622}

[modify] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/cc/ipc/BUILD.gn
[modify] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/cc/ipc/cc_ipc.gyp
[modify] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/cc/ipc/cc_param_traits_macros.h
[modify] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/cc/resources/resource_provider.cc
[modify] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/cc/resources/resource_provider.h
[modify] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/cc/resources/texture_mailbox.h
[modify] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/cc/resources/transferable_resource.h
[modify] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/content/common/view_messages.h
[modify] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/content/renderer/render_view_impl.cc
[modify] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/gpu/ipc/client/gpu_memory_buffer_impl_io_surface.cc
[modify] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/gpu/ipc/client/gpu_memory_buffer_impl_io_surface.h
[modify] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/ui/gfx/BUILD.gn
[modify] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/ui/gfx/color_space.cc
[modify] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/ui/gfx/color_space.h
[modify] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/ui/gfx/gfx.gyp
[add] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/ui/gfx/icc_profile.cc
[add] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/ui/gfx/icc_profile.h
[rename] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/ui/gfx/icc_profile_mac.mm
[rename] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/ui/gfx/icc_profile_win.cc
[modify] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/ui/gfx/ipc/color/gfx_param_traits.cc
[modify] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/ui/gfx/ipc/color/gfx_param_traits.h
[modify] https://crrev.com/efdab1600b787e4e1f82fb05ae6a397d90a0d7b5/ui/gfx/ipc/color/gfx_param_traits_macros.h
Project Member

Comment 22 by bugdroid1@chromium.org, Jul 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f864d5f2f48598e2c53f1aa5986880ca8bfc31f1

commit f864d5f2f48598e2c53f1aa5986880ca8bfc31f1
Author: ccameron <ccameron@chromium.org>
Date: Tue Jul 26 19:44:34 2016

Video: Plumb media::VideoFrame color space to cc and GpuMemoryBuffer

In VideoResourceUpdater, populate the cc::TextureMailbox's color space
to get this through to the cc::GLRenderer, where it will be used in
compositing.

In GpuMemoryBufferVideoFramePool, specify the gfx::GpuMemoryBuffer's
color space for scanout after populating it.

BUG= 622133 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2169913003
Cr-Commit-Position: refs/heads/master@{#407882}

[modify] https://crrev.com/f864d5f2f48598e2c53f1aa5986880ca8bfc31f1/cc/resources/video_resource_updater.cc
[modify] https://crrev.com/f864d5f2f48598e2c53f1aa5986880ca8bfc31f1/media/base/video_frame.cc
[modify] https://crrev.com/f864d5f2f48598e2c53f1aa5986880ca8bfc31f1/media/base/video_frame.h
[modify] https://crrev.com/f864d5f2f48598e2c53f1aa5986880ca8bfc31f1/media/video/gpu_memory_buffer_video_frame_pool.cc
Project Member

Comment 25 by bugdroid1@chromium.org, Aug 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c289ee43b1fc399a703cdda029b3601fa7bb0ad7

commit c289ee43b1fc399a703cdda029b3601fa7bb0ad7
Author: hubbe <hubbe@chromium.org>
Date: Fri Aug 05 00:49:55 2016

ICC profile color translations

Uses QCMS to translate colors to/from ICC profile-based color spaces.

BUG= 622133 

Review-Url: https://codereview.chromium.org/2203213002
Cr-Commit-Position: refs/heads/master@{#409954}

[modify] https://crrev.com/c289ee43b1fc399a703cdda029b3601fa7bb0ad7/third_party/qcms/BUILD.gn
[modify] https://crrev.com/c289ee43b1fc399a703cdda029b3601fa7bb0ad7/third_party/qcms/qcms.gyp
[modify] https://crrev.com/c289ee43b1fc399a703cdda029b3601fa7bb0ad7/ui/gfx/BUILD.gn
[modify] https://crrev.com/c289ee43b1fc399a703cdda029b3601fa7bb0ad7/ui/gfx/DEPS
[modify] https://crrev.com/c289ee43b1fc399a703cdda029b3601fa7bb0ad7/ui/gfx/color_transform.cc
[modify] https://crrev.com/c289ee43b1fc399a703cdda029b3601fa7bb0ad7/ui/gfx/color_transform_unittest.cc
[modify] https://crrev.com/c289ee43b1fc399a703cdda029b3601fa7bb0ad7/ui/gfx/gfx.gyp
[modify] https://crrev.com/c289ee43b1fc399a703cdda029b3601fa7bb0ad7/ui/gfx/icc_profile.cc
[modify] https://crrev.com/c289ee43b1fc399a703cdda029b3601fa7bb0ad7/ui/gfx/icc_profile.h
[modify] https://crrev.com/c289ee43b1fc399a703cdda029b3601fa7bb0ad7/ui/gfx/icc_profile_mac.mm
[modify] https://crrev.com/c289ee43b1fc399a703cdda029b3601fa7bb0ad7/ui/gfx/icc_profile_win.cc

Comment 26 by reillyg@chromium.org, Aug 5 2016

Blockedon: 635042
Project Member

Comment 28 by bugdroid1@chromium.org, Aug 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af57af3079ddbb21be992e839023ff6e45ec6ef4

commit af57af3079ddbb21be992e839023ff6e45ec6ef4
Author: hubbe <hubbe@chromium.org>
Date: Thu Aug 11 10:42:32 2016

Video Color Managament

Creates a new class media::VideoColorSpace which can represent all h264 color spaces, we encode this into the metadata for a video frame and forward it all the way to gl_renderer.cc, where we use it to render the video correctly.

BUG= 622133 

Review-Url: https://codereview.chromium.org/2088273003
Cr-Commit-Position: refs/heads/master@{#411297}

[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/cc/BUILD.gn
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/cc/cc.gyp
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/cc/ipc/cc_param_traits.cc
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/cc/ipc/cc_param_traits_unittest.cc
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/cc/ipc/struct_traits_unittest.cc
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/cc/layers/video_layer_impl.cc
[add] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/cc/output/color_lut_cache.cc
[add] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/cc/output/color_lut_cache.h
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/cc/output/gl_renderer.cc
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/cc/output/gl_renderer.h
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/cc/output/gl_renderer_unittest.cc
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/cc/output/output_surface.cc
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/cc/output/output_surface.h
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/cc/output/renderer_pixeltest.cc
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/cc/output/shader.cc
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/cc/output/shader.h
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/cc/quads/draw_quad_unittest.cc
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/cc/quads/yuv_video_draw_quad.cc
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/cc/quads/yuv_video_draw_quad.h
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/cc/test/render_pass_test_utils.cc
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/media/base/media_switches.cc
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/media/base/media_switches.h
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/media/base/video_frame.cc
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/media/base/video_frame.h
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/media/media.gyp
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/media/video/gpu_memory_buffer_video_frame_pool.cc
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/ui/gfx/color_space.cc
[modify] https://crrev.com/af57af3079ddbb21be992e839023ff6e45ec6ef4/ui/gfx/color_space.h

Comment 29 by pdk...@gmail.com, Aug 11 2016 

Just want to make sure this temporarily reverted CL hasn't been forgotten, as it's already useful today.

https://codereview.chromium.org/2115103002/
Project Member

Comment 30 by bugdroid1@chromium.org, Aug 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06a769dce6003de32a7b510c2d13874a440ac28e

commit 06a769dce6003de32a7b510c2d13874a440ac28e
Author: raphael.kubo.da.costa <raphael.kubo.da.costa@intel.com>
Date: Fri Aug 12 22:24:40 2016

IWYU: ffloor(3) needs <cmath>.

This fixes the build with recent libstdc++ versions (mine is at 6.1.1),
which do not implicitly include <cmath> and cause the build to fail like
this after commit af57af3079ddbb21be992e839023ff6e45ec6ef4 ("Video Color
Managament"):

../cc/output/color_lut_cache.cc:36:46: error: use of undeclared identifier 'floorf'

R=hubbe@chromium.org,ccameron@chromium.org,danakj@chromium.org
BUG= 622133 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2238243002
Cr-Commit-Position: refs/heads/master@{#411798}

[modify] https://crrev.com/06a769dce6003de32a7b510c2d13874a440ac28e/cc/output/color_lut_cache.cc
Project Member

Comment 31 by bugdroid1@chromium.org, Aug 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26c4111e54e3f8c0636480ee7b309f588be13b94

commit 26c4111e54e3f8c0636480ee7b309f588be13b94
Author: hubbe <hubbe@chromium.org>
Date: Sat Aug 13 23:01:24 2016

hi10p+LUT bugfix

BUG= 622133 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2237003007
Cr-Commit-Position: refs/heads/master@{#411903}

[modify] https://crrev.com/26c4111e54e3f8c0636480ee7b309f588be13b94/cc/output/shader.cc
Project Member

Comment 33 by bugdroid1@chromium.org, Sep 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09d613c9521618057602b7fe451da352ad1051b5

commit 09d613c9521618057602b7fe451da352ad1051b5
Author: hubbe <hubbe@chromium.org>
Date: Fri Sep 02 18:41:04 2016

Support for retreiving the monitor color space on X11.

BUG= 622133 

Committed: https://crrev.com/b0df9e3fcbca19d2a625fa274172bd3be4116261
Review-Url: https://codereview.chromium.org/2115103002
Cr-Original-Commit-Position: refs/heads/master@{#403958}
Cr-Commit-Position: refs/heads/master@{#416305}

[modify] https://crrev.com/09d613c9521618057602b7fe451da352ad1051b5/ui/gfx/BUILD.gn
[modify] https://crrev.com/09d613c9521618057602b7fe451da352ad1051b5/ui/gfx/icc_profile.cc
[add] https://crrev.com/09d613c9521618057602b7fe451da352ad1051b5/ui/gfx/icc_profile_x11.cc
Project Member

Comment 35 by bugdroid1@chromium.org, Oct 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b213e899246050d799ccb6df0e40837b619da8fb

commit b213e899246050d799ccb6df0e40837b619da8fb
Author: hubbe <hubbe@chromium.org>
Date: Tue Oct 04 21:39:59 2016

Attach color space information to hardware decoded NV12 video frames.

This extracts the color information from the h264 stream and attaches
it to the video frame. Currently this is only done if the result is
NV12 as we don't have the code yet to do it for RGB frames.

BUG= 622133 ,  647725 

Review-Url: https://codereview.chromium.org/2345123002
Cr-Commit-Position: refs/heads/master@{#422942}

[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/content/renderer/pepper/video_decoder_shim.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/filters/gpu_video_decoder.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/filters/h264_parser.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/filters/h264_parser.h
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/dxva_picture_buffer_win.h
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/dxva_video_decode_accelerator_win.h
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/fake_video_decode_accelerator.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/ipc/client/BUILD.gn
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/ipc/client/gpu_video_decode_accelerator_host.h
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/ipc/common/media_messages.h
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/ipc/service/gpu_video_decode_accelerator.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/v4l2_slice_video_decode_accelerator.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/v4l2_video_decode_accelerator.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/vt_video_decode_accelerator_mac.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/video/picture.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/video/picture.h
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/ui/gfx/ipc/color/gfx_param_traits_macros.h
Project Member

Comment 36 by bugdroid1@chromium.org, Oct 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5d6ad8849efdb60d7d42d540997b36a144b8797

commit c5d6ad8849efdb60d7d42d540997b36a144b8797
Author: hubbe <hubbe@chromium.org>
Date: Thu Oct 06 18:47:33 2016

Revert of Attach color space information to hardware decoded NV12 video frames. (patchset #11 id:200001 of https://codereview.chromium.org/2345123002/ )

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=653388

Original issue's description:
> Attach color space information to hardware decoded NV12 video frames.
>
> This extracts the color information from the h264 stream and attaches
> it to the video frame. Currently this is only done if the result is
> NV12 as we don't have the code yet to do it for RGB frames.
>
> BUG= 622133 ,  647725 
>
> Committed: https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb
> Cr-Commit-Position: refs/heads/master@{#422942}

TBR=sandersd@chromium.org,posciak@chromium.org,jbauman@chromium.org,bbudge@chromium.org,tsepez@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 622133 ,  647725 

Review-Url: https://codereview.chromium.org/2399133002
Cr-Commit-Position: refs/heads/master@{#423605}

[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/content/renderer/pepper/video_decoder_shim.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/filters/gpu_video_decoder.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/filters/h264_parser.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/filters/h264_parser.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/dxva_picture_buffer_win.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/dxva_video_decode_accelerator_win.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/fake_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/client/BUILD.gn
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/client/gpu_video_decode_accelerator_host.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/common/media_messages.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/service/gpu_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/v4l2_slice_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/v4l2_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/vt_video_decode_accelerator_mac.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/video/picture.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/video/picture.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/ui/gfx/ipc/color/gfx_param_traits_macros.h
Project Member

Comment 37 by bugdroid1@chromium.org, Oct 6 2016

Labels: merge-merged-2882
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a65782c053825f9f287b1c5d09fc9804aa8af451

commit a65782c053825f9f287b1c5d09fc9804aa8af451
Author: Fredrik Hubinette <hubbe@google.com>
Date: Thu Oct 06 18:59:06 2016

Revert of Attach color space information to hardware decoded NV12 video frames. (patchset #11 id:200001 of https://codereview.chromium.org/2345123002/ )

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=653388

Original issue's description:
> Attach color space information to hardware decoded NV12 video frames.
>
> This extracts the color information from the h264 stream and attaches
> it to the video frame. Currently this is only done if the result is
> NV12 as we don't have the code yet to do it for RGB frames.
>
> BUG= 622133 ,  647725 
>
> Committed: https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb
> Cr-Commit-Position: refs/heads/master@{#422942}

TBR=sandersd@chromium.org,posciak@chromium.org,jbauman@chromium.org,bbudge@chromium.org,tsepez@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 622133 ,  647725 

Review-Url: https://codereview.chromium.org/2399133002
Cr-Commit-Position: refs/heads/master@{#423605}
(cherry picked from commit c5d6ad8849efdb60d7d42d540997b36a144b8797)

Review URL: https://codereview.chromium.org/2392343007 .

Cr-Commit-Position: refs/branch-heads/2882@{#5}
Cr-Branched-From: 03e86d027151639ad79c2074199f4e75beab0674-refs/heads/master@{#423378}

[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/content/renderer/pepper/video_decoder_shim.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/filters/gpu_video_decoder.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/filters/h264_parser.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/filters/h264_parser.h
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/dxva_picture_buffer_win.h
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/dxva_video_decode_accelerator_win.h
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/fake_video_decode_accelerator.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/ipc/client/BUILD.gn
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/ipc/client/gpu_video_decode_accelerator_host.h
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/ipc/common/media_messages.h
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/ipc/service/gpu_video_decode_accelerator.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/v4l2_slice_video_decode_accelerator.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/v4l2_video_decode_accelerator.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/vt_video_decode_accelerator_mac.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/video/picture.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/video/picture.h
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/ui/gfx/ipc/color/gfx_param_traits_macros.h
Project Member

Comment 38 by bugdroid1@chromium.org, Oct 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f33dc1134c8c48a11280e8f62c96d749c4caf4a0

commit f33dc1134c8c48a11280e8f62c96d749c4caf4a0
Author: hubbe <hubbe@chromium.org>
Date: Fri Oct 07 01:40:03 2016

Attach color space information to hardware decoded NV12 video frames.

This extracts the color information from the h264 stream and attaches
it to the video frame. Currently this is only done if the result is
NV12 as we don't have the code yet to do it for RGB frames.

BUG= 622133 ,  647725 

Committed: https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb
Review-Url: https://codereview.chromium.org/2345123002
Cr-Original-Commit-Position: refs/heads/master@{#422942}
Cr-Commit-Position: refs/heads/master@{#423776}

[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/content/renderer/pepper/video_decoder_shim.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/filters/gpu_video_decoder.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/filters/h264_parser.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/filters/h264_parser.h
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/dxva_picture_buffer_win.h
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/dxva_video_decode_accelerator_win.h
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/fake_video_decode_accelerator.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/ipc/client/BUILD.gn
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/ipc/client/gpu_video_decode_accelerator_host.h
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/ipc/common/media_messages.h
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/ipc/service/gpu_video_decode_accelerator.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/v4l2_slice_video_decode_accelerator.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/v4l2_video_decode_accelerator.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/vt_video_decode_accelerator_mac.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/video/picture.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/video/picture.h
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/ui/gfx/ipc/color/gfx_param_traits_macros.h
Project Member

Comment 39 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5d6ad8849efdb60d7d42d540997b36a144b8797

commit c5d6ad8849efdb60d7d42d540997b36a144b8797
Author: hubbe <hubbe@chromium.org>
Date: Thu Oct 06 18:47:33 2016

Revert of Attach color space information to hardware decoded NV12 video frames. (patchset #11 id:200001 of https://codereview.chromium.org/2345123002/ )

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=653388

Original issue's description:
> Attach color space information to hardware decoded NV12 video frames.
>
> This extracts the color information from the h264 stream and attaches
> it to the video frame. Currently this is only done if the result is
> NV12 as we don't have the code yet to do it for RGB frames.
>
> BUG= 622133 ,  647725 
>
> Committed: https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb
> Cr-Commit-Position: refs/heads/master@{#422942}

TBR=sandersd@chromium.org,posciak@chromium.org,jbauman@chromium.org,bbudge@chromium.org,tsepez@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 622133 ,  647725 

Review-Url: https://codereview.chromium.org/2399133002
Cr-Commit-Position: refs/heads/master@{#423605}

[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/content/renderer/pepper/video_decoder_shim.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/filters/gpu_video_decoder.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/filters/h264_parser.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/filters/h264_parser.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/dxva_picture_buffer_win.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/dxva_video_decode_accelerator_win.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/fake_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/client/BUILD.gn
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/client/gpu_video_decode_accelerator_host.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/common/media_messages.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/service/gpu_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/v4l2_slice_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/v4l2_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/vt_video_decode_accelerator_mac.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/video/picture.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/video/picture.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/ui/gfx/ipc/color/gfx_param_traits_macros.h

Comment 40 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Comment 41 by ccameron@chromium.org, Dec 20 2016

Blockedon: 676054

Comment 42 by ccameron@chromium.org, May 3 2017

Status: Fixed (was: Assigned)
Marking as fixed (at least WRT the Chrome compositor).
►

Sign in to add a comment