gles2_conform_test_windowless has GYP variables in the sources |
||||
Issue description
How to repro (Windows):
> gn gen out\gn_test
is_component_build=true
internal_gles2_conform_tests=true
enable_nacl=false
is_win_fastlink=true
> gn gen out\gn_test --ide=vs2015 --filters=//gpu/gles2_conform_support/*
Generating Visual Studio projects took 122ms
Done. Wrote 4067 targets from 908 files in 2583ms
Open out\gn_test\all.sln in Visual Studio 2015.. I see this error:
...\gles2_conform_support\gles2_conform_test_windowless.vcxproj : error : Unable to read the project file "gles2_conform_test_windowless.vcxproj".
...\gles2_conform_support\gles2_conform_test_windowless.vcxproj(286,61): The project file could not be loaded. '<', hexadecimal value 0x3C, is an invalid attribute character. Line 286, position 61.
Looking in the vcxproj file:
<None Include="../../../../../gpu/gles2_conform_support/<@(gl2_extension_test_sources)" />
<None Include="../../../../../gpu/gles2_conform_support/<@(gl2_fixed_test_sources)" />
<None Include="../../../../../gpu/gles2_conform_support/<@(gl2_test_sources)" />
Seems they were not expanded from the gypi lists.
,
Jun 22 2016
This has nothing to do with the generator, these are in the sources list. GN doesn't know anything about GYP variables. These come from gtf_es_sources from gles2_conform.gypi
,
Jun 22 2016
Ah, I think I understand. So the fix is just to fix the source list and possibly fix the gyp as well. Do you know when we are planning to remove the gyp? I think I can try to fix this.
,
Jun 22 2016
We don't have an ETA to remove the GYP files yet. We're hoping to ship all GN-based builds in M-53 (which branches next week), so I expect we'll be removing GYP not too long after that, but it might be a month or two.
,
Jun 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0096cb016cc6bfd8cf1a0cd51501504ba547bfff commit 0096cb016cc6bfd8cf1a0cd51501504ba547bfff Author: jmadill <jmadill@chromium.org> Date: Wed Jun 22 21:42:26 2016 gles2_conform: Fix sources list in GN/gypi. The sources list in the gypi included other lists of sources, which the GN files don't know how to parse recursively. BUG= 622108 R=piman@chromium.org,brettw@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2085413002 Cr-Commit-Position: refs/heads/master@{#401415} [modify] https://crrev.com/0096cb016cc6bfd8cf1a0cd51501504ba547bfff/gpu/gles2_conform_support/gles2_conform.gypi [modify] https://crrev.com/0096cb016cc6bfd8cf1a0cd51501504ba547bfff/gpu/gles2_conform_support/gles2_conform_test.gyp
,
Jul 5 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dpranke@chromium.org
, Jun 21 2016Components: Build
Owner: ----
Status: Untriaged (was: Assigned)