New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622105 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

src/platform/dev tests aren't run.

Project Member Reported by dgarr...@chromium.org, Jun 21 2016

Issue description

src/platform/dev/run_unittests isn't run as part of our build.

Obviously, the tests were broken, and nobody noticed them until I tried to verify a change.

Running them in the build appears to need an ebuild, but there isn't one associated with src/platform/dev.

 
Owner: dgarr...@chromium.org
Status: Started (was: Untriaged)

Comment 2 by autumn@chromium.org, Jun 28 2016

Labels: -current-issue
Cc: dgarr...@chromium.org
 Issue 624566  has been merged into this issue.
This CL will enable the tests on the builders, but it can't be safely submitted until the tests have a "--network" option and stop running network heavy tests if it's not present.

https://chromium-review.googlesource.com/#/c/354772/
Owner: nxia@chromium.org
Here is a smallish project in a different part of our code.

Basically, add --network support to src/platform/dev/run_unittests (similar to chromite/cbuildbot/run_tests), and mark the unittests that use the network to require it to be set.

Then we submit my CL from #4.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c531aca47c39d5f6c33d85bee819a9a2d43c8ced

commit c531aca47c39d5f6c33d85bee819a9a2d43c8ced
Author: Don Garrett <dgarrett@google.com>
Date: Wed Jun 22 01:41:14 2016

devserver: Enable devserver unittests.

We never run the devserver unittests in the build, so add them to the
ebuild for it.

CQ-DEPEND=CL:354572
BUG= chromium:622105 
TEST=FEATURES=test emerge-lumpy devserver

Change-Id: I9357f3723d6690aefae86851ec2dc6375511690a
Reviewed-on: https://chromium-review.googlesource.com/354772
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/c531aca47c39d5f6c33d85bee819a9a2d43c8ced/chromeos-base/devserver/devserver-9999.ebuild

Status: Fixed (was: Started)

Comment 8 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 9 by dchan@chromium.org, Oct 10 2016

Labels: -VerifyIn-55

Comment 10 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 11 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 12 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 13 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 14 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 16 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment