WebRtcGetUserMediaBrowserTests flaky and timing out under Dr. Memory |
|||
Issue descriptionAt least two tests are experiencing flaky timeouts when run on the Dr. Memory bots: WebRtcGetUserMediaBrowserTest.AudioInIFrameAndCloseInSuccessCb WebRtcGetUserMediaBrowserTest.GetUserMediaWithMandatorySourceID This may be similar to issue 577796 . https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20Browser%20%28DrMemory%20full%29%20%283%29/builds/7836/steps/memory%20test%3A%20content_browsertests_6/logs/stdio https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20Browser%20%28DrMemory%20full%29%20%285%29/builds/8399/steps/memory%20test%3A%20content_browsertests_8/logs/stdio
,
Jun 23 2016
perkj, could you take a look? The tests gets stuck for 40-ish seconds. The tests normally takes sub-second time to execute so I don't think the problem is that the tests are merely slow.
Could there be a race here?
var iframe = document.createElement('iframe');
iframe.onload = onIframeLoaded;
document.body.appendChild(iframe);
Could it be that onload gets called before we can assign the callback on a slow bot? Or is something in onIframeLoaded wrong?
,
Jul 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5225533743d7b722480e20fe5e2627fd04893dea commit 5225533743d7b722480e20fe5e2627fd04893dea Author: perkj <perkj@chromium.org> Date: Wed Jul 06 14:22:40 2016 Restructure and add logs to WebRtcGetUserMediaBrowserTest.GetUserMediaWithMandatorySourceID BUG= 625024 , 622085 Review-Url: https://codereview.chromium.org/2122153002 Cr-Commit-Position: refs/heads/master@{#403903} [modify] https://crrev.com/5225533743d7b722480e20fe5e2627fd04893dea/content/browser/media/webrtc/webrtc_getusermedia_browsertest.cc [modify] https://crrev.com/5225533743d7b722480e20fe5e2627fd04893dea/content/test/data/media/getusermedia.html [modify] https://crrev.com/5225533743d7b722480e20fe5e2627fd04893dea/content/test/data/media/webrtc_test_utilities.js
,
Aug 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8116d5762db75f69882073b085aa73eac4423c9 commit b8116d5762db75f69882073b085aa73eac4423c9 Author: perkj <perkj@chromium.org> Date: Tue Aug 16 08:03:29 2016 Revert of Disable WebRTC tests that are flaky under Dr. Memory. (patchset #1 id:1 of https://codereview.chromium.org/2081423003/ ) Reason for revert: I have tested both tests a couple of time under dr memory full locally without seeing them fail or time out. WebRtcGetUserMediaBrowserTest.GetUserMediaWithMandatorySourceID has been updated and not seemed to flake since https://codereview.chromium.org/2122153002/ was landed. Original issue's description: > Disable WebRTC tests that are flaky under Dr. Memory. > > WebRtcGetUserMediaBrowserTest.AudioInIFrameAndCloseInSuccessCb > WebRtcGetUserMediaBrowserTest.GetUserMediaWithMandatorySourceID > > BUG= 622085 > TBR=mcasas@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/3d07cfa01225f3e70ca9a2f94ba9f85283f12969 TBR=mcasas@chromium.org,reillyg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 622085 Review-Url: https://codereview.chromium.org/2130783002 Cr-Commit-Position: refs/heads/master@{#412190} [modify] https://crrev.com/b8116d5762db75f69882073b085aa73eac4423c9/tools/valgrind/gtest_exclude/content_browsertests.gtest-drmemory.txt
,
Sep 14 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jun 21 2016