New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622083 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Screenshot contents are empty for some windows

Project Member Reported by sdantul...@chromium.org, Jun 21 2016

Issue description


Google Chrome	53.0.2773.0 (Official Build) dev (64-bit)
Revision	ced2fcee2c85702055d028f4e3e48c5a75a7e41c-refs/heads/master@{#400610}
Platform	8481.0.0 (Official Build) dev-channel link

What steps will reproduce the problem?
1. Open browser,Files app and uber tray
2. Take screenshot

What do you see instead?
Files app and uber tray contents are empty

Attached screenshot.

Issue not seen on peppy.
 
Screenshot 2016-06-21 at 3.20.08 PM.png
2.7 MB View Download
Owner: warx@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by warx@chromium.org, Jul 1 2016

Cc: osh...@chromium.org weiliangc@chromium.org
Run bisect and find first known bad CL: 
https://chromium.googlesource.com/chromium/src/+log/5562d23c289646cfd767d5c2597ad87fc34866e1..de7e0c3e9bf26b7c3bad40c6aa8883eb47159989


Comment 3 by warx@chromium.org, Jul 1 2016

Owner: weiliangc@chromium.org
Cc: afakhry@chromium.org
 Issue 625029  has been merged into this issue.
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 3 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: ajuma@chromium.org enne@chromium.org
Cannot repro on linux-cros build, but can repro on cros machine. Taking a closer look now.
Also my files window still visible in screenshot, the user tray is however blank.
Only repro on high-dpi, doing that with linux-cros build repros.
So with device scale factor, while calculation clip and transforming the rect, scale got applied twice, and the offset that should be cancelled out transform back and forth didn't. The rect with offset intersecting with layer bounds returns empty rect. I have a CL for this. 
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/296dd9f02b09445ad5976396a86c00ff3181c253

commit 296dd9f02b09445ad5976396a86c00ff3181c253
Author: weiliangc <weiliangc@chromium.org>
Date: Tue Jul 05 14:59:51 2016

cc: Fix non root copy request visible rect in HighDPI

Before while transform clip into layer space, incorrectly used wrong
helper function and applied device scale twice. Create correct helper
function and add unittest.

BUG= 622083 
R=ajuma
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2117183002
Cr-Commit-Position: refs/heads/master@{#403782}

[modify] https://crrev.com/296dd9f02b09445ad5976396a86c00ff3181c253/cc/test/layer_tree_host_common_test.cc
[modify] https://crrev.com/296dd9f02b09445ad5976396a86c00ff3181c253/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/296dd9f02b09445ad5976396a86c00ff3181c253/cc/trees/layer_tree_host_common_unittest.cc

Cc: tdander...@chromium.org varkha@chromium.org sdantul...@chromium.org
 Issue 626841  has been merged into this issue.
#11, is there more work required for this? Also should the fix be merged in M-53? 
Labels: Merge-Request-53
The fix is done and is in Canary. No more work is needed. Adding merge request to M53.

Comment 15 by dimu@google.com, Jul 11 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 13 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6196d6ec443cd6290a1eff911532d62b52f56d38

commit 6196d6ec443cd6290a1eff911532d62b52f56d38
Author: Weiliang Chen <weiliangc@chromium.org>
Date: Wed Jul 13 20:00:53 2016

cc: Fix non root copy request visible rect in HighDPI

Before while transform clip into layer space, incorrectly used wrong
helper function and applied device scale twice. Create correct helper
function and add unittest.

BUG= 622083 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2117183002
Cr-Commit-Position: refs/heads/master@{#403782}
(cherry picked from commit 296dd9f02b09445ad5976396a86c00ff3181c253)

Review URL: https://codereview.chromium.org/2140313004 .

Cr-Commit-Position: refs/branch-heads/2785@{#106}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/6196d6ec443cd6290a1eff911532d62b52f56d38/cc/test/layer_tree_host_common_test.cc
[modify] https://crrev.com/6196d6ec443cd6290a1eff911532d62b52f56d38/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/6196d6ec443cd6290a1eff911532d62b52f56d38/cc/trees/layer_tree_host_common_unittest.cc

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Chrome OS  54.0.2824.0/8696.0.0 samus

Sign in to add a comment