New issue
Advanced search Search tips

Issue 622082 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 645776



Sign in to add a comment

Clamp automation start time to current time

Project Member Reported by rtoy@chromium.org, Jun 21 2016

Issue description

The WebAudio spec now says that if the automation time is before the current time, it is clamped to the current time.

See issue https://github.com/WebAudio/web-audio-api/issues/713
Resolved by https://github.com/WebAudio/web-audio-api/pull/849
 

Comment 1 by rtoy@chromium.org, Sep 13 2016

Blocking: 645776

Comment 2 by rtoy@chromium.org, Sep 13 2016

Owner: rtoy@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abc380c92e7b096672618c9cbad28dadf46f1df5

commit abc380c92e7b096672618c9cbad28dadf46f1df5
Author: rtoy <rtoy@chromium.org>
Date: Thu Nov 10 20:14:02 2016

Implement clamping of AudioParam time.

The specified time when creating an AudioParam is clamped to the
currentTime.  Because of the thread hop, the clamping needs to be done
on the audio thread, not the main thread, which is always behind the
audio thread.

BUG= 622082 
TEST=audioparam-clamp-time-to-current-time.html

Review-Url: https://codereview.chromium.org/2391893005
Cr-Commit-Position: refs/heads/master@{#431335}

[add] https://crrev.com/abc380c92e7b096672618c9cbad28dadf46f1df5/third_party/WebKit/LayoutTests/webaudio/audioparam-clamp-time-to-current-time.html
[modify] https://crrev.com/abc380c92e7b096672618c9cbad28dadf46f1df5/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp
[modify] https://crrev.com/abc380c92e7b096672618c9cbad28dadf46f1df5/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h

Comment 4 by rtoy@chromium.org, Nov 15 2016

Status: Fixed (was: Started)

Sign in to add a comment