Missing dependency from content/public/common on public blink mojom |
||||
Issue descriptioncontent/public/common/common_param_traits.h exposes a mojom-generated header from third_party/WebKit. This means the target should have a public_deps (GN) and a hard dependency (gyp) on the appropriate blink target, neither of which is the case. This leads to build flake as in: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS
,
Jun 22 2016
,
Jun 22 2016
This seems to break shared library gyp builds, due to multiple definitions of mojo-generated code when linking libcontent. I think this target should depend on the wrapper library target (mojo_bindings) rather than mojo_bindings_mojom. Proposed fix: https://codereview.chromium.org/2088163002/
,
Jun 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7279505c6d3be5eb212e81a3b769d88e76d413e7 commit 7279505c6d3be5eb212e81a3b769d88e76d413e7 Author: mostynb <mostynb@opera.com> Date: Wed Jun 22 08:36:40 2016 content/public/common should depend on the mojo_bindings target Rather than the mojo_bindings_mojom target, which exports sources, and causes multiple definition errors in component builds. Followup to https://codereview.chromium.org/2089823002 BUG= 622076 TBR=jam@chromium.org,rockot@chromium.org Review-Url: https://codereview.chromium.org/2088163002 Cr-Commit-Position: refs/heads/master@{#401230} [modify] https://crrev.com/7279505c6d3be5eb212e81a3b769d88e76d413e7/content/content_common.gypi
,
Jun 23 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Jun 22 2016