New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622076 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
please use my google.com address
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Missing dependency from content/public/common on public blink mojom

Project Member Reported by roc...@chromium.org, Jun 21 2016

Issue description

content/public/common/common_param_traits.h exposes a mojom-generated header from third_party/WebKit. This means the target should have a public_deps (GN) and a hard dependency (gyp) on the appropriate blink target, neither of which is the case. This leads to build flake as in:

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8ea5fa23b6d85b34ffa5db9379155e7ab0ea286

commit a8ea5fa23b6d85b34ffa5db9379155e7ab0ea286
Author: rockot <rockot@chromium.org>
Date: Wed Jun 22 02:51:39 2016

Fix missing dependency for content/public/common on blink mojom

content/public/common exposes generated headers from this target
through its own headers but this dependency was not properly
expressed in either GN or GYP rules.

Fixed.

BUG= 622076 
TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2089823002
Cr-Commit-Position: refs/heads/master@{#401182}

[modify] https://crrev.com/a8ea5fa23b6d85b34ffa5db9379155e7ab0ea286/content/content_common.gypi
[modify] https://crrev.com/a8ea5fa23b6d85b34ffa5db9379155e7ab0ea286/content/public/common/BUILD.gn

Comment 2 by roc...@chromium.org, Jun 22 2016

Status: Fixed (was: Started)

Comment 3 by most...@opera.com, Jun 22 2016

Cc: most...@opera.com
Status: Started (was: Fixed)
This seems to break shared library gyp builds, due to multiple definitions of mojo-generated code when linking libcontent.  I think this target should depend on the wrapper library target (mojo_bindings) rather than mojo_bindings_mojom.

Proposed fix: https://codereview.chromium.org/2088163002/
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7279505c6d3be5eb212e81a3b769d88e76d413e7

commit 7279505c6d3be5eb212e81a3b769d88e76d413e7
Author: mostynb <mostynb@opera.com>
Date: Wed Jun 22 08:36:40 2016

content/public/common should depend on the mojo_bindings target

Rather than the mojo_bindings_mojom target, which exports sources, and
causes multiple definition errors in component builds.

Followup to https://codereview.chromium.org/2089823002

BUG= 622076 
TBR=jam@chromium.org,rockot@chromium.org

Review-Url: https://codereview.chromium.org/2088163002
Cr-Commit-Position: refs/heads/master@{#401230}

[modify] https://crrev.com/7279505c6d3be5eb212e81a3b769d88e76d413e7/content/content_common.gypi

Comment 5 by roc...@chromium.org, Jun 23 2016

Status: Fixed (was: Started)

Sign in to add a comment