New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622074 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

CrSearchFieldBehavior, placeholder not cleared when pasting text.

Project Member Reported by dpa...@chromium.org, Jun 21 2016

Issue description

Repro steps:
1) Copy some text to the system's clipboard.
2) Navigate to chrome://history
3) Right click within the search text field and paste.

The text is placed on top of the placeholder text (see screenshot). Also clicking "x" does nothing until a left click is performed within the textbox.

This is currently affecting MD History, but it soon also affect MD Settings (https://codereview.chromium.org/2064013002).
 
cr_search_bug.png
49.6 KB View Download
Cc: -tsergeant@chromium.org
Components: UI>Browser>History
Owner: tsergeant@chromium.org
Status: Assigned (was: Untriaged)
Cc: dpa...@chromium.org
Labels: Hotlist-MD-Settings-SearchBox
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b28158033e882c541f6ff3dc0111b94f59a2ed0

commit 7b28158033e882c541f6ff3dc0111b94f59a2ed0
Author: tsergeant <tsergeant@chromium.org>
Date: Thu Jun 23 02:54:00 2016

MD Search Field: Properly respond to external changes to search value.

Ensures that when the search value is changed by something other than
direct typing the search field will still open correctly. This fixes
issues with dragging or pasting text into the input field.

BUG= 616740 , 618633 , 622074 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2090513002
Cr-Commit-Position: refs/heads/master@{#401527}

[modify] https://crrev.com/7b28158033e882c541f6ff3dc0111b94f59a2ed0/chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js
[modify] https://crrev.com/7b28158033e882c541f6ff3dc0111b94f59a2ed0/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js
[modify] https://crrev.com/7b28158033e882c541f6ff3dc0111b94f59a2ed0/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html
[modify] https://crrev.com/7b28158033e882c541f6ff3dc0111b94f59a2ed0/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js

Status: Fixed (was: Started)

Sign in to add a comment