New issue
Advanced search Search tips

Issue 622072 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature

Blocking:
issue 616244



Sign in to add a comment

Popups blocking should be implemented in chrome// not in web//

Project Member Reported by eugene...@chromium.org, Jun 21 2016

Issue description

To mirror content// we should delegate popups handling to WebStateDelegate and
ios/web/web_state/blocked_popup_info.h should not be a part of web//
 
Labels: -Type-Bug -Pri-2 Pri-3 Type-Feature
Owner: eugene...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91cfb3ad9a9b9502aed2f9bc76c5d3cc96105f22

commit 91cfb3ad9a9b9502aed2f9bc76c5d3cc96105f22
Author: eugenebut <eugenebut@chromium.org>
Date: Tue Feb 21 16:40:31 2017

Refactored callbacks for opening a new window.

This CL replaces 4 callbacks:
 webPageOrderedOpen:referrer:windowName:inBackground:
 webPageOrderedOpen
 webController:shouldBlockPopupWithURL:sourceURL:
 webController:didBlockPopup:

with a single callback:
 webController:createWebControllerForURL:openerURL:initiatedByUser:

This makes ios code more similar to other platforms where windows
are open via single WebContentsDelegate::AddNewContents callback
and all popup blocking logic lives in chrome layer.

This is a precursory CL to move window opening callback to
WebStateDelegate.

BUG= 622072 , 674991 

Review-Url: https://codereview.chromium.org/2692803004
Cr-Commit-Position: refs/heads/master@{#451778}

[modify] https://crrev.com/91cfb3ad9a9b9502aed2f9bc76c5d3cc96105f22/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/91cfb3ad9a9b9502aed2f9bc76c5d3cc96105f22/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/91cfb3ad9a9b9502aed2f9bc76c5d3cc96105f22/ios/web/public/web_state/ui/crw_web_delegate.h
[modify] https://crrev.com/91cfb3ad9a9b9502aed2f9bc76c5d3cc96105f22/ios/web/web_state/js/resources/core.js
[modify] https://crrev.com/91cfb3ad9a9b9502aed2f9bc76c5d3cc96105f22/ios/web/web_state/ui/crw_web_controller.mm
[modify] https://crrev.com/91cfb3ad9a9b9502aed2f9bc76c5d3cc96105f22/ios/web/web_state/ui/crw_web_controller_unittest.mm

Labels: -Restrict-View-Google
Status: Started (was: Assigned)
Status: Fixed (was: Started)

Sign in to add a comment