Popups blocking should be implemented in chrome// not in web// |
||||
Issue descriptionTo mirror content// we should delegate popups handling to WebStateDelegate and ios/web/web_state/blocked_popup_info.h should not be a part of web//
,
Feb 13 2017
,
Feb 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91cfb3ad9a9b9502aed2f9bc76c5d3cc96105f22 commit 91cfb3ad9a9b9502aed2f9bc76c5d3cc96105f22 Author: eugenebut <eugenebut@chromium.org> Date: Tue Feb 21 16:40:31 2017 Refactored callbacks for opening a new window. This CL replaces 4 callbacks: webPageOrderedOpen:referrer:windowName:inBackground: webPageOrderedOpen webController:shouldBlockPopupWithURL:sourceURL: webController:didBlockPopup: with a single callback: webController:createWebControllerForURL:openerURL:initiatedByUser: This makes ios code more similar to other platforms where windows are open via single WebContentsDelegate::AddNewContents callback and all popup blocking logic lives in chrome layer. This is a precursory CL to move window opening callback to WebStateDelegate. BUG= 622072 , 674991 Review-Url: https://codereview.chromium.org/2692803004 Cr-Commit-Position: refs/heads/master@{#451778} [modify] https://crrev.com/91cfb3ad9a9b9502aed2f9bc76c5d3cc96105f22/ios/chrome/browser/tabs/tab.mm [modify] https://crrev.com/91cfb3ad9a9b9502aed2f9bc76c5d3cc96105f22/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/91cfb3ad9a9b9502aed2f9bc76c5d3cc96105f22/ios/web/public/web_state/ui/crw_web_delegate.h [modify] https://crrev.com/91cfb3ad9a9b9502aed2f9bc76c5d3cc96105f22/ios/web/web_state/js/resources/core.js [modify] https://crrev.com/91cfb3ad9a9b9502aed2f9bc76c5d3cc96105f22/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/91cfb3ad9a9b9502aed2f9bc76c5d3cc96105f22/ios/web/web_state/ui/crw_web_controller_unittest.mm
,
Mar 1 2017
,
Mar 3 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by eugene...@chromium.org
, Aug 24 2016