Clear SSLClientSessionCache on low memory notifications |
||
Issue descriptionThis cache can be as large as several MB.
,
Jun 22 2016
I don't understand why you say that these numbers come from Chrome for Android? I don't see any android-specific config getting set? I am also pretty confident no one tuned this for the first release of Chrome for Android.
,
Jun 22 2016
The current limits were added in https://codereview.chromium.org/89623002, I believe, by a member of the Chrome for Android team. Linked bug mentions Android crashes.
,
Jun 23 2016
So, I think these numbers are shared between desktop and mobile. There was a refactoring done by someone on the mobile team, but it was done to fix a crash through cleaner structure. I don't think any performance testing was done back then.
,
Jul 7 2016
Question - I haven't figured out how to receive low memory notifications. Do you have any examples available? Or is there a certain class that is in charge of this?
,
Jul 7 2016
Take a look at base/memory/memory_pressure_listener.h
,
Jul 8 2016
thank you!
,
Jul 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90e6f5527236b01e687e65722b257e884fc7f1b6 commit 90e6f5527236b01e687e65722b257e884fc7f1b6 Author: maksim.sisov <maksim.sisov@intel.com> Date: Mon Jul 11 07:12:35 2016 Clear SSLClientSessionCache on low memory notifications. There are two cases when cache is flushed: 1) MEMORY_PRESSURE_LEVEL_MODERATE: flush expired sessions only. 2) MEMORY_PRESSURE_LEVEL_CRITICAL: flush everything. BUG= 622069 Review-Url: https://codereview.chromium.org/2131883002 Cr-Commit-Position: refs/heads/master@{#404609} [modify] https://crrev.com/90e6f5527236b01e687e65722b257e884fc7f1b6/net/ssl/ssl_client_session_cache.cc [modify] https://crrev.com/90e6f5527236b01e687e65722b257e884fc7f1b6/net/ssl/ssl_client_session_cache.h [modify] https://crrev.com/90e6f5527236b01e687e65722b257e884fc7f1b6/net/ssl/ssl_client_session_cache_unittest.cc
,
Jul 11 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by davidben@chromium.org
, Jun 22 2016