New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622069 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 620852



Sign in to add a comment

Clear SSLClientSessionCache on low memory notifications

Project Member Reported by mariakho...@chromium.org, Jun 21 2016

Issue description

This cache can be as large as several MB.
 
By the way, it's also possible the current max size of 1024 can be shrunk. That number's just been carried over from the very first version of Chrome for Android. I left it alone, assuming that you all had tuned it when setting it (these numbers don't come from desktop Chrome), but maybe it's wrong.

See https://cs.chromium.org/chromium/src/net/ssl/ssl_client_session_cache.h?rcl=0&l=30

(We'd want to watch metrics on resumption rate as the cache size varies, of course, to quantify the exact trade-off here.)
I don't understand why you say that these numbers come from Chrome for Android? I don't see any android-specific config getting set?

I am also pretty confident no one tuned this for the first release of Chrome for Android.

Comment 3 by mmenke@chromium.org, Jun 22 2016

The current limits were added in https://codereview.chromium.org/89623002, I believe, by a member of the Chrome for Android team.  Linked bug mentions Android crashes.
So, I think these numbers are shared between desktop and mobile. There was a refactoring done by someone on the mobile team, but it was done to fix a crash through cleaner structure. I don't think any performance testing was done back then.
Question - I haven't figured out how to receive low memory notifications.

Do you have any examples available? Or is there a certain class that is in charge of this?
Take a look at base/memory/memory_pressure_listener.h
thank you!
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90e6f5527236b01e687e65722b257e884fc7f1b6

commit 90e6f5527236b01e687e65722b257e884fc7f1b6
Author: maksim.sisov <maksim.sisov@intel.com>
Date: Mon Jul 11 07:12:35 2016

Clear SSLClientSessionCache on low memory notifications.

There are two cases when cache is flushed:

1) MEMORY_PRESSURE_LEVEL_MODERATE: flush expired sessions only.
2) MEMORY_PRESSURE_LEVEL_CRITICAL: flush everything.

BUG= 622069 

Review-Url: https://codereview.chromium.org/2131883002
Cr-Commit-Position: refs/heads/master@{#404609}

[modify] https://crrev.com/90e6f5527236b01e687e65722b257e884fc7f1b6/net/ssl/ssl_client_session_cache.cc
[modify] https://crrev.com/90e6f5527236b01e687e65722b257e884fc7f1b6/net/ssl/ssl_client_session_cache.h
[modify] https://crrev.com/90e6f5527236b01e687e65722b257e884fc7f1b6/net/ssl/ssl_client_session_cache_unittest.cc

Comment 9 by mmenke@chromium.org, Jul 11 2016

Status: Fixed (was: Available)

Sign in to add a comment