New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622067 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Add basic stylus support to the touch FW test suite

Reported by charliemooney@chromium.org, Jun 21 2016

Issue description

We should add it so we can evaluate stylus-based touch sensors.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/touch_firmware_test/+/5196962c534606d9f46c0f545d4f70a47ae3e07e

commit 5196962c534606d9f46c0f545d4f70a47ae3e07e
Author: Charlie Mooney <charliemooney@chromium.org>
Date: Tue Jun 21 21:31:49 2016

Add Stylus support to the touch FW test

This CL adds basic stylus support to the touch FW test by adding an
addition state machine for parsing this new protocol.  Styluses use
a simpler protocol since there is only a single stylus supported at
a time, but essentially it works the same way.  Currently this state
machine simply ignores any "hover" events, until we have a better
idea of what we want to do with them, but it is capable of parsing
that information out as well.  This should allow us to use the same
FW test test out stylus-based devices as well as finger-based ones.

To use this new protocol, simply specify --protocol=stylus when running
the FW test.

Note: since the autodetection of devices wasn't very useful to start
with, and the addition of Stylus made it even more cumbersome and less
valuable that's been removed by this patch for simplicity's sake.

BUG= chromium:622067 
TEST=manually tested using a device with a styus screen installed

Change-Id: Iee4c7ade94fcbb82f9b877814df341c2b2c8f7bb
Signed-off-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/354600
Reviewed-by: Shyh-In Hwang <josephsih@chromium.org>

[modify] https://crrev.com/5196962c534606d9f46c0f545d4f70a47ae3e07e/remote/mt/state_machine.py
[modify] https://crrev.com/5196962c534606d9f46c0f545d4f70a47ae3e07e/main.py
[modify] https://crrev.com/5196962c534606d9f46c0f545d4f70a47ae3e07e/remote/mt/event.py
[modify] https://crrev.com/5196962c534606d9f46c0f545d4f70a47ae3e07e/remote/remote_in_system.py
[modify] https://crrev.com/5196962c534606d9f46c0f545d4f70a47ae3e07e/remote/mt/__init__.py
[modify] https://crrev.com/5196962c534606d9f46c0f545d4f70a47ae3e07e/remote/remote.py

Status: Fixed (was: Started)
Labels: VerifyIn-54

Comment 4 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 5 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 6 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 7 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 8 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 9 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Status: Verified (was: Fixed)

Sign in to add a comment