"Showing history from your signed-in devices" text missing in the new MD history page. |
|||||||
Issue descriptionENVIRONMENT and STATS Chrome version: 53.0.2774.2 OS: All REPRO STEPS 1. Sign in to Chrome on multiple devices. 2. Go to chrome://history ACTUAL RESULTS Observe that "Showing history from your signed-in devices" text not displayed. EXPECTED RESULTS When user is signed in to chrome on multiple devices, "Showing history from your signed-in devices" text is displayed in the history page. ADDITIONAL INFO Anything else which may help us debug the issue; screenshots of error messages or states are always helpful.
,
Jun 22 2016
These are not currently included in the History page. @calamity/tsergeant -- is it possible to include such a message at the top of the iron-list, or will that cause issues similar to the sign-in promo?
,
Jul 3 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 14 2016
"Your Google Account may have other forms of browsing history at [history.google.com]" is being tracked at crbug.com/627594 Mocks for this bug is TBD.
,
Jul 15 2016
"Showing history from your signed-in devices" string to live in the toolbar. - only to be shown on "Chrome history" page - only to be shown when signed-in
,
Jul 26 2016
Thanks Alan! +Sabine FYI. +Rachel, PTAL at the first mock in #5. The "Showing history from your signed-in devices" is now behind a tooltip hover (in the new MD history mocks). I don't know the historical background/context for that string. Do you think that's sufficient (e.g. from a privacy POV)? Any other stakeholders we should run this mock by?
,
Jul 26 2016
This should get a privacy lgtm (Sabine is OOO, so email chrome-privacy-core) but it looks fine to me. The purpose of that notice is to explain why content that wasn't browsed on this device is showing up, and under the (i) seems ok.
,
Sep 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e226eff5fb383a9a54ec74c95e245a206449a9f5 commit e226eff5fb383a9a54ec74c95e245a206449a9f5 Author: tsergeant <tsergeant@chromium.org> Date: Wed Sep 14 01:59:19 2016 MD History: Add icon in top right of page when showing synced results This adds an (i) button to top right of the page which, when clicked, shows the 'Showing results from all your signed-in devices' message. The message can be dismissed by clicking anywhere or pressing escape. It will only show up for users with history sync enabled, on the main history page. BUG= 622055 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2270993003 Cr-Commit-Position: refs/heads/master@{#418454} [modify] https://crrev.com/e226eff5fb383a9a54ec74c95e245a206449a9f5/chrome/app/generated_resources.grd [modify] https://crrev.com/e226eff5fb383a9a54ec74c95e245a206449a9f5/chrome/browser/resources/md_history/app.crisper.js [modify] https://crrev.com/e226eff5fb383a9a54ec74c95e245a206449a9f5/chrome/browser/resources/md_history/app.html [modify] https://crrev.com/e226eff5fb383a9a54ec74c95e245a206449a9f5/chrome/browser/resources/md_history/app.js [modify] https://crrev.com/e226eff5fb383a9a54ec74c95e245a206449a9f5/chrome/browser/resources/md_history/app.vulcanized.html [modify] https://crrev.com/e226eff5fb383a9a54ec74c95e245a206449a9f5/chrome/browser/resources/md_history/history.js [modify] https://crrev.com/e226eff5fb383a9a54ec74c95e245a206449a9f5/chrome/browser/resources/md_history/history_toolbar.html [modify] https://crrev.com/e226eff5fb383a9a54ec74c95e245a206449a9f5/chrome/browser/resources/md_history/history_toolbar.js [modify] https://crrev.com/e226eff5fb383a9a54ec74c95e245a206449a9f5/chrome/browser/resources/md_history/icons.html [modify] https://crrev.com/e226eff5fb383a9a54ec74c95e245a206449a9f5/chrome/browser/ui/webui/md_history_ui.cc [modify] https://crrev.com/e226eff5fb383a9a54ec74c95e245a206449a9f5/chrome/test/data/webui/md_history/history_toolbar_test.js
,
Sep 16 2016
,
Sep 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb822998547a76921c0a8ea5572db49fedd71700 commit cb822998547a76921c0a8ea5572db49fedd71700 Author: tsergeant <tsergeant@chromium.org> Date: Fri Sep 16 04:58:54 2016 MD History: Fix sync info icon in RTL languages This icon was incorrectly appearing on the right side of the page, when it should appear on the left. BUG= 622055 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2342243002 Cr-Commit-Position: refs/heads/master@{#419105} [modify] https://crrev.com/cb822998547a76921c0a8ea5572db49fedd71700/chrome/browser/resources/md_history/app.vulcanized.html [modify] https://crrev.com/cb822998547a76921c0a8ea5572db49fedd71700/chrome/browser/resources/md_history/history_toolbar.html
,
Oct 12 2016
This is now fixed, the text is visible when clicking on the (i) icon in the top right of the page.
,
Dec 21 2016
Verified in 57.0.2950.0. Text is visible when clicked on the (i) icon in the top right. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ew...@chromium.org
, Jun 21 2016Owner: bettes@chromium.org
Status: Assigned (was: Untriaged)
Adding some folks who (I think) are working on the new history page, and sync folks. We probably need to include *both* notices ("Showing history from your signed-in devices [learn more]" as well as "Your Google Account may have other forms of browsing history at [history.google.com]"), right? Alan - have you included these pieces of text in the mocks for the new history page?