New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622045 link

Starred by 9 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Audio active node does not switch to external audio if first time peripheral is plugged while device is off.

Project Member Reported by ka...@chromium.org, Jun 21 2016

Issue description

Same as partner  bug 54069 , but this applies to all boards.

  1.Recover or powerwash the system
  2.power down system
  3.plug headphone
  4.power on system
  5.check the output from system tray whether sign in or not.

Result: Active audio nodes are the onboard ones - Speaker and Internal Mic

This is the case when first plug of audio device is at time device is off.

System log and screen-shot is uploaded at: 
https://pantheon.corp.google.com/storage/browser/chromiumos-test-logs/bugfiles/crosp/54069/

 

Comment 1 by ka...@chromium.org, Jun 21 2016

The issue is reproduced separately for audio jack and USB audio peripherals.

HDMI audio is functioning as expected(after display is extended/mirrored).

When plugged USB and headphones together while DUT is off(after powerwash), the output node was set on Headphone(3.5) and input node on Internal Mic, which might be effect of a bigger issue.

Comment 2 by shrawan@google.com, Jun 22 2016

This issue is observed on M52-BETA-6 (8350.38.0) 52.0.2743.49 too with all DUTs.
#CBC-RS/TC-watchlist

May be related to CBC reference: https://productforums.google.com/forum/#!topic/chromebook-central/40yPz2UCxsA

Comment 4 by jen...@chromium.org, Jul 22 2016

Status: Started (was: Untriaged)

Comment 5 by jen...@chromium.org, Jul 23 2016

I could repro this case on samus, am looking into it.

Comment 6 by jen...@chromium.org, Jul 27 2016

This is a corner case that a new audio device is plugged in for the first on a cros device after the device is powered down. After reboot, the old active device(internal speaker) is selected as the active one from the previously saved audio prefs. Another repro case would be.
1. Install a new image on a cros device with internal speaker but no other audio output attached.
2. Power down.
3. Plug in headphone.
4. Power on.
Result: The internal speaker is selected as active.

I have a pending cl to fix this issue. For such corner case, instead of honoring the active device from the previous session, re-select the active device by priority, which is likely the best bet for such corner case.

https://codereview.chromium.org/2189463004/

Comment 8 by jen...@chromium.org, Jul 28 2016

Labels: M-54
Status: Fixed (was: Started)
Fixed on TOT.

Comment 9 by ka...@chromium.org, Aug 22 2016

Cc: pucchakayala@chromium.org ka...@chromium.org jen...@chromium.org
 Issue 597130  has been merged into this issue.

Comment 10 by ka...@chromium.org, Aug 22 2016

Labels: Merge-Request-53

Comment 11 by dimu@chromium.org, Aug 22 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 23 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/526139a9551af8525f74ee05c406ec62f4f1a98d

commit 526139a9551af8525f74ee05c406ec62f4f1a98d
Author: Jenny Zhang <jennyz@chromium.org>
Date: Tue Aug 23 17:33:16 2016

Fix the corner case for new audio device is not selected as active if it is plugged in for the first time after cros device is powered down.

BUG= 622045 

Review-Url: https://codereview.chromium.org/2189463004
Cr-Commit-Position: refs/heads/master@{#408431}
(cherry picked from commit 6d5579b510fe8dcc6efb7ea1b6e881f840aa7f87)

Review URL: https://codereview.chromium.org/2270693005 .

Cr-Commit-Position: refs/branch-heads/2785@{#726}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/526139a9551af8525f74ee05c406ec62f4f1a98d/chromeos/audio/audio_devices_pref_handler_impl.cc
[modify] https://crrev.com/526139a9551af8525f74ee05c406ec62f4f1a98d/chromeos/audio/audio_devices_pref_handler_impl_unittest.cc
[modify] https://crrev.com/526139a9551af8525f74ee05c406ec62f4f1a98d/chromeos/audio/cras_audio_handler.cc
[modify] https://crrev.com/526139a9551af8525f74ee05c406ec62f4f1a98d/chromeos/audio/cras_audio_handler_unittest.cc

Status: Verified (was: Fixed)
verified in 8743.8.0, 54.0.2840.10

Sign in to add a comment