Issue 622029 link

Starred by 2 users

Issue metadata

Status:	Archived
Owner:	█ waihong@chromium.org Last visit > 30 days ago
Closed:	Jun 2016
Cc:	dchan@chromium.org █ shchen@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
faft-in-lab VerifyIn-54 VerifyIn-55 VerifyIn-56 VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

FAFT: 'NoneType' object has no attribute 'dump_whole'"

Project Member Reported by waihong@chromium.org, Jun 21 2016

Issue description

Some FAFT tests failed on Chromeboxes which don't have Chrome EC.
  https://wmatrix.googleplex.com/testrun/unfiltered?test_ids=313157267

Should ignore the EC extracting for firmware updater.

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/133b00c8869cfd20e26a43d37f677eea28fd5214

commit 133b00c8869cfd20e26a43d37f677eea28fd5214
Author: Tom Wai-Hong Tam <waihong@chromium.org>
Date: Tue Jun 21 20:06:19 2016

FAFT: Ignore extracting EC binary on devices without Chrome EC

BUG= chromium:622029 
TEST=Ran the firmware_UpdateFirmwareVersion test on a Chromebox

Change-Id: I233eb038b2a3f96eb33cda91d6c9b2890cf37fbc
Reviewed-on: https://chromium-review.googlesource.com/354484
Commit-Ready: Wai-Hong Tam <waihong@google.com>
Tested-by: Wai-Hong Tam <waihong@chromium.org>
Reviewed-by: danny chan <dchan@chromium.org>

[modify] https://crrev.com/133b00c8869cfd20e26a43d37f677eea28fd5214/server/cros/faft/firmware_test.py