Fragments not being included in generated proguard flags file |
|||||
Issue descriptionaapt generates Proguard keep rules based on AndroidManifest and other .xml files, but it neglects to do so for fragments which are in an xml file like so https://cs.chromium.org/chromium/src/chrome/android/java/res/xml/main_preferences.xml?q=AboutChromePreferences&sq=package:chromium&l=49&dr=C Potential fix might be to edit this file and make it put fragments into the proguard output files. https://cs.chromium.org/chromium/src/build/android/gyp/process_resources.py Fixing this bug would provide some small wins on .apk size.
,
Nov 30 2016
,
Mar 10 2017
,
May 9 2017
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/acdd2a4349f0316bcc5f6c09a5fce64d92e82aaa commit acdd2a4349f0316bcc5f6c09a5fce64d92e82aaa Author: agrieve <agrieve@chromium.org> Date: Thu Jun 22 19:15:26 2017 Android: Tweak Chrome's proguard flags (no-op) Makes -keep of Fragments scoped to preferences package and removes no-longer-necessary -dontwarn for play services. Tested that this does not change classes.dex whatsoever. BUG= 622023 Review-Url: https://codereview.chromium.org/2951243002 Cr-Commit-Position: refs/heads/master@{#481620} [modify] https://crrev.com/acdd2a4349f0316bcc5f6c09a5fce64d92e82aaa/chrome/android/java/proguard.flags
,
Jun 22 2017
Didn't do original proposal, but scoped down the proguard -keep, and I think that's good enough. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by agrieve@chromium.org
, Sep 9 2016Status: Available (was: Untriaged)