New issue
Advanced search Search tips

Issue 622005 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.chrome.browser.physicalweb.UrlManagerTest#testAddUrlInCacheWithOthersMakesNoNotification" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 21 2016

Issue description

"org.chromium.chrome.browser.physicalweb.UrlManagerTest#testAddUrlInCacheWithOthersMakesNoNotification" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNycAsSBUZsYWtlImVvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIucGh5c2ljYWx3ZWIuVXJsTWFuYWdlclRlc3QjdGVzdEFkZFVybEluQ2FjaGVXaXRoT3RoZXJzTWFrZXNOb05vdGlmaWNhdGlvbgw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Project Member

Comment 1 by chromium...@appspot.gserviceaccount.com, Jun 23 2016

Detected 4 new flakes for test/step "org.chromium.chrome.browser.physicalweb.UrlManagerTest#testAddUrlInCacheWithOthersMakesNoNotification". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNycAsSBUZsYWtlImVvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIucGh5c2ljYWx3ZWIuVXJsTWFuYWdlclRlc3QjdGVzdEFkZFVybEluQ2FjaGVXaXRoT3RoZXJzTWFrZXNOb05vdGlmaWNhdGlvbgw. This message was posted automatically by the chromium-try-flakes app.

Comment 2 by hbos@chromium.org, Jun 23 2016

Labels: -Sheriff-Chromium
Owner: cco3@chromium.org
Status: Unconfirmed (was: Untriaged)
cco3, can you take a look?

Assertion fails:
https://cs.chromium.org/chromium/src/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java?type=cs&q=UrlManagerTest.java:247&sq=package:chromium&l=247

Not sure if still flaky. I did not disable the test because it has not happened in the last 200 builds (at the time of writing).
Project Member

Comment 3 by chromium...@appspot.gserviceaccount.com, Jun 24 2016

Labels: Sheriff-Chromium
Detected 4 new flakes for test/step "org.chromium.chrome.browser.physicalweb.UrlManagerTest#testAddUrlInCacheWithOthersMakesNoNotification". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNycAsSBUZsYWtlImVvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIucGh5c2ljYWx3ZWIuVXJsTWFuYWdlclRlc3QjdGVzdEFkZFVybEluQ2FjaGVXaXRoT3RoZXJzTWFrZXNOb05vdGlmaWNhdGlvbgw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 4 by cco3@chromium.org, Jun 24 2016

Looking into it...
cco3: would you mind marking this test as flaky while you investigate?
Status: Assigned (was: Unconfirmed)
https://codereview.chromium.org/2098303002/ is going through the CQ to disable the test.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6f783cf380b2ae927b543583c91249f03b07933

commit d6f783cf380b2ae927b543583c91249f03b07933
Author: blundell <blundell@chromium.org>
Date: Mon Jun 27 09:32:13 2016

Disable flaky testAddUrlInCacheWithOthersMakesNoNotification test

BUG=622005
TBR=cco3, ellyjones

Review-Url: https://codereview.chromium.org/2098303002
Cr-Commit-Position: refs/heads/master@{#402142}

[modify] https://crrev.com/d6f783cf380b2ae927b543583c91249f03b07933/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java

Labels: -Sheriff-Chromium
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90a36093a34e544b1c0a17555c6ae4ef1c5af9b0

commit 90a36093a34e544b1c0a17555c6ae4ef1c5af9b0
Author: cco3 <cco3@chromium.org>
Date: Mon Jun 27 18:30:10 2016

Gather data on Physical Web cached URL scenario

When we try to add a URL that is in our cache, no notification should
show.  However, we have a flaky test that suggests this isn't the case.
This change adds logging to gather additional data on what might be
going wrong and marks the test as flaky.

BUG=622005

Review-Url: https://codereview.chromium.org/2091393002
Cr-Commit-Position: refs/heads/master@{#402233}

[modify] https://crrev.com/90a36093a34e544b1c0a17555c6ae4ef1c5af9b0/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
[modify] https://crrev.com/90a36093a34e544b1c0a17555c6ae4ef1c5af9b0/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java

Owner: ----
Status: Untriaged (was: Assigned)
Marking issues assigned to cco3@ as untriaged as they are no longer working on Chromium.

Sign in to add a comment