New issue
Advanced search Search tips

Issue 622000 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 613414



Sign in to add a comment

fast\hidpi\image-srcset-intrinsic-size-zero.html fails with use-zoom-for-dsf flag on

Project Member Reported by bsep@chromium.org, Jun 21 2016

Issue description

It looks like the clientWidth is being maxed out because the pixel density is 0, and then at query time it's being divided by the zoom level, which is now affected by the scale factor.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e691b41f4226ecb00323a46fedb97d0ae2b67047

commit e691b41f4226ecb00323a46fedb97d0ae2b67047
Author: bsep <bsep@chromium.org>
Date: Wed Jun 22 20:56:20 2016

Adjust test expectations for infinite-size images.

The test for infinite-size images is expecting the width to be equal to
the maximum possible value of a blink layout value. However, with
use-zoom-for-dsf on and device scale factor !=1 all image widths are
adjusted by the scale factor. So the test's expectation needs to be
changed because the effective maximum value is now different.

BUG= 622000 

Review-Url: https://codereview.chromium.org/2085153002
Cr-Commit-Position: refs/heads/master@{#401397}

[modify] https://crrev.com/e691b41f4226ecb00323a46fedb97d0ae2b67047/components/test_runner/test_runner_for_specific_view.cc
[modify] https://crrev.com/e691b41f4226ecb00323a46fedb97d0ae2b67047/components/test_runner/web_test_delegate.h
[modify] https://crrev.com/e691b41f4226ecb00323a46fedb97d0ae2b67047/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/e691b41f4226ecb00323a46fedb97d0ae2b67047/content/shell/renderer/layout_test/blink_test_runner.h
[modify] https://crrev.com/e691b41f4226ecb00323a46fedb97d0ae2b67047/third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-intrinsic-size-zero.html
[modify] https://crrev.com/e691b41f4226ecb00323a46fedb97d0ae2b67047/third_party/WebKit/LayoutTests/fast/hidpi/resources/srcset-helper.js

Comment 2 by bsep@chromium.org, Jun 22 2016

Status: Fixed (was: Assigned)

Sign in to add a comment