RemoteSecurityKeyIpcServerTest creates files in homedir |
|||
Issue description1. run remoting_unittests 2. terminate them by pressing Ctrl+C The tests leave the files in my home dir: $ ls *Test_Channel* Remote_Security_Key_Ipc_Client_Test_Channel.15372.0.1384635683 Super_Awesome_Test_Channel.15373.5.287570679 A standard solution to avoid this problem is to use base::ScopedTempDir, see base/files/scoped_temp_dir.h
,
Jul 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/efeac5ea44139d44a279a2ad6b5dae9c66543bc4 commit efeac5ea44139d44a279a2ad6b5dae9c66543bc4 Author: joedow <joedow@chromium.org> Date: Thu Jul 21 03:36:40 2016 Changing the default path for RemoteSecurityKeyIpcServer test channels The following change moved the location of our IPC test channels to the home directory which is why we were seeing left-over crud there when the tests were cancelled: Change 4e752e108394090a1d83f9054a862ffa60293346 https://codereview.chromium.org/2003753002 My change moves the location from the home directory, which can cause problems for local development to the temp directory which should work for both local devs and trybots. I've also included other posix based OSes in this change since their IPC channels use UDS as well (Windows should not be changed since it still uses named pipes). BUG= 621995 Review-Url: https://codereview.chromium.org/2161013003 Cr-Commit-Position: refs/heads/master@{#406759} [modify] https://crrev.com/efeac5ea44139d44a279a2ad6b5dae9c66543bc4/remoting/host/security_key/security_key_ipc_client_unittest.cc [modify] https://crrev.com/efeac5ea44139d44a279a2ad6b5dae9c66543bc4/remoting/host/security_key/security_key_ipc_constants.cc
,
Jul 22 2016
,
Jul 22 2016
Verfied cancelling the tests no longer leaves crumbs in the home directory. |
|||
►
Sign in to add a comment |
|||
Comment 1 by joedow@chromium.org
, Jul 18 2016