Limit number of times servo downloads test image to usb key |
|||||
Issue descriptionCurrently servo will d/l the chromious test image to the usb key every time a repair is invoked even though the image is the same on the usb key. We'll want to avoid this repetitive d/l action. Two ways to do this is: - servod remembers last d/l url and if it's given the same one, don't d/l it again - store build url in the host attributes and skip d/l if it's the same
,
Jun 21 2016
,
Jun 21 2016
,
Jun 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/9071ed919092ba2d5fcae84a4b3b3c3de4b4049f commit 9071ed919092ba2d5fcae84a4b3b3c3de4b4049f Author: Kevin Cheng <kevcheng@chromium.org> Date: Tue Jun 21 21:37:54 2016 servod: download_image_to_usb only downloads new images. Servod will download whatever you tell it to download even if the last image you told it to download already exists on the usb device. Add in a quick check to see if the last image path matches the current image path to download and skip the transfer if it's the same saving time and network bandwidth. BUG= chromium:621994 TEST=Locally validated that servod will skip transfer on the same image_path. Change-Id: Ie5f14b7d2a207bf629271ba70d9308161a35eae8 Reviewed-on: https://chromium-review.googlesource.com/354610 Commit-Ready: Kevin Cheng <kevcheng@chromium.org> Tested-by: Kevin Cheng <kevcheng@chromium.org> Reviewed-by: Richard Barnette <jrbarnette@google.com> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/9071ed919092ba2d5fcae84a4b3b3c3de4b4049f/servo/servo_server.py
,
Jun 23 2016
Tested beaglebone_servo/R53-8489.0.0 and I could successfully boot up a servo v3 and use dut-control with it on a veyron_jerry. I could also upgrade/downgrade to/from the current version. Setting stable version to R53-8489.0.0 today.
,
Aug 12 2016
Closing. please reopen if its not fixed. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kevcheng@chromium.org
, Jun 21 2016