New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 621988 link

Starred by 2 users
Status: Fixed
Owner:
█ brettw@chromium.org
Last visit 26 days ago
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

GN build needs test_installer_sentinel on Windows

Project Member Reported by brettw@chromium.org, Jun 21 2016 
This target in GYP forces relinking when the installer Python tests change

This does not block GN conversion. It does mean that on incremental builds, the installer unittests won't trigger on the bots if you just change the installer Python files and no code in Chrome or the actual installer.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca63fc255102c88323389f36b47d24e7063c4c15

commit ca63fc255102c88323389f36b47d24e7063c4c15
Author: brettw <brettw@chromium.org>
Date: Wed Jun 22 22:05:46 2016

Add input dependencies on installer test scripts

This will cause recompiles when the scripts change, forcing the bots to
run the tests. It replaces GYP's test_installer_sentinel target.

BUG= 621988 

Review-Url: https://codereview.chromium.org/2084093003
Cr-Commit-Position: refs/heads/master@{#401426}

[modify] https://crrev.com/ca63fc255102c88323389f36b47d24e7063c4c15/chrome/installer/mini_installer/BUILD.gn
[add] https://crrev.com/ca63fc255102c88323389f36b47d24e7063c4c15/chrome/test/mini_installer/mini_installer_test.gni

Comment 2 by brettw@chromium.org, Jun 22 2016

Status: Fixed (was: Assigned)

Comment 3 by thakis@chromium.org, Aug 22 2016 

There's still

  deps = [
    #"test_installer_sentinel",  TODO(GYP)  bug 521052 .
  ]


in chrome/installer/mini_installer/BUILD.gn. Can that just be deleted now?

Comment 4 by thakis@chromium.org, Aug 22 2016 

Sorry, please ignore. Bad local checkout.
►

Sign in to add a comment