Mark debug symbol upload stage as failed not warning, when actual failure occurs |
|||||||
Issue descriptionWhen debug symbols fail to upload, builder stage is shown as warning not failure. Golden Eye record therefore shows the symbols as available when the upload actually failed. E.g. Falco build: https://uberchromegw.corp.google.com/i/chromeos_release/builders/falco-release%20release-R52-8350.B/builds/31 STEP_FAILURE 23:39:41: WARNING: <_BackgroundTask(_BackgroundTask-4, started)> hung for 600 seconds File "/b/cbuild/shared_internal/chromite/bin/upload_symbols", line 164, in <module> commandline.ScriptWrapperMain(FindTarget) File "/b/cbuild/shared_internal/chromite/lib/commandline.py", line 834, in ScriptWrapperMain ret = target(argv[1:]) File "/b/cbuild/shared_internal/chromite/scripts/upload_symbols.py", line 889, in main product_name=opts.product_name) File "/b/cbuild/shared_internal/chromite/scripts/upload_symbols.py", line 714, in UploadSymbols _Upload(queue, counters, dedupe_list) File "/usr/lib/python2.7/contextlib.py", line 24, in __exit__ self.gen.next() File "/b/cbuild/shared_internal/chromite/lib/parallel.py", line 749, in BackgroundTaskRunner queue.put(_AllTasksComplete()) File "/usr/lib/python2.7/contextlib.py", line 24, in __exit__ self.gen.next() File "/b/cbuild/shared_internal/chromite/lib/parallel.py", line 545, in ParallelTasks task_errors = task.Wait() File "/b/cbuild/shared_internal/chromite/lib/parallel.py", line 362, in Wait traceback.print_stack() 23:39:41: INFO: finished uploading; joining background process upload_symbols: Unhandled exception: Traceback (most recent call last): File "/b/cbuild/shared_internal/chromite/bin/upload_symbols", line 164, in <module> commandline.ScriptWrapperMain(FindTarget) File "/b/cbuild/shared_internal/chromite/lib/commandline.py", line 834, in ScriptWrapperMain ret = target(argv[1:]) File "/b/cbuild/shared_internal/chromite/scripts/upload_symbols.py", line 889, in main product_name=opts.product_name) File "/b/cbuild/shared_internal/chromite/scripts/upload_symbols.py", line 714, in UploadSymbols _Upload(queue, counters, dedupe_list) File "/usr/lib/python2.7/contextlib.py", line 24, in __exit__ self.gen.next() File "/b/cbuild/shared_internal/chromite/lib/parallel.py", line 749, in BackgroundTaskRunner queue.put(_AllTasksComplete()) File "/b/cbuild/shared_internal/chromite/lib/parallel.py", line 749, in BackgroundTaskRunner queue.put(_AllTasksComplete()) File "/usr/lib/python2.7/contextlib.py", line 24, in __exit__ self.gen.next() File "/b/cbuild/shared_internal/chromite/lib/parallel.py", line 560, in ParallelTasks raise BackgroundFailure(exc_infos=errors) chromite.lib.parallel.BackgroundFailure: <class 'chromite.lib.parallel.ProcessExitTimeout'>: <_BackgroundTask(_BackgroundTask-4, started)> hung for 600 seconds Link to logs: https://uberchromegw.corp.google.com/i/chromeos_release/builders/falco-release%20release-R52-8350.B/builds/31/steps/DebugSymbols/logs/stdio
,
Jun 22 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 1 2016
We don't want to mark this as failed, or the whole build will be DoA. Per discussion offline this is desired to make goldeneye more clearly display whether debug symbols were uploaded. We don't currently distinguish in metadata.json between passed and warning, so goldeneye has no way of knowing.
,
Jul 1 2016
Don is working on a fix to the timeouts in crbug.com/610902
,
Jul 3 2016
This issue has been moved once and is lower than Pri-1. Removing the milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 3 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 14
,
Dec 14
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by gkihumba@chromium.org
, Jun 21 2016