Oh, and /GS is now hooked up. (no cookie xoring yet tho)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90f52193989bb835ed58f903e108827c4d1ee869

commit 90f52193989bb835ed58f903e108827c4d1ee869
Author: thakis <thakis@chromium.org>
Date: Thu Jun 23 19:26:41 2016

clang update.py: Force on --build-id for now.

BUG= 622775 , 621972 

Review-Url: https://codereview.chromium.org/2091753003
Cr-Commit-Position: refs/heads/master@{#401679}

[modify] https://crrev.com/90f52193989bb835ed58f903e108827c4d1ee869/tools/clang/scripts/update.py

kicked off a job to build binaries at https://codereview.chromium.org/2095683003 (the tot waterfall is still pretty red but it might cycle green at that revision...)

I've pushed that one to goma and started tryjobs to see where we're at.

Android's broken:

[3356/42375] CXX obj/mojo/public/cpp/bindings/bindings/multiplex_router.o
FAILED: obj/mojo/public/cpp/bindings/bindings/multiplex_router.o 
/b/build/slave/cache/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/mojo/public/cpp/bindings/bindings/multiplex_router.o.d -DV8_DEPRECATION_WARNINGS -DENABLE_NOTIFICATIONS -DENABLE_BROWSER_CDMS -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DADDRESS_SANITIZER -DUSE_EXTERNAL_POPUP_MENU=1 -DENABLE_WEBRTC=1 -DDISABLE_NACL -DENABLE_SUPERVISED_USERS=1 -DUSE_PROPRIETARY_CODECS -DVIDEO_HOLE=1 -DSAFE_BROWSING_DB_REMOTE -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DENABLE_WEBVR -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=273595-1 -D_FILE_OFFSET_BITS=64 -DANDROID -DHAVE_SYS_UIO_H -DANDROID_NDK_VERSION=r10e -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCOMPONENT_BUILD -D__GNU_SOURCE=1 -D__compiler_offsetof=__builtin_offsetof -Dnan=__builtin_nan -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -I../.. -Igen -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -fcolor-diagnostics -ffunction-sections -fno-short-enums --target=arm-linux-androideabi -march=armv7-a -mfloat-abi=softfp -mthumb -mtune=generic-armv7-a -mfpu=neon -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Os -fdata-sections -ffunction-sections -g1 --sysroot=../../third_party/android_tools/ndk/platforms/android-16/arch-arm -gline-tables-only -fno-omit-frame-pointer -fsanitize=address -fsanitize-blacklist=../../tools/memory/asan/blacklist.txt -mllvm -asan-globals=0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -Xclang -plugin-arg-find-bad-constructs -Xclang check-implicit-copy-ctors -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -fno-threadsafe-statics -fvisibility-inlines-hidden -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=gnu++11 -fno-rtti -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++abi/libcxxabi/include -isystem../../third_party/android_tools/ndk/sources/android/support/include -fno-exceptions -c ../../mojo/public/cpp/bindings/lib/multiplex_router.cc -o obj/mojo/public/cpp/bindings/bindings/multiplex_router.o

# In Register Scavenger
# Machine code for function _ZN4mojo8internal15MultiplexRouter22ProcessIncomingMessageEPNS_7MessageENS1_18ClientCallBehaviorEPN4base22SingleThreadTaskRunnerE: Properties: <Post SSA, tracking liveness, AllVRegsAllocated>
Frame Objects:
  fi#0: size=4, align=4, at location [SP-100]
  fi#1: variable sized, align=32, at location [SP-96]

next try: https://codereview.chromium.org/2096113002

(that includes the change to use unicode functions for all the win32 function calls, which might make wine sad on goma...we'll see)

https://codereview.chromium.org/2093273002/ has pretty good try jobs. msan isn't happy yet, bug  bug 623413  had a commit recently and that bot might cycle green now.

This roll also brings in lld support for PR28197 (`#pragma comment(linker, "/SECTION:.hook,RWS"`)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/167bf10be217f2613024a0b0f729a45da83249c0

commit 167bf10be217f2613024a0b0f729a45da83249c0
Author: thakis <thakis@chromium.org>
Date: Mon Jun 27 16:57:58 2016

Roll clang 270823:273743.

Ran `tools/clang/scripts/upload_revision.py 273743`.

BUG= 621972 
TBR=hans

Review-Url: https://codereview.chromium.org/2093273002
Cr-Commit-Position: refs/heads/master@{#402202}

[modify] https://crrev.com/167bf10be217f2613024a0b0f729a45da83249c0/build/common.gypi
[modify] https://crrev.com/167bf10be217f2613024a0b0f729a45da83249c0/build/config/compiler/BUILD.gn
[modify] https://crrev.com/167bf10be217f2613024a0b0f729a45da83249c0/tools/clang/scripts/update.py

This has been in the tree for 8h, maybe it'll stay in.

Fallout so far: webrtc found https://llvm.org/bugs/show_bug.cgi?id=28348, but we have a local workaround, so so far it still looks like the roll might stick.