[TabManager] make IdFromWebContents public |
||
Issue descriptionMake this function public: https://cs.chromium.org/chromium/src/chrome/browser/memory/tab_manager.cc?l=91 Since this is being used in many tests and new tabs API and can be obscure for readers. We could have 2 static public functions Webcontents -> ID and the other way around.
,
Aug 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b55735a3115817131690dc0607a6f998de23717 commit 3b55735a3115817131690dc0607a6f998de23717 Author: andersoncss <andersoncss@google.com> Date: Tue Aug 16 23:59:44 2016 New Public IdFromWebContents method on TabManager. Increase readbility by making the method public and therefore clients of TabManager don't need to know how the ids are created. BUG= 621960 Review-Url: https://codereview.chromium.org/2250183002 Cr-Commit-Position: refs/heads/master@{#412386} [modify] https://crrev.com/3b55735a3115817131690dc0607a6f998de23717/chrome/browser/extensions/api/tabs/tabs_test.cc [modify] https://crrev.com/3b55735a3115817131690dc0607a6f998de23717/chrome/browser/memory/tab_manager.cc [modify] https://crrev.com/3b55735a3115817131690dc0607a6f998de23717/chrome/browser/memory/tab_manager.h [modify] https://crrev.com/3b55735a3115817131690dc0607a6f998de23717/chrome/browser/memory/tab_manager_observer_browsertest.cc
,
Aug 17 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by sheriffbot@chromium.org
, Jun 22 2016