New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621958 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Update documentation on disableCache()

Project Member Reported by xunji...@chromium.org, Jun 21 2016

Issue description

CronetEngine builder's disableCache() will disable the DNS cache in addition to the HTTP cache.  This behavior is non-obvious, and should be documented.


 
Should this be the actual behavior?
We could also fix it, but there doesn't seem to be a clear way forward. See discussion on internal bug 27997533.
So disableCache() disables Cronet's DNS cache, however Android already has a DNS cache of its own (which uses proper DNS cache TTLs from the server, rather than Cronet's contrived 60s TTL).  This means that generally Cronet's cache isn't very important (esp because it only lives as long as the app and it's not shared with other apps) so it's probably not worth complicating Cronet's docs WRT this issue.

However when the Cronet's internal "async" resolver becomes popular this will become a bigger issue.  For now the async resolver is experimental only, and undocumented.
Owner: ----
Status: Available (was: Assigned)
Labels: Hotlist-Fixit
Project Member

Comment 6 by sheriffbot@chromium.org, Oct 5 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by mge...@chromium.org, Nov 30 2017

Owner: mge...@chromium.org
Status: Assigned (was: Untriaged)

Comment 8 by mge...@chromium.org, Mar 23 2018

Status: Fixed (was: Assigned)
disableCache() will no longer disable the DNS cache after https://crrev.com/c/976539.
Woohoo! This is great. Thank you for tackling this tricky issue!
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a01b16799fefbbc30092cc6d79a0bb77db4221f

commit 2a01b16799fefbbc30092cc6d79a0bb77db4221f
Author: Miriam Gershenson <mgersh@chromium.org>
Date: Thu Mar 22 22:54:47 2018

Reduce load flags that affect the host cache

Previously, all three of the load flags that prevent use of the HTTP
cache also prevented use of the DNS cache when using the socket pools.
This is not the desired behavior for most consumers of those load flags.
LOAD_BYPASS_CACHE has some consumers that might be depending on the
behavior, so it stays the same. LOAD_DISABLE_CACHE and
LOAD_VALIDATE_CACHE will not affect the host cache.

Details: https://docs.google.com/document/d/1CuGd8ZnGd56L0wpX1jkB96Lm6IF9fF409h234AqjtNw/edit?usp=sharing

Bug:  743235 ,  621958 
Change-Id: I4560cc3bf96da2f19c10a5c68179d9294012f549
Reviewed-on: https://chromium-review.googlesource.com/976539
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Miriam Gershenson <mgersh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545279}
[modify] https://crrev.com/2a01b16799fefbbc30092cc6d79a0bb77db4221f/net/base/load_flags_list.h
[modify] https://crrev.com/2a01b16799fefbbc30092cc6d79a0bb77db4221f/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/2a01b16799fefbbc30092cc6d79a0bb77db4221f/net/socket/client_socket_pool_manager.cc

Sign in to add a comment