New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621943 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome
Pri: 1
Type: Bug

Blocking:
issue 485650



Sign in to add a comment

Pepper plugin menu position is wrong with use-zoom-for-dsf

Project Member Reported by osh...@chromium.org, Jun 21 2016

Issue description


Pepper plugin menu position is wrong with use-zoom-for-dsf
 

Comment 2 by osh...@chromium.org, Jun 21 2016

Status: F (was: Started)

Comment 3 by osh...@chromium.org, Jun 21 2016

Status: Fixed (was: F)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 21 2016

Comment 5 by osh...@chromium.org, Jun 23 2016

Labels: Merge-Request-52
Can we merge to 52? This is chromeos specific in 52, and pretty safe change.

Comment 6 by dimu@google.com, Jun 23 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 23 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8943b97229c51f6ef0e1eb036089e9b68eff5cf7

commit 8943b97229c51f6ef0e1eb036089e9b68eff5cf7
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Thu Jun 23 20:46:11 2016

Scale menu position back to viewport in pepper plugin

pepper uses DIP, so it needs to be converted to viewport in use-zoom-for-dsf mode.

BUG= 621943 ,485650
TEST=manual

Review-Url: https://codereview.chromium.org/2082893003
Cr-Commit-Position: refs/heads/master@{#401024}
(cherry picked from commit 9373922b7d01101f232c6ccfdedefd76e338e3ab)

Review URL: https://codereview.chromium.org/2094843002 .

Cr-Commit-Position: refs/branch-heads/2743@{#459}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/8943b97229c51f6ef0e1eb036089e9b68eff5cf7/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/8943b97229c51f6ef0e1eb036089e9b68eff5cf7/content/renderer/pepper/renderer_ppapi_host_impl.cc
[modify] https://crrev.com/8943b97229c51f6ef0e1eb036089e9b68eff5cf7/content/renderer/pepper/renderer_ppapi_host_impl.h

Cc: brajkumar@chromium.org
Labels: Needs-Feedback
oshima@ - Could you please provide manual steps to test this issue, It will be helpful for chrome TE team to verify it.

Thanks!

Comment 9 by osh...@chromium.org, Jun 28 2016

On high DPI device like link, samus, open context menu on flash content.
Tested this issue on high DPI device Windows-10 using chrome latest Dev M53-53.0.2785.34.

oshima@ - Attaching screen-shot for reference, Could you please confirm is this is the expected behavior of the issue?
FlashContextMenu.png
1.2 MB View Download
If it opens at the cursor location (which I can't see in the screenshot :), then it's fixed.
Labels: -Needs-Feedback TE-Verified-M53 TE-Verified-53.0.2785.34
As per comment #11 confirmed the issue got fixed on latest Dev M53, Hence adding TE-Verified label.


Sign in to add a comment