Pepper plugin menu position is wrong with use-zoom-for-dsf |
||||||||
Issue descriptionPepper plugin menu position is wrong with use-zoom-for-dsf
,
Jun 21 2016
,
Jun 21 2016
,
Jun 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9373922b7d01101f232c6ccfdedefd76e338e3ab commit 9373922b7d01101f232c6ccfdedefd76e338e3ab Author: oshima <oshima@chromium.org> Date: Tue Jun 21 17:24:58 2016 Scale menu position back to viewport in pepper plugin pepper uses DIP, so it needs to be converted to viewport in use-zoom-for-dsf mode. BUG= 621943 ,485650 TEST=manual Review-Url: https://codereview.chromium.org/2082893003 Cr-Commit-Position: refs/heads/master@{#401024} [modify] https://crrev.com/9373922b7d01101f232c6ccfdedefd76e338e3ab/content/renderer/pepper/pepper_plugin_instance_impl.cc [modify] https://crrev.com/9373922b7d01101f232c6ccfdedefd76e338e3ab/content/renderer/pepper/renderer_ppapi_host_impl.cc [modify] https://crrev.com/9373922b7d01101f232c6ccfdedefd76e338e3ab/content/renderer/pepper/renderer_ppapi_host_impl.h
,
Jun 23 2016
Can we merge to 52? This is chromeos specific in 52, and pretty safe change.
,
Jun 23 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8943b97229c51f6ef0e1eb036089e9b68eff5cf7 commit 8943b97229c51f6ef0e1eb036089e9b68eff5cf7 Author: Mitsuru Oshima <oshima@chromium.org> Date: Thu Jun 23 20:46:11 2016 Scale menu position back to viewport in pepper plugin pepper uses DIP, so it needs to be converted to viewport in use-zoom-for-dsf mode. BUG= 621943 ,485650 TEST=manual Review-Url: https://codereview.chromium.org/2082893003 Cr-Commit-Position: refs/heads/master@{#401024} (cherry picked from commit 9373922b7d01101f232c6ccfdedefd76e338e3ab) Review URL: https://codereview.chromium.org/2094843002 . Cr-Commit-Position: refs/branch-heads/2743@{#459} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/8943b97229c51f6ef0e1eb036089e9b68eff5cf7/content/renderer/pepper/pepper_plugin_instance_impl.cc [modify] https://crrev.com/8943b97229c51f6ef0e1eb036089e9b68eff5cf7/content/renderer/pepper/renderer_ppapi_host_impl.cc [modify] https://crrev.com/8943b97229c51f6ef0e1eb036089e9b68eff5cf7/content/renderer/pepper/renderer_ppapi_host_impl.h
,
Jun 28 2016
oshima@ - Could you please provide manual steps to test this issue, It will be helpful for chrome TE team to verify it. Thanks!
,
Jun 28 2016
On high DPI device like link, samus, open context menu on flash content.
,
Jul 28 2016
Tested this issue on high DPI device Windows-10 using chrome latest Dev M53-53.0.2785.34. oshima@ - Attaching screen-shot for reference, Could you please confirm is this is the expected behavior of the issue?
,
Jul 28 2016
If it opens at the cursor location (which I can't see in the screenshot :), then it's fixed.
,
Jul 29 2016
As per comment #11 confirmed the issue got fixed on latest Dev M53, Hence adding TE-Verified label. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by osh...@chromium.org
, Jun 21 2016